+/*
+ * "...we will have peace, when you and all your works have perished--and
+ * the works of your dark master to whom you would deliver us. You are a
+ * liar, Saruman, and a corrupter of men's hearts." --Theoden
+ */
+
+#include "EXTERN.h"
+#include "perl.h"
+
void
-taint_proper(f, s)
-char *f;
-char *s;
+taint_proper(const char *f, char *s)
{
- DEBUG_u(fprintf(stderr,"%s %d %d %d\n",s,tainted,uid, euid));
- if (tainted && (!euid || euid != uid || egid != gid || taintanyway)) {
+ dTHR; /* just for taint */
+ char *ug;
+
+ DEBUG_u(PerlIO_printf(Perl_debug_log,
+ "%s %d %d %d\n", s, tainted, uid, euid));
+
+ if (tainted) {
+ if (euid != uid)
+ ug = " while running setuid";
+ else if (egid != gid)
+ ug = " while running setgid";
+ else
+ ug = " while running with -T switch";
if (!unsafe)
- fatal(f, s);
+ croak(f, s, ug);
else if (dowarn)
- warn(f, s);
+ warn(f, s, ug);
}
}
void
-taint_env()
+taint_env(void)
{
SV** svp;
+ MAGIC* mg;
+ char** e;
+ static char* misc_env[] = {
+ "IFS", /* most shells' inter-field separators */
+ "CDPATH", /* ksh dain bramage #1 */
+ "ENV", /* ksh dain bramage #2 */
+ "BASH_ENV", /* bash dain bramage -- I guess it's contagious */
+ NULL
+ };
+
+#ifdef VMS
+ int i = 0;
+ char name[10 + TYPE_DIGITS(int)] = "DCL$PATH";
+
+ while (1) {
+ if (i)
+ (void)sprintf(name,"DCL$PATH;%d", i);
+ svp = hv_fetch(GvHVn(envgv), name, strlen(name), FALSE);
+ if (!svp || *svp == &sv_undef)
+ break;
+ if (SvTAINTED(*svp)) {
+ dTHR;
+ TAINT;
+ taint_proper("Insecure %s%s", "$ENV{DCL$PATH}");
+ }
+ if ((mg = mg_find(*svp, 'e')) && MgTAINTEDDIR(mg)) {
+ dTHR;
+ TAINT;
+ taint_proper("Insecure directory in %s%s", "$ENV{DCL$PATH}");
+ }
+ i++;
+ }
+#endif /* VMS */
svp = hv_fetch(GvHVn(envgv),"PATH",4,FALSE);
- if (!svp || *svp == &sv_undef || (*svp)->sv_tainted) {
- tainted = 1;
- if ((*svp)->sv_tainted == 2)
- taint_proper("Insecure directory in %s", "PATH");
- else
- taint_proper("Insecure %s", "PATH");
+ if (svp && *svp) {
+ if (SvTAINTED(*svp)) {
+ dTHR;
+ TAINT;
+ taint_proper("Insecure %s%s", "$ENV{PATH}");
+ }
+ if ((mg = mg_find(*svp, 'e')) && MgTAINTEDDIR(mg)) {
+ dTHR;
+ TAINT;
+ taint_proper("Insecure directory in %s%s", "$ENV{PATH}");
+ }
+ }
+
+#ifndef VMS
+ /* tainted $TERM is okay if it contains no metachars */
+ svp = hv_fetch(GvHVn(envgv),"TERM",4,FALSE);
+ if (svp && *svp && SvTAINTED(*svp)) {
+ dTHR; /* just for taint */
+ bool was_tainted = tainted;
+ char *t = SvPV(*svp, na);
+ char *e = t + na;
+ tainted = was_tainted;
+ if (t < e && isALNUM(*t))
+ t++;
+ while (t < e && (isALNUM(*t) || *t == '-' || *t == ':'))
+ t++;
+ if (t < e) {
+ TAINT;
+ taint_proper("Insecure $ENV{%s}%s", "TERM");
+ }
}
- svp = hv_fetch(GvHVn(envgv),"IFS",3,FALSE);
- if (svp && *svp != &sv_undef && (*svp)->sv_tainted) {
- tainted = 1;
- taint_proper("Insecure %s", "IFS");
+#endif /* !VMS */
+
+ for (e = misc_env; *e; e++) {
+ svp = hv_fetch(GvHVn(envgv), *e, strlen(*e), FALSE);
+ if (svp && *svp != &sv_undef && SvTAINTED(*svp)) {
+ dTHR; /* just for taint */
+ TAINT;
+ taint_proper("Insecure $ENV{%s}%s", *e);
+ }
}
}
-