throw an error on invalid builder names as well (RT#78479)

[gitmo/Moo.git] / t / method-generate-accessor.t

diff --git a/t/method-generate-accessor.t b/t/method-generate-accessor.t
index f66acfb..256cc5c 100644 (file)
--- a/t/method-generate-accessor.t
+++ b/t/method-generate-accessor.t
@@ -11,6 +11,12 @@ my $gen = Method::Generate::Accessor->new;
   use Moo;
 }
 
+{
+  package WithOverload;
+  use overload '&{}' => sub { sub { 5 } };
+  sub new { bless {} }
+}
+
 $gen->generate_method('Foo' => 'one' => { is => 'ro' });
 
 $gen->generate_method('Foo' => 'two' => { is => 'rw' });
@@ -25,45 +31,61 @@ like(
   qr/Unknown is purple/, 'is purple rejected'
 );
 
-like(
-  exception { $gen->generate_method('Foo' => 'four' => { is => 'ro', default => 5 }) },
-  qr/Invalid default/, 'default - scalar rejected'
-);
+for my $setting (qw( default coerce )) {
+  like(
+    exception { $gen->generate_method('Foo' => 'four' => { is => 'ro', $setting => 5 }) },
+    qr/Invalid $setting/, "$setting - scalar rejected"
+  );
+
+  like(
+    exception { $gen->generate_method('Foo' => 'five' => { is => 'ro', $setting => [] }) },
+    qr/Invalid $setting/, "$setting - arrayref rejected"
+  );
+
+  like(
+    exception { $gen->generate_method('Foo' => 'five' => { is => 'ro', $setting => Foo->new }) },
+    qr/Invalid $setting/, "$setting - non-code-convertible object rejected"
+  );
+
+  is(
+    exception { $gen->generate_method('Foo' => 'six' => { is => 'ro', $setting => sub { 5 } }) },
+    undef, "$setting - coderef accepted"
+  );
+
+  is(
+    exception { $gen->generate_method('Foo' => 'seven' => { is => 'ro', $setting => bless sub { 5 } => 'Blah' }) },
+    undef, "$setting - blessed sub accepted"
+  );
+
+  is(
+    exception { $gen->generate_method('Foo' => 'eight' => { is => 'ro', $setting => WithOverload->new }) },
+    undef, "$setting - object with overloaded ->() accepted"
+  );
+
+  like(
+    exception { $gen->generate_method('Foo' => 'nine' => { is => 'ro', $setting => bless {} => 'Blah' }) },
+    qr/Invalid $setting/, "$setting - object rejected"
+  );
+}
 
-like(
-  exception { $gen->generate_method('Foo' => 'five' => { is => 'ro', default => [] }) },
-  qr/Invalid default/, 'default - arrayref rejected'
+is(
+  exception { $gen->generate_method('Foo' => 'ten' => { is => 'ro', builder => '_build_ten' }) },
+  undef, 'builder - string accepted',
 );
 
 like(
-  exception { $gen->generate_method('Foo' => 'five' => { is => 'ro', default => Foo->new }) },
-  qr/Invalid default/, 'default - non-code-convertible object rejected'
+  exception { $gen->generate_method('Foo' => 'eleven' => { is => 'ro', builder => sub {} }) },
+  qr/Invalid builder/, 'builder - coderef rejected'
 );
 
-is(
-  exception { $gen->generate_method('Foo' => 'six' => { is => 'ro', default => sub { 5 } }) },
-  undef, 'default - coderef accepted'
-);
-
-is(
-  exception { $gen->generate_method('Foo' => 'seven' => { is => 'ro', default => bless sub { 5 } => 'Blah' }) },
-  undef, 'default - blessed sub accepted'
+like(
+  exception { $gen->generate_method('Foo' => 'twelve' => { is => 'ro', builder => 'build:twelve' }) },
+  qr/Invalid builder/, 'builder - invalid name rejected',
 );
 
-{
-  package WithOverload;
-  use overload '&{}' => sub { sub { 5 } };
-  sub new { bless {} }
-}
-
 is(
-  exception { $gen->generate_method('Foo' => 'eight' => { is => 'ro', default => WithOverload->new }) },
-  undef, 'default - object with overloaded ->() accepted'
-);
-
-like(
-  exception { $gen->generate_method('Foo' => 'nine' => { is => 'ro', default => bless {} => 'Blah' }) },
-  qr/Invalid default/, 'default - object rejected'
+  exception { $gen->generate_method('Foo' => 'thirteen' => { is => 'ro', builder => 'build::thirteen' }) },
+  undef, 'builder - fully-qualified name accepted',
 );
 
 my $foo = Foo->new(one => 1);