mssql: clean up extra tests

[dbsrgits/DBIx-Class-Schema-Loader.git] / t / lib / dbixcsl_mssql_extra_tests.pm

diff --git a/t/lib/dbixcsl_mssql_extra_tests.pm b/t/lib/dbixcsl_mssql_extra_tests.pm
index d4125ef..e4767f9 100644 (file)
--- a/t/lib/dbixcsl_mssql_extra_tests.pm
+++ b/t/lib/dbixcsl_mssql_extra_tests.pm
@@ -1,46 +1,55 @@
 package dbixcsl_mssql_extra_tests;
 
+use strict;
+use warnings;
 use Test::More;
+use Test::Exception;
 
-my $vendor = 'mssql';
-
-sub vendor {
-    shift;
-    $vendor = shift;
-}
+# for cleanup in END
+my $storage;
 
 sub extra { +{
     create => [
-        qq{
-            CREATE TABLE [${vendor}_loader_test1.dot] (
+        q{
+            CREATE TABLE [mssql_loader_test1.dot] (
                 id INT IDENTITY NOT NULL PRIMARY KEY,
                 dat VARCHAR(8)
             )
         },
+        q{
+            CREATE TABLE mssql_loader_test3 (
+                id INT IDENTITY NOT NULL PRIMARY KEY
+            )
+        },
+        q{
+            CREATE VIEW mssql_loader_test4 AS
+            SELECT * FROM mssql_loader_test3
+        },
+    ],
+    drop   => [
+        "[mssql_loader_test1.dot]",
+        "mssql_loader_test3"
     ],
-    drop   => [ "[${vendor}_loader_test1.dot]" ],
-    count  => 6,
+    count  => 8,
     run    => sub {
         my ($schema, $monikers, $classes) = @_;
 
 # Test that the table above (with '.' in name) gets loaded correctly.
-        my $vendor_titlecased = "\u\L$vendor";
-
         ok((my $rs = eval {
-            $schema->resultset("${vendor_titlecased}LoaderTest1Dot") }),
-            'got a resultset');
+            $schema->resultset($monikers->{'[mssql_loader_test1.dot]'}) }),
+            'got a resultset for table with dot in name');
 
         ok((my $from = eval { $rs->result_source->from }),
-            'got an $rsrc->from');
+            'got an $rsrc->from for table with dot in name');
 
-        is ref($from), 'SCALAR', '->table is a scalar ref';
+        is ref($from), 'SCALAR', '->table with dot in name is a scalar ref';
 
-        is eval { $$from }, "[${vendor}_loader_test1.dot]",
-            '->table name is correct';
+        is eval { $$from }, "[mssql_loader_test1.dot]",
+            '->table with dot in name has correct name';
 
 # Test that identity columns do not have 'identity' in the data_type, and do
 # have is_auto_increment.
-        my $identity_col_info = $schema->resultset('LoaderTest10')
+        my $identity_col_info = $schema->resultset($monikers->{loader_test10})
             ->result_source->column_info('id10');
 
         is $identity_col_info->{data_type}, 'int',
@@ -48,7 +57,39 @@ sub extra { +{
 
         is $identity_col_info->{is_auto_increment}, 1,
             q{'INT IDENTITY' column has is_auto_increment => 1};
+
+# Test that a bad view (where underlying table is gone) is ignored.
+        $storage = $schema->storage;
+
+        my $dbh = $storage->dbh;
+        $dbh->do("DROP TABLE mssql_loader_test3");
+
+        my @warnings;
+        {
+            local $SIG{__WARN__} = sub { push @warnings, $_[0] };
+            $schema->rescan;
+        }
+        ok ((grep /^Bad table or view 'mssql_loader_test4'/, @warnings),
+            'bad view ignored');
+
+        throws_ok {
+            $schema->resultset($monikers->{mssql_loader_test4})
+        } qr/Can't find source/,
+            'no source registered for bad view';
     },
 }}
 
+# Clean up the bad view
+END {
+    local $@;
+    eval {
+        my $dbh = $storage->dbh;
+        $dbh->do($_) for (
+"CREATE TABLE mssql_loader_test3 (id INT IDENTITY NOT NULL PRIMARY KEY)",
+"DROP VIEW mssql_loader_test4",
+"DROP TABLE mssql_loader_test3",
+        );
+    };
+}
+
 1;