THROWAWAY: Don't load unmodified generated external classes

[dbsrgits/DBIx-Class-Schema-Loader.git] / t / lib / dbixcsl_dumper_tests.pm

diff --git a/t/lib/dbixcsl_dumper_tests.pm b/t/lib/dbixcsl_dumper_tests.pm
index d37900c..c0e0bdf 100644 (file)
--- a/t/lib/dbixcsl_dumper_tests.pm
+++ b/t/lib/dbixcsl_dumper_tests.pm
@@ -1,11 +1,14 @@
 package dbixcsl_dumper_tests;
 
 use strict;
+use warnings;
 use Test::More;
+use File::Basename;
+use File::Copy;
 use File::Path;
 use IPC::Open3;
 use IO::Handle;
-use List::MoreUtils 'any';
+use List::Util 'any';
 use DBIx::Class::Schema::Loader::Utils 'dumper_squashed';
 use DBIx::Class::Schema::Loader ();
 use Class::Unload ();
@@ -13,25 +16,29 @@ use namespace::clean;
 
 use dbixcsl_test_dir '$tdir';
 
-my $DUMP_PATH = "$tdir/dump";
+my $SUB_DIR = 'dump';
+my $DUMP_PATH = "$tdir/$SUB_DIR";
 
 sub cleanup {
     rmtree($DUMP_PATH, 1, 1);
 }
 
 sub class_file {
-    my ($self, $class) = @_;
+    my ($self, $class, $subdir) = @_;
+
+    my $path = $DUMP_PATH;
+    $path =~ s/\Q$SUB_DIR\E\z/$subdir/ if $subdir;
 
     $class =~ s{::}{/}g;
-    $class = $DUMP_PATH . '/' . $class . '.pm';
+    $class = $path . '/' . $class . '.pm';
 
     return $class;
 }
 
 sub append_to_class {
-    my ($self, $class, $string) = @_;
+    my ($self, $class, $string, $destdir) = @_;
 
-    $class = $self->class_file($class);
+    $class = $self->class_file($class, $destdir);
 
     open(my $appendfh, '>>', $class) or die "Failed to open '$class' for append: $!";
 
@@ -40,6 +47,17 @@ sub append_to_class {
     close($appendfh);
 }
 
+sub copy_class {
+    my ($self, $class, $destdir) = @_;
+
+    my $srcfile = $self->class_file($class);
+    my $destfile = $self->class_file($class, $destdir);
+    mkpath(dirname $destfile);
+
+    copy($srcfile, $destfile) or die "Failed to copy '$srcfile' to '$destfile': $!";
+    return $destfile;
+}
+
 sub dump_test {
     my ($self, %tdata) = @_;
 
@@ -64,8 +82,8 @@ sub _dump_directly {
     no strict 'refs';
     @{$schema_class . '::ISA'} = ('DBIx::Class::Schema::Loader');
     $schema_class->loader_options(
-      quiet => 1,
-      %{$tdata{options}},
+        quiet => 1,
+        %{$tdata{options}},
     );
 
     my @warns;
@@ -75,11 +93,13 @@ sub _dump_directly {
     };
     my $err = $@;
 
+    my $classes = !$err && $schema_class->loader->generated_classes;
+
     Class::Unload->unload($schema_class);
 
     _check_error($err, $tdata{error});
 
-    return @warns;
+    return \@warns, $classes;
 }
 
 sub _dump_dbicdump {
@@ -128,7 +148,7 @@ sub _dump_dbicdump {
         _check_error($exception, $tdata{error});
     }
 
-    return @warnings;
+    return \@warnings;
 }
 
 sub _get_connect_info {
@@ -166,18 +186,27 @@ sub _check_error {
 }
 
 sub _test_dumps {
-    my ($tdata, @warns) = @_;
+    my ($tdata, $warns, $classes) = @_;
 
     my %tdata = %{$tdata};
 
     my $schema_class = $tdata{classname};
     my $check_warns = $tdata{warnings};
 
-    is(@warns, @$check_warns, "$schema_class warning count")
-      or diag @warns;
+    is(@$warns, @$check_warns, "$schema_class warning count")
+        or diag @$warns;
 
     for(my $i = 0; $i <= $#$check_warns; $i++) {
-        like(($warns[$i] || ''), $check_warns->[$i], "$schema_class warning $i");
+        like(($warns->[$i] || ''), $check_warns->[$i], "$schema_class warning $i");
+    }
+
+    if ($classes && (my $results = $tdata{generated_results})) {
+        my $ns = $tdata{options}{use_namespaces} ? ("::".($tdata{result_namespace} || "Result")) : "";
+        is_deeply(
+            [ sort grep { $_ ne $schema_class } @$classes ],
+            [ sort map { "${schema_class}${ns}::$_" } @$results ],
+            "$schema_class generated_classes set correctly",
+        );
     }
 
     my $file_regexes = $tdata{regexes};
@@ -199,19 +228,21 @@ sub _test_dumps {
     }
 }
 
-sub _dump_file_like {
+sub _slurp {
     my $path = shift;
-    open(my $dumpfh, '<', $path) or die "Failed to open '$path': $!";
+    open(my $dumpfh, '<:raw', $path) or die "Failed to open '$path': $!";
     my $contents = do { local $/; <$dumpfh>; };
     close($dumpfh);
+    return ($path, $contents);
+}
+
+sub _dump_file_like {
+    my ($path, $contents) = _slurp shift;
     like($contents, $_, "$path matches $_") for @_;
 }
 
 sub _dump_file_not_like {
-    my $path = shift;
-    open(my $dumpfh, '<', $path) or die "Failed to open '$path': $!";
-    my $contents = do { local $/; <$dumpfh>; };
-    close($dumpfh);
+    my ($path, $contents) = _slurp shift;
     unlike($contents, $_, "$path does not match $_") for @_;
 }