use Test::More;
use DBIx::Class::Schema::Loader;
+use Class::Unload;
+use File::Path;
use DBI;
+use Digest::MD5;
+use File::Find 'find';
+
+my $DUMP_DIR = './t/_common_dump';
+rmtree $DUMP_DIR;
sub new {
my $class = shift;
# Only MySQL uses this
$self->{innodb} ||= '';
+
+ # DB2 doesn't support this
+ $self->{null} = 'NULL' unless defined $self->{null};
$self->{verbose} = $ENV{TEST_VERBOSE} || 0;
sub run_tests {
my $self = shift;
- plan tests => 136 + ($self->{extra}->{count} || 0);
+ plan tests => 140 + ($self->{extra}->{count} || 0);
$self->create();
+ my @connect_info = (
+ $self->{dsn},
+ $self->{user},
+ $self->{password},
+ $self->{connect_info_opts},
+ );
+
+ # First, with in-memory classes
+ my $schema_class = $self->setup_schema(@connect_info);
+ $self->test_schema($schema_class);
+ $self->drop_tables;
+}
+
+# defined in sub create
+my (@statements, @statements_reltests, @statements_advanced,
+ @statements_advanced_sqlite, @statements_inline_rels,
+ @statements_implicit_rels);
+
+sub setup_schema {
+ my $self = shift;
+ my @connect_info = @_;
+
my $schema_class = 'DBIXCSL_Test::Schema';
my $debug = ($self->{verbose} > 1) ? 1 : 0;
- my @connect_info = ( $self->{dsn}, $self->{user}, $self->{password} );
my %loader_opts = (
- constraint => qr/^(?:\S+\.)?(?:$self->{vendor}_)?loader_test[0-9]+$/i,
+ constraint =>
+ qr/^(?:\S+\.)?(?:$self->{vendor}_)?loader_test[0-9]+(?!.*_)/i,
relationships => 1,
additional_classes => 'TestAdditional',
additional_base_classes => 'TestAdditionalBase',
left_base_classes => [ qw/TestLeftBase/ ],
components => [ qw/TestComponent/ ],
+ resultset_components => [ qw/TestRSComponent/ ],
inflect_plural => { loader_test4 => 'loader_test4zes' },
inflect_singular => { fkid => 'fkid_singular' },
moniker_map => \&_monikerize,
debug => $debug,
+ use_namespaces => 0,
+ dump_directory => $DUMP_DIR,
);
$loader_opts{db_schema} = $self->{db_schema} if $self->{db_schema};
- eval { require Class::Inspector };
- if($@) {
- $self->{_no_rs_components} = 1;
- }
- else {
- $loader_opts{resultset_components} = [ qw/TestRSComponent/ ];
- }
{
my @loader_warnings;
__PACKAGE__->loader_options(\%loader_opts);
__PACKAGE__->connection(\@connect_info);
};
- ok(!$@, "Loader initialization") or diag $@;
+
+ ok(!$@, "Loader initialization") or diag $@;
+
+ my $file_count;
+ find sub { return if -d; $file_count++ }, $DUMP_DIR;
+
+ my $expected_count = 34;
+
+ $expected_count += grep /CREATE (?:TABLE|VIEW)/i,
+ @{ $self->{extra}{create} || [] };
+
+ $expected_count -= grep /CREATE TABLE/, @statements_inline_rels
+ if $self->{skip_rels} || $self->{no_inline_rels};
+
+ $expected_count -= grep /CREATE TABLE/, @statements_implicit_rels
+ if $self->{skip_rels} || $self->{no_implicit_rels};
+
+ $expected_count -= grep /CREATE TABLE/, ($self->{vendor} =~ /sqlite/ ? @statements_advanced_sqlite : @statements_advanced), @statements_reltests
+ if $self->{skip_rels};
+
+ is $file_count, $expected_count, 'correct number of files generated';
+
+ exit if $file_count != $expected_count;
+
+ my $warn_count = 2;
+ $warn_count++ if grep /ResultSetManager/, @loader_warnings;
+
+ $warn_count++ for grep /^Bad table or view/, @loader_warnings;
+
+ my $vendor = $self->{vendor};
+ $warn_count++ for grep /${vendor}_\S+ has no primary key/,
+ @loader_warnings;
+
if($self->{skip_rels}) {
- is(scalar(@loader_warnings), 0)
- or diag "Did not get the expected 0 warnings. Warnings are: "
- . join('',@loader_warnings);
- ok(1);
+ SKIP: {
+ is(scalar(@loader_warnings), $warn_count, "No loader warnings")
+ or diag @loader_warnings;
+ skip "No missing PK warnings without rels", 1;
+ }
}
else {
- is(scalar(@loader_warnings), 1)
- or diag "Did not get the expected 1 warning. Warnings are: "
- . join('',@loader_warnings);
- like($loader_warnings[0], qr/loader_test9 has no primary key/i);
+ $warn_count++;
+ is(scalar(@loader_warnings), $warn_count, "Expected loader warning")
+ or diag @loader_warnings;
+ is(grep(/loader_test9 has no primary key/, @loader_warnings), 1,
+ "Missing PK warning");
}
}
+
+ return $schema_class;
+}
+
+sub test_schema {
+ my $self = shift;
+ my $schema_class = shift;
my $conn = $schema_class->clone;
my $monikers = {};
$classes->{$table_name} = $schema_class . q{::} . $source_name;
}
- my $moniker1 = $monikers->{loader_test1};
- my $class1 = $classes->{loader_test1};
+ my $moniker1 = $monikers->{loader_test1s};
+ my $class1 = $classes->{loader_test1s};
my $rsobj1 = $conn->resultset($moniker1);
+ check_no_duplicate_unique_constraints($class1);
my $moniker2 = $monikers->{loader_test2};
my $class2 = $classes->{loader_test2};
my $rsobj2 = $conn->resultset($moniker2);
+ check_no_duplicate_unique_constraints($class2);
my $moniker23 = $monikers->{LOADER_TEST23};
my $class23 = $classes->{LOADER_TEST23};
isa_ok( $rsobj24, "DBIx::Class::ResultSet" );
my @columns_lt2 = $class2->columns;
- is($columns_lt2[0], 'id', "Column Ordering 0");
- is($columns_lt2[1], 'dat', "Column Ordering 1");
- is($columns_lt2[2], 'dat2', "Column Ordering 2");
+ is_deeply( \@columns_lt2, [ qw/id dat dat2/ ], "Column Ordering" );
my %uniq1 = $class1->unique_constraints;
my $uniq1_test = 0;
last;
}
}
- ok($uniq1_test) or diag "Unique constraints not working";
+ ok($uniq1_test, "Unique constraint");
+
+ is($moniker1, 'LoaderTest1', 'moniker singularisation');
my %uniq2 = $class2->unique_constraints;
my $uniq2_test = 0;
last;
}
}
- ok($uniq2_test) or diag "Multi-col unique constraints not working";
+ ok($uniq2_test, "Multi-col unique constraint");
is($moniker2, 'LoaderTest2X', "moniker_map testing");
- {
- my ($skip_tab, $skip_tabo, $skip_taba, $skip_cmeth,
- $skip_rsmeth, $skip_tcomp, $skip_trscomp);
-
- can_ok( $class1, 'test_additional_base' ) or $skip_tab = 1;
- can_ok( $class1, 'test_additional_base_override' ) or $skip_tabo = 1;
- can_ok( $class1, 'test_additional_base_additional' ) or $skip_taba = 1;
- can_ok( $class1, 'dbix_class_testcomponent' ) or $skip_tcomp = 1;
- can_ok( $class1, 'loader_test1_classmeth' ) or $skip_cmeth = 1;
-
- TODO: {
- local $TODO = "Not yet supported by ResultSetManger code";
- can_ok( $rsobj1, 'loader_test1_rsmeth' ) or $skip_rsmeth = 1;
- }
-
- SKIP: {
- skip "Pre-requisite test failed", 1 if $skip_tab;
- is( $class1->test_additional_base, "test_additional_base",
- "Additional Base method" );
- }
-
- SKIP: {
- skip "Pre-requisite test failed", 1 if $skip_tabo;
- is( $class1->test_additional_base_override,
- "test_left_base_override",
- "Left Base overrides Additional Base method" );
- }
-
- SKIP: {
- skip "Pre-requisite test failed", 1 if $skip_taba;
- is( $class1->test_additional_base_additional, "test_additional",
- "Additional Base can use Additional package method" );
- }
+ SKIP: {
+ can_ok( $class1, 'test_additional_base' )
+ or skip "Pre-requisite test failed", 1;
+ is( $class1->test_additional_base, "test_additional_base",
+ "Additional Base method" );
+ }
- SKIP: {
- skip "Pre-requisite test failed", 1 if $skip_tcomp;
- is( $class1->dbix_class_testcomponent,
- 'dbix_class_testcomponent works' );
- }
+ SKIP: {
+ can_ok( $class1, 'test_additional_base_override' )
+ or skip "Pre-requisite test failed", 1;
+ is( $class1->test_additional_base_override,
+ "test_left_base_override",
+ "Left Base overrides Additional Base method" );
+ }
- SKIP: {
- skip "These two tests need Class::Inspector installed", 2
- if $self->{_no_rs_components};
- can_ok($rsobj1, 'dbix_class_testrscomponent') or $skip_trscomp = 1;
- SKIP: {
- skip "Pre-requisite test failed", 1 if $skip_trscomp;
- is( $rsobj1->dbix_class_testrscomponent,
- 'dbix_class_testrscomponent works' );
- }
- }
+ SKIP: {
+ can_ok( $class1, 'test_additional_base_additional' )
+ or skip "Pre-requisite test failed", 1;
+ is( $class1->test_additional_base_additional, "test_additional",
+ "Additional Base can use Additional package method" );
+ }
- SKIP: {
- skip "Pre-requisite test failed", 1 if $skip_cmeth;
- is( $class1->loader_test1_classmeth, 'all is well' );
- }
+ SKIP: {
+ can_ok( $class1, 'dbix_class_testcomponent' )
+ or skip "Pre-requisite test failed", 1;
+ is( $class1->dbix_class_testcomponent,
+ 'dbix_class_testcomponent works',
+ 'Additional Component' );
+ }
- # XXX put this back in when the TODO above works...
- #SKIP: {
- # skip "Pre-requisite test failed", 1 if $skip_rsmeth;
- # is( $rsobj1->loader_test1_rsmeth, 'all is still well' );
- #}
+ SKIP: {
+ can_ok($rsobj1, 'dbix_class_testrscomponent')
+ or skip "Pre-requisite test failed", 1;
+ is( $rsobj1->dbix_class_testrscomponent,
+ 'dbix_class_testrscomponent works',
+ 'ResultSet component' );
}
SKIP: {
- skip "This vendor doesn't detect auto-increment columns", 1
- if $self->{no_auto_increment};
+ can_ok( $class1, 'loader_test1_classmeth' )
+ or skip "Pre-requisite test failed", 1;
+ is( $class1->loader_test1_classmeth, 'all is well', 'Class method' );
+ }
- is( $class1->column_info('id')->{is_auto_increment}, 1,
- 'Setting is_auto_incrment works'
- );
+ SKIP: {
+ can_ok( $rsobj1, 'loader_test1_rsmeth' )
+ or skip "Pre-requisite test failed";
+ is( $rsobj1->loader_test1_rsmeth, 'all is still well', 'Result set method' );
}
+
+ ok( $class1->column_info('id')->{is_auto_increment}, 'is_auto_incrment detection' );
+ is($class2->column_info('dat2')->{default_value}, 'foo', 'Correct default value');
my $obj = $rsobj1->find(1);
- is( $obj->id, 1 );
- is( $obj->dat, "foo" );
- is( $rsobj2->count, 4 );
+ is( $obj->id, 1, "Find got the right row" );
+ is( $obj->dat, "foo", "Column value" );
+ is( $rsobj2->count, 4, "Count" );
my $saved_id;
eval {
my $new_obj1 = $rsobj1->create({ dat => 'newthing' });
$saved_id = $new_obj1->id;
};
- ok(!$@) or diag "Died during create new record using a PK::Auto key: $@";
- ok($saved_id) or diag "Failed to get PK::Auto-generated id";
+ ok(!$@, "Inserting new record using a PK::Auto key didn't die") or diag $@;
+ ok($saved_id, "Got PK::Auto-generated id");
my $new_obj1 = $rsobj1->search({ dat => 'newthing' })->first;
- ok($new_obj1) or diag "Cannot find newly inserted PK::Auto record";
- is($new_obj1->id, $saved_id);
+ ok($new_obj1, "Found newly inserted PK::Auto record");
+ is($new_obj1->id, $saved_id, "Correct PK::Auto-generated id");
my ($obj2) = $rsobj2->search({ dat => 'bbb' })->first;
is( $obj2->id, 2 );
SKIP: {
- skip $self->{skip_rels}, 69 if $self->{skip_rels};
+ skip $self->{skip_rels}, 96 if $self->{skip_rels};
my $moniker3 = $monikers->{loader_test3};
my $class3 = $classes->{loader_test3};
my $obj4 = $rsobj4->find(123);
isa_ok( $obj4->fkid_singular, $class3);
- ok($class4->column_info('fkid')->{is_foreign_key});
+ ok($class4->column_info('fkid')->{is_foreign_key}, 'Foreign key detected');
my $obj3 = $rsobj3->find(1);
my $rs_rel4 = $obj3->search_related('loader_test4zes');
isa_ok( $rs_rel4->first, $class4);
# find on multi-col pk
- my $obj5 = $rsobj5->find({id1 => 1, id2 => 1});
- is( $obj5->id2, 1 );
+ my $obj5 =
+ eval { $rsobj5->find({id1 => 1, iD2 => 1}) } ||
+ eval { $rsobj5->find({id1 => 1, id2 => 1}) };
+ die $@ if $@;
+
+ is( $obj5->id2, 1, "Find on multi-col PK" );
# mulit-col fk def
my $obj6 = $rsobj6->find(1);
isa_ok( $obj6->loader_test2, $class2);
isa_ok( $obj6->loader_test5, $class5);
- ok($class6->column_info('loader_test2')->{is_foreign_key});
- ok($class6->column_info('id')->{is_foreign_key});
- ok($class6->column_info('id2')->{is_foreign_key});
+ ok($class6->column_info('loader_test2_id')->{is_foreign_key}, 'Foreign key detected');
+ ok($class6->column_info('id')->{is_foreign_key}, 'Foreign key detected');
+
+ my $id2_info = eval { $class6->column_info('id2') } ||
+ $class6->column_info('Id2');
+ ok($id2_info->{is_foreign_key}, 'Foreign key detected');
# fk that references a non-pk key (UNIQUE)
my $obj8 = $rsobj8->find(1);
isa_ok( $obj8->loader_test7, $class7);
- ok($class8->column_info('loader_test7')->{is_foreign_key});
+ ok($class8->column_info('loader_test7')->{is_foreign_key}, 'Foreign key detected');
# test double-fk 17 ->-> 16
my $obj17 = $rsobj17->find(33);
my $rs_rel16_one = $obj17->loader16_one;
isa_ok($rs_rel16_one, $class16);
- is($rs_rel16_one->dat, 'y16');
+ is($rs_rel16_one->dat, 'y16', "Multiple FKs to same table");
- ok($class17->column_info('loader16_one')->{is_foreign_key});
+ ok($class17->column_info('loader16_one')->{is_foreign_key}, 'Foreign key detected');
my $rs_rel16_two = $obj17->loader16_two;
isa_ok($rs_rel16_two, $class16);
- is($rs_rel16_two->dat, 'z16');
+ is($rs_rel16_two->dat, 'z16', "Multiple FKs to same table");
- ok($class17->column_info('loader16_two')->{is_foreign_key});
+ ok($class17->column_info('loader16_two')->{is_foreign_key}, 'Foreign key detected');
my $obj16 = $rsobj16->find(2);
my $rs_rel17 = $obj16->search_related('loader_test17_loader16_ones');
isa_ok($rs_rel17->first, $class17);
- is($rs_rel17->first->id, 3);
+ is($rs_rel17->first->id, 3, "search_related with multiple FKs from same table");
# XXX test m:m 18 <- 20 -> 19
- ok($class20->column_info('parent')->{is_foreign_key});
- ok($class20->column_info('child')->{is_foreign_key});
+ ok($class20->column_info('parent')->{is_foreign_key}, 'Foreign key detected');
+ ok($class20->column_info('child')->{is_foreign_key}, 'Foreign key detected');
# XXX test double-fk m:m 21 <- 22 -> 21
- ok($class22->column_info('parent')->{is_foreign_key});
- ok($class22->column_info('child')->{is_foreign_key});
+ ok($class22->column_info('parent')->{is_foreign_key}, 'Foreign key detected');
+ ok($class22->column_info('child')->{is_foreign_key}, 'Foreign key detected');
# test double multi-col fk 26 -> 25
my $obj26 = $rsobj26->find(33);
my $rs_rel25_one = $obj26->loader_test25_id_rel1;
isa_ok($rs_rel25_one, $class25);
- is($rs_rel25_one->dat, 'x25');
+ is($rs_rel25_one->dat, 'x25', "Multiple multi-col FKs to same table");
- ok($class26->column_info('id')->{is_foreign_key});
- ok($class26->column_info('rel1')->{is_foreign_key});
- ok($class26->column_info('rel2')->{is_foreign_key});
+ ok($class26->column_info('id')->{is_foreign_key}, 'Foreign key detected');
+ ok($class26->column_info('rel1')->{is_foreign_key}, 'Foreign key detected');
+ ok($class26->column_info('rel2')->{is_foreign_key}, 'Foreign key detected');
my $rs_rel25_two = $obj26->loader_test25_id_rel2;
isa_ok($rs_rel25_two, $class25);
- is($rs_rel25_two->dat, 'y25');
+ is($rs_rel25_two->dat, 'y25', "Multiple multi-col FKs to same table");
my $obj25 = $rsobj25->find(3,42);
my $rs_rel26 = $obj25->search_related('loader_test26_id_rel1s');
isa_ok($rs_rel26->first, $class26);
- is($rs_rel26->first->id, 3);
+ is($rs_rel26->first->id, 3, "search_related with multiple multi-col FKs from same table");
# test one-to-one rels
my $obj27 = $rsobj27->find(1);
my $obj28 = $obj27->loader_test28;
isa_ok($obj28, $class28);
- is($obj28->get_column('id'), 1);
+ is($obj28->get_column('id'), 1, "One-to-one relationship with PRIMARY FK");
- ok($class28->column_info('id')->{is_foreign_key});
+ ok($class28->column_info('id')->{is_foreign_key}, 'Foreign key detected');
my $obj29 = $obj27->loader_test29;
isa_ok($obj29, $class29);
- is($obj29->id, 1);
+ is($obj29->id, 1, "One-to-one relationship with UNIQUE FK");
- ok($class29->column_info('fk')->{is_foreign_key});
+ ok($class29->column_info('fk')->{is_foreign_key}, 'Foreign key detected');
$obj27 = $rsobj27->find(2);
- is($obj27->loader_test28, undef);
- is($obj27->loader_test29, undef);
+ is($obj27->loader_test28, undef, "Undef for missing one-to-one row");
+ is($obj27->loader_test29, undef, "Undef for missing one-to-one row");
# test outer join for nullable referring columns:
SKIP: {
skip "unreliable column info from db driver",11 unless
($class32->column_info('rel2')->{is_nullable});
- ok($class32->column_info('rel1')->{is_foreign_key});
- ok($class32->column_info('rel2')->{is_foreign_key});
+ ok($class32->column_info('rel1')->{is_foreign_key}, 'Foreign key detected');
+ ok($class32->column_info('rel2')->{is_foreign_key}, 'Foreign key detected');
my $obj32 = $rsobj32->find(1,{prefetch=>[qw/rel1 rel2/]});
my $obj34 = $rsobj34->find(
isa_ok($obj32,$class32) or $skip_outerjoin = 1;
isa_ok($obj34,$class34) or $skip_outerjoin = 1;
- ok($class34->column_info('id')->{is_foreign_key});
- ok($class34->column_info('rel1')->{is_foreign_key});
- ok($class34->column_info('rel2')->{is_foreign_key});
+ ok($class34->column_info('id')->{is_foreign_key}, 'Foreign key detected');
+ ok($class34->column_info('rel1')->{is_foreign_key}, 'Foreign key detected');
+ ok($class34->column_info('rel2')->{is_foreign_key}, 'Foreign key detected');
SKIP: {
skip "Pre-requisite test failed", 4 if $skip_outerjoin;
my $rs_rel31_one = $obj32->rel1;
my $rs_rel31_two = $obj32->rel2;
- isa_ok($rs_rel31_one,$class31);
- is($rs_rel31_two,undef);
+ isa_ok($rs_rel31_one, $class31);
+ is($rs_rel31_two, undef);
my $rs_rel33_one = $obj34->loader_test33_id_rel1;
my $rs_rel33_two = $obj34->loader_test33_id_rel2;
isa_ok($rs_rel33_one,$class33);
- is($rs_rel33_two,undef);
+ is($rs_rel33_two, undef);
}
}
# from Chisel's tests...
- SKIP: {
- if($self->{vendor} =~ /sqlite/i) {
- skip 'SQLite cannot do the advanced tests', 10;
- }
+ my $moniker10 = $monikers->{loader_test10};
+ my $class10 = $classes->{loader_test10};
+ my $rsobj10 = $conn->resultset($moniker10);
- my $moniker10 = $monikers->{loader_test10};
- my $class10 = $classes->{loader_test10};
- my $rsobj10 = $conn->resultset($moniker10);
+ my $moniker11 = $monikers->{loader_test11};
+ my $class11 = $classes->{loader_test11};
+ my $rsobj11 = $conn->resultset($moniker11);
- my $moniker11 = $monikers->{loader_test11};
- my $class11 = $classes->{loader_test11};
- my $rsobj11 = $conn->resultset($moniker11);
+ isa_ok( $rsobj10, "DBIx::Class::ResultSet" );
+ isa_ok( $rsobj11, "DBIx::Class::ResultSet" );
- isa_ok( $rsobj10, "DBIx::Class::ResultSet" );
- isa_ok( $rsobj11, "DBIx::Class::ResultSet" );
+ ok($class10->column_info('loader_test11')->{is_foreign_key}, 'Foreign key detected');
+ ok($class11->column_info('loader_test10')->{is_foreign_key}, 'Foreign key detected');
- ok($class10->column_info('loader_test11')->{is_foreign_key});
- ok($class11->column_info('loader_test10')->{is_foreign_key});
+ my $obj10 = $rsobj10->create({ subject => 'xyzzy' });
- my $obj10 = $rsobj10->create({ subject => 'xyzzy' });
+ $obj10->update();
+ ok( defined $obj10, 'Create row' );
- $obj10->update();
- ok( defined $obj10, '$obj10 is defined' );
+ my $obj11 = $rsobj11->create({ loader_test10 => $obj10->id() });
+ $obj11->update();
+ ok( defined $obj11, 'Create related row' );
- my $obj11 = $rsobj11->create({ loader_test10 => $obj10->id() });
- $obj11->update();
- ok( defined $obj11, '$obj11 is defined' );
+ eval {
+ my $obj10_2 = $obj11->loader_test10;
+ $obj10_2->loader_test11( $obj11->id11() );
+ $obj10_2->update();
+ };
+ ok(!$@, "Setting up circular relationship");
- eval {
- my $obj10_2 = $obj11->loader_test10;
- $obj10_2->loader_test11( $obj11->id11() );
- $obj10_2->update();
- };
- is($@, '', 'No errors after eval{}');
+ SKIP: {
+ skip 'Previous eval block failed', 3 if $@;
+
+ my $results = $rsobj10->search({ subject => 'xyzzy' });
+ is( $results->count(), 1, 'No duplicate row created' );
- SKIP: {
- skip 'Previous eval block failed', 3
- unless ($@ eq '');
-
- my $results = $rsobj10->search({ subject => 'xyzzy' });
- is( $results->count(), 1,
- 'One $rsobj10 returned from search' );
-
- my $obj10_3 = $results->first();
- isa_ok( $obj10_3, $class10 );
- is( $obj10_3->loader_test11()->id(), $obj11->id(),
- 'found same $rsobj11 object we expected' );
- }
+ my $obj10_3 = $results->first();
+ isa_ok( $obj10_3, $class10 );
+ is( $obj10_3->loader_test11()->id(), $obj11->id(),
+ 'Circular rel leads back to same row' );
}
SKIP: {
isa_ok( $rsobj12, "DBIx::Class::ResultSet" );
isa_ok( $rsobj13, "DBIx::Class::ResultSet" );
- ok($class13->column_info('id')->{is_foreign_key});
- ok($class13->column_info('loader_test12')->{is_foreign_key});
- ok($class13->column_info('dat')->{is_foreign_key});
+ ok($class13->column_info('id')->{is_foreign_key}, 'Foreign key detected');
+ ok($class13->column_info('loader_test12')->{is_foreign_key}, 'Foreign key detected');
+ ok($class13->column_info('dat')->{is_foreign_key}, 'Foreign key detected');
my $obj13 = $rsobj13->find(1);
isa_ok( $obj13->id, $class12 );
isa_ok( $rsobj14, "DBIx::Class::ResultSet" );
isa_ok( $rsobj15, "DBIx::Class::ResultSet" );
- ok($class15->column_info('loader_test14')->{is_foreign_key});
+ ok($class15->column_info('loader_test14')->{is_foreign_key}, 'Foreign key detected');
my $obj15 = $rsobj15->find(1);
isa_ok( $obj15->loader_test14, $class14 );
}
}
- # rescan test
+ # rescan and norewrite test
SKIP: {
- skip $self->{skip_rels}, 5 if $self->{skip_rels};
-
my @statements_rescan = (
qq{
CREATE TABLE loader_test30 (
q{ INSERT INTO loader_test30 (id,loader_test2) VALUES(321, 2) },
);
+ # get md5
+ my $digest = Digest::MD5->new;
+
+ my $find_cb = sub {
+ return if -d;
+ return if $_ eq 'LoaderTest30.pm';
+
+ open my $fh, '<', $_ or die "Could not open $_ for reading: $!";
+ binmode $fh;
+ $digest->addfile($fh);
+ };
+
+ find $find_cb, $DUMP_DIR;
+
+ my $before_digest = $digest->digest;
+
my $dbh = $self->dbconnect(1);
- $dbh->do($_) for @statements_rescan;
+
+ {
+ # Silence annoying but harmless postgres "NOTICE: CREATE TABLE..."
+ local $SIG{__WARN__} = sub {
+ my $msg = shift;
+ print STDERR $msg unless $msg =~ m{^NOTICE:\s+CREATE TABLE};
+ };
+
+ $dbh->do($_) for @statements_rescan;
+ }
+
$dbh->disconnect;
- my @new = $conn->rescan;
- is(scalar(@new), 1);
- is($new[0], 'LoaderTest30');
+ sleep 1;
+
+ my @new = do {
+ # kill the 'Dumping manual schema' warnings
+ local $SIG{__WARN__} = sub {};
+ $conn->rescan;
+ };
+ is_deeply(\@new, [ qw/LoaderTest30/ ], "Rescan");
+
+ $digest = Digest::MD5->new;
+ find $find_cb, $DUMP_DIR;
+ my $after_digest = $digest->digest;
+
+ is $before_digest, $after_digest,
+ 'dumped files are not rewritten when there is no modification';
my $rsobj30 = $conn->resultset('LoaderTest30');
isa_ok($rsobj30, 'DBIx::Class::ResultSet');
+
+ skip 'no rels', 2 if $self->{skip_rels};
+
my $obj30 = $rsobj30->find(123);
isa_ok( $obj30->loader_test2, $class2);
- ok($rsobj30->result_source->column_info('loader_test2')->{is_foreign_key});
+ ok($rsobj30->result_source->column_info('loader_test2')->{is_foreign_key},
+ 'Foreign key detected');
}
$self->{extra}->{run}->($conn, $monikers, $classes) if $self->{extra}->{run};
}
+sub check_no_duplicate_unique_constraints {
+ my ($class) = @_;
+
+ # unique_constraints() automatically includes the PK, if any
+ my %uc_cols;
+ ++$uc_cols{ join ", ", @$_ }
+ for values %{ { $class->unique_constraints } };
+ my $dup_uc = grep { $_ > 1 } values %uc_cols;
+
+ is($dup_uc, 0, "duplicate unique constraints ($class)")
+ or diag "uc_cols: @{[ %uc_cols ]}";
+}
+
sub dbconnect {
my ($self, $complain) = @_;
$self->{_created} = 1;
my $make_auto_inc = $self->{auto_inc_cb} || sub {};
- my @statements = (
+ @statements = (
qq{
- CREATE TABLE loader_test1 (
+ CREATE TABLE loader_test1s (
id $self->{auto_inc_pk},
dat VARCHAR(32) NOT NULL UNIQUE
) $self->{innodb}
},
- $make_auto_inc->(qw/loader_test1 id/),
+ $make_auto_inc->(qw/loader_test1s id/),
- q{ INSERT INTO loader_test1 (dat) VALUES('foo') },
- q{ INSERT INTO loader_test1 (dat) VALUES('bar') },
- q{ INSERT INTO loader_test1 (dat) VALUES('baz') },
+ q{ INSERT INTO loader_test1s (dat) VALUES('foo') },
+ q{ INSERT INTO loader_test1s (dat) VALUES('bar') },
+ q{ INSERT INTO loader_test1s (dat) VALUES('baz') },
qq{
CREATE TABLE loader_test2 (
id $self->{auto_inc_pk},
dat VARCHAR(32) NOT NULL,
- dat2 VARCHAR(32) NOT NULL,
+ dat2 VARCHAR(32) NOT NULL DEFAULT 'foo',
UNIQUE (dat2, dat)
) $self->{innodb}
},
},
);
- my @statements_reltests = (
+ @statements_reltests = (
qq{
CREATE TABLE loader_test3 (
id INTEGER NOT NULL PRIMARY KEY,
id1 INTEGER NOT NULL,
iD2 INTEGER NOT NULL,
dat VARCHAR(8),
- PRIMARY KEY (id1,id2)
+ PRIMARY KEY (id1,iD2)
) $self->{innodb}
},
- q{ INSERT INTO loader_test5 (id1,id2,dat) VALUES (1,1,'aaa') },
+ q{ INSERT INTO loader_test5 (id1,iD2,dat) VALUES (1,1,'aaa') },
qq{
CREATE TABLE loader_test6 (
id INTEGER NOT NULL PRIMARY KEY,
Id2 INTEGER,
- loader_test2 INTEGER,
+ loader_test2_id INTEGER,
dat VARCHAR(8),
- FOREIGN KEY (loader_test2) REFERENCES loader_test2 (id),
+ FOREIGN KEY (loader_test2_id) REFERENCES loader_test2 (id),
FOREIGN KEY(id,Id2) REFERENCES loader_test5 (id1,iD2)
) $self->{innodb}
},
- (q{ INSERT INTO loader_test6 (id, id2,loader_test2,dat) } .
+ (q{ INSERT INTO loader_test6 (id, Id2,loader_test2_id,dat) } .
q{ VALUES (1, 1,1,'aaa') }),
qq{
qq{
CREATE TABLE loader_test29 (
id INTEGER NOT NULL PRIMARY KEY,
- fk INTEGER UNIQUE,
+ fk INTEGER NOT NULL UNIQUE,
FOREIGN KEY (fk) REFERENCES loader_test27 (id)
) $self->{innodb}
},
CREATE TABLE loader_test32 (
id INTEGER NOT NULL PRIMARY KEY,
rel1 INTEGER NOT NULL,
- rel2 INTEGER NULL,
+ rel2 INTEGER $self->{null},
FOREIGN KEY (rel1) REFERENCES loader_test31(id),
FOREIGN KEY (rel2) REFERENCES loader_test31(id)
) $self->{innodb}
CREATE TABLE loader_test34 (
id INTEGER NOT NULL PRIMARY KEY,
rel1 INTEGER NOT NULL,
- rel2 INTEGER NULL,
+ rel2 INTEGER $self->{null},
FOREIGN KEY (id,rel1) REFERENCES loader_test33(id1,id2),
FOREIGN KEY (id,rel2) REFERENCES loader_test33(id1,id2)
) $self->{innodb}
q{ INSERT INTO loader_test34 (id,rel1) VALUES (1,2) },
);
- my @statements_advanced = (
+ @statements_advanced = (
qq{
CREATE TABLE loader_test10 (
id10 $self->{auto_inc_pk},
subject VARCHAR(8),
- loader_test11 INTEGER
+ loader_test11 INTEGER $self->{null}
) $self->{innodb}
},
$make_auto_inc->(qw/loader_test10 id10/),
CREATE TABLE loader_test11 (
id11 $self->{auto_inc_pk},
message VARCHAR(8) DEFAULT 'foo',
- loader_test10 INTEGER,
+ loader_test10 INTEGER $self->{null},
FOREIGN KEY (loader_test10) REFERENCES loader_test10 (id10)
) $self->{innodb}
},
q{ REFERENCES loader_test11 (id11) }),
);
- my @statements_inline_rels = (
+ @statements_advanced_sqlite = (
+ qq{
+ CREATE TABLE loader_test10 (
+ id10 $self->{auto_inc_pk},
+ subject VARCHAR(8)
+ ) $self->{innodb}
+ },
+ $make_auto_inc->(qw/loader_test10 id10/),
+
+ qq{
+ CREATE TABLE loader_test11 (
+ id11 $self->{auto_inc_pk},
+ message VARCHAR(8) DEFAULT 'foo',
+ loader_test10 INTEGER $self->{null},
+ FOREIGN KEY (loader_test10) REFERENCES loader_test10 (id10)
+ ) $self->{innodb}
+ },
+ $make_auto_inc->(qw/loader_test11 id11/),
+
+ (q{ ALTER TABLE loader_test10 ADD COLUMN } .
+ q{ loader_test11 INTEGER REFERENCES loader_test11 (id11) }),
+ );
+
+ @statements_inline_rels = (
qq{
CREATE TABLE loader_test12 (
id INTEGER NOT NULL PRIMARY KEY,
);
- my @statements_implicit_rels = (
+ @statements_implicit_rels = (
qq{
CREATE TABLE loader_test14 (
id INTEGER NOT NULL PRIMARY KEY,
# to test one for mysql, which works on everyone else...
# this all needs to be refactored anyways.
$dbh->do($_) for (@statements_reltests);
- unless($self->{vendor} =~ /sqlite/i) {
+ if($self->{vendor} =~ /sqlite/i) {
+ $dbh->do($_) for (@statements_advanced_sqlite);
+ }
+ else {
$dbh->do($_) for (@statements_advanced);
}
unless($self->{no_inline_rels}) {
my $self = shift;
my @tables = qw/
- loader_test1
+ loader_test1s
loader_test2
LOADER_TEST23
LoAdEr_test24
/;
my @tables_auto_inc = (
- [ qw/loader_test1 id/ ],
+ [ qw/loader_test1s id/ ],
[ qw/loader_test2 id/ ],
);
unless($self->{skip_rels}) {
$dbh->do("DROP TABLE $_") for (@tables_reltests);
- unless($self->{vendor} =~ /sqlite/i) {
- if($self->{vendor} =~ /mysql/i) {
- $dbh->do($drop_fk_mysql);
- }
- else {
- $dbh->do($drop_fk);
- }
- $dbh->do("DROP TABLE $_") for (@tables_advanced);
- $dbh->do($_) for map { $drop_auto_inc->(@$_) } @tables_advanced_auto_inc;
+ if($self->{vendor} =~ /mysql/i) {
+ $dbh->do($drop_fk_mysql);
}
+ else {
+ $dbh->do($drop_fk);
+ }
+ $dbh->do("DROP TABLE $_") for (@tables_advanced);
+ $dbh->do($_) for map { $drop_auto_inc->(@$_) } @tables_advanced_auto_inc;
+
unless($self->{no_inline_rels}) {
$dbh->do("DROP TABLE $_") for (@tables_inline_rels);
}
unless($self->{no_implicit_rels}) {
$dbh->do("DROP TABLE $_") for (@tables_implicit_rels);
}
- $dbh->do("DROP TABLE $_") for (@tables_rescan);
}
- $dbh->do("DROP TABLE $_") for (@tables);
+ $dbh->do("DROP TABLE $_") for (@tables, @tables_rescan);
$dbh->do($_) for map { $drop_auto_inc->(@$_) } @tables_auto_inc;
$dbh->disconnect;
}
sub DESTROY {
my $self = shift;
- $self->drop_tables if $self->{_created};
+ unless ($ENV{SCHEMA_LOADER_TESTS_NOCLEANUP}) {
+ $self->drop_tables if $self->{_created};
+ rmtree $DUMP_DIR
+ }
}
1;
projects / dbsrgits/DBIx-Class-Schema-Loader.git / blobdiff