Only 2 of the pages in the app test now generate invalid links.

[catagits/Gitalist.git] / t / lib / TestGitalist.pm

diff --git a/t/lib/TestGitalist.pm b/t/lib/TestGitalist.pm
index 05422de..0dce3b4 100644 (file)
--- a/t/lib/TestGitalist.pm
+++ b/t/lib/TestGitalist.pm
@@ -19,17 +19,38 @@ BEGIN {
     constant->import('MECH', $mech );
 }
 
+# Rechecking the same link multiple times is slow and lame!
+# Nicked this from WWW::Mechanize and memoized it...
+my %seen_links;
+sub Test::WWW::Mechanize::Catalyst::page_links_ok {
+    my $self = shift;
+    my $desc = shift;
+
+    $desc = 'All links ok' unless defined $desc;
+
+    my @links = $self->followable_links();
+    my @urls = Test::WWW::Mechanize::_format_links(\@links);
+
+    my @failures = $self->_check_links_status( [ grep { ! $seen_links{$_}++ } @urls ] );
+    my $ok = (@failures==0);
+
+    ok( $ok, $desc );
+    diag( $_ ) for @failures;
+
+    return $ok;
+}
+
+
 sub test_uri {
     my ($uri, $qs) = @_;
-    $qs ||= '';
     my $request = "/$uri"; 
     $request .= "?$qs" if defined $qs;
     my $response = request($request);
-    ok($response->is_success, "ok $uri - $qs");
+    ok($response->is_success, "ok $request");
     if (MECH) {
         my $res = MECH()->get($request);
-        ok $res->is_success, "ok mech $uri - $qs (" . $res->code . ')';
-        MECH()->page_links_ok()
+        ok $res->is_success, "ok mech $request (" . $res->code . ')';
+        MECH()->page_links_ok("All links ok from $request")
             if $res->content_type =~ m|text/html|;
     }
     return $response;