Note that I am now maintaining it.

[p5sagit/Devel-Size.git] / t / basic.t

diff --git a/t/basic.t b/t/basic.t
index 39390dd..cc99c3a 100644 (file)
--- a/t/basic.t
+++ b/t/basic.t
@@ -2,8 +2,6 @@
 
 use Test::More;
 use strict;
-   
-my $tests;
 
 BEGIN
    {
@@ -23,7 +21,7 @@ can_ok ('Devel::Size', qw/
 Devel::Size->import( qw(size total_size) );
 
 die ("Uhoh, test uses an outdated version of Devel::Size")
-  unless is ($Devel::Size::VERSION, '0.70', 'VERSION MATCHES');
+  unless is ($Devel::Size::VERSION, '0.72_50', 'VERSION MATCHES');
 
 #############################################################################
 # some basic checks:
@@ -34,9 +32,9 @@ $foo = "12";
 %foo = (a => 1, b => 2);
 
 my $x = "A string";
-my $y = "A much much longer string";           # need to be at least 7 bytes longer for 64 bit
-ok (size($x) < size($y), 'size() of strings');
-ok (total_size($x) < total_size($y), 'total_size() of strings');
+my $y = "A much much longer string";        # need to be at least 7 bytes longer for 64 bit
+cmp_ok(size($x), '<', size($y), 'size() of strings');
+cmp_ok(total_size($x), '<', total_size($y), 'total_size() of strings');
 
 my @x = (1..4);
 my @y = (1..200);
@@ -44,8 +42,7 @@ my @y = (1..200);
 my $size_1 = total_size(\@x);
 my $size_2 = total_size(\@y);
 
-ok ( $size_1 < $size_2, 'size() of array refs');
-ok (total_size(\@x) < total_size(\@y), 'total_size() of array refs');
+cmp_ok($size_1, '<', $size_2, 'size() of array refs');
 
 # the arrays alone shouldn't be the same size
 $size_1 = size(\@x);
@@ -62,7 +59,7 @@ $y = 12; $y .= '';
 $size_1 = size($x);
 $size_2 = size($y);
 
-ok ($size_1 < $size_2, ' ."" makes string longer');
+cmp_ok($size_1, '<', $size_2, ' ."" makes string longer');
 
 #############################################################################
 # check that the tracking_hash is working
@@ -72,7 +69,7 @@ my @ary1 = (\$a, \$a);
 my @ary2 = (\$a, \$b);
 
 isnt ( total_size(\@ary2) - total_size(\@ary1), 0,
-       'total_size(\@ary1) < total_size(\@ary2)');
+    'total_size(\@ary1) < total_size(\@ary2)');
 
 #############################################################################
 # check that circular references don't mess things up
@@ -92,3 +89,7 @@ isnt (total_size(*foo), 0, 'total_size(*foo) > 0');
 my $code = sub { '1' };
 
 isnt (total_size($code), 0, 'total_size($code) > 0');
+
+##########################################################
+# RT#14849 (& RT#26781 and possibly RT#29238?)
+isnt( total_size( sub{ do{ my $t=0 }; } ), 0, 'total_size( sub{ my $t=0 } ) > 0' );