use strict;
use warnings;
-use Test::More tests => 12;
-
+use Test::Exception;
+use Test::Moose qw( with_immutable );
+use Test::More;
{
package Standard;
{
package Stricter;
+ use Moose;
use MooseX::StrictConstructor;
has 'thing' => ( is => 'rw' );
{
package Subclass;
+ use Moose;
use MooseX::StrictConstructor;
extends 'Stricter';
{
package Tricky;
+ use Moose;
use MooseX::StrictConstructor;
has 'thing' => ( is => 'rw' );
- sub BUILD
- {
+ sub BUILD {
my $self = shift;
my $params = shift;
{
package InitArg;
+ use Moose;
use MooseX::StrictConstructor;
has 'thing' => ( is => 'rw', 'init_arg' => 'other' );
has 'size' => ( is => 'rw', 'init_arg' => undef );
}
-{
- package Immutable;
-
- use MooseX::StrictConstructor;
-
- has 'thing' => ( is => 'rw' );
-
- no Moose;
- __PACKAGE__->meta()->make_immutable();
-}
-
-{
- package ImmutableTricky;
-
- use MooseX::StrictConstructor;
-
- has 'thing' => ( is => 'rw' );
-
- sub BUILD
- {
- my $self = shift;
- my $params = shift;
-
- delete $params->{spy};
- }
-
- no Moose;
- __PACKAGE__->meta()->make_immutable();
-}
-
-
-eval { Standard->new( thing => 1, bad => 99 ) };
-is( $@, '', 'standard Moose class ignores unknown params' );
+my @classes = qw( Standard Stricter Subclass Tricky InitArg );
-eval { Stricter->new( thing => 1, bad => 99 ) };
-like( $@, qr/unknown attribute.+: bad/, 'strict constructor blows up on unknown params' );
+with_immutable {
+ lives_ok { Standard->new( thing => 1, bad => 99 ) }
+ 'standard Moose class ignores unknown params';
-eval { Tricky->new( thing => 1, spy => 99 ) };
-is( $@, '', 'can work around strict constructor by deleting params in BUILD()' );
+ throws_ok { Stricter->new( thing => 1, bad => 99 ) }
+ qr/unknown attribute.+: bad/,
+ 'strict constructor blows up on unknown params';
-eval { Tricky->new( thing => 1, agent => 99 ) };
-like( $@, qr/unknown attribute.+: agent/, 'Tricky still blows up on unknown params other than spy' );
+ lives_ok { Subclass->new( thing => 1, size => 'large' ) }
+ 'subclass constructor handles known attributes correctly';
-eval { Subclass->new( thing => 1, bad => 99 ) };
-like( $@, qr/unknown attribute.+: bad/, 'subclass constructor blows up on unknown params' );
+ throws_ok { Subclass->new( thing => 1, bad => 99 ) }
+ qr/unknown attribute.+: bad/,
+ 'subclass correctly recognizes bad attribute';
-eval { Subclass->new( thing => 1, size => 'large' ) };
-is( $@, '', 'subclass constructor handles known attributes correctly' );
+ lives_ok { Tricky->new( thing => 1, spy => 99 ) }
+ 'can work around strict constructor by deleting params in BUILD()';
-eval { Immutable->new( thing => 1, bad => 99 ) };
-like( $@, qr/unknown attribute.+: bad/,
- 'strict constructor in immutable class blows up on unknown params' );
+ throws_ok { Tricky->new( thing => 1, agent => 99 ) }
+ qr/unknown attribute.+: agent/,
+ 'Tricky still blows up on unknown params other than spy';
-eval { ImmutableTricky->new( thing => 1, spy => 99 ) };
-is( $@, '',
- 'immutable class can work around strict constructor by deleting params in BUILD()' );
+ throws_ok { Subclass->new( thing => 1, bad => 99 ) }
+ qr/unknown attribute.+: bad/,
+ 'subclass constructor blows up on unknown params';
-eval { ImmutableTricky->new( thing => 1, agent => 99 ) };
-like( $@, qr/unknown attribute.+: agent/,
- 'ImmutableTricky still blows up on unknown params other than spy' );
+ throws_ok { InitArg->new( thing => 1 ) }
+ qr/unknown attribute.+: thing/,
+ 'InitArg blows up with attribute name';
-eval { InitArg->new( thing => 1 ) };
-like( $@, qr/unknown attribute.+: thing/,
- 'InitArg blows up with attribute name' );
+ throws_ok { InitArg->new( size => 1 ) }
+ qr/unknown attribute.+: size/,
+ 'InitArg blows up when given attribute with undef init_arg';
-eval { InitArg->new( size => 1 ) };
-like( $@, qr/unknown attribute.+: size/,
- 'InitArg blows up when given attribute with undef init_arg' );
+ lives_ok { InitArg->new( other => 1 ) }
+ 'InitArg works when given proper init_arg';
+} @classes;
-eval { InitArg->new( other => 1 ) };
-is( $@, '',
- 'InitArg works when given proper init_arg' );
+done_testing();