Fix incorrect handling of exotic fieldnames

[p5sagit/Class-Accessor-Grouped.git] / t / accessors_wo.t

diff --git a/t/accessors_wo.t b/t/accessors_wo.t
index bc5307c..39c5d7a 100644 (file)
--- a/t/accessors_wo.t
+++ b/t/accessors_wo.t
@@ -1,80 +1,105 @@
-use Test::More tests => 38;
+use Test::More tests => 46;
+use Test::Exception;
 use strict;
 use warnings;
+use Config;
 use lib 't/lib';
+
+# we test the pure-perl versions only, but allow overrides
+# from the accessor_xs test-umbrella
+# Also make sure a rogue envvar will not interfere with
+# things
+my $use_xs;
+BEGIN {
+  $Class::Accessor::Grouped::USE_XS = 0
+    unless defined $Class::Accessor::Grouped::USE_XS;
+  $ENV{CAG_USE_XS} = 1;
+  $use_xs = $Class::Accessor::Grouped::USE_XS;
+};
+
 use AccessorGroupsWO;
 
-my $class = AccessorGroupsWO->new;
+my $obj = AccessorGroupsWO->new;
 
 {
-    my $warned = 0;
+  my $warned = 0;
 
-    local $SIG{__WARN__} = sub {
-        if  (shift =~ /DESTROY/i) {
-            $warned++;
-        };
+  local $SIG{__WARN__} = sub {
+    if  (shift =~ /DESTROY/i) {
+      $warned++;
     };
+  };
 
-    $class->mk_group_wo_accessors('warnings', 'DESTROY');
+  no warnings qw/once/;
+  local *AccessorGroupsWO::DESTROY = sub {};
 
-    ok($warned);
+  $obj->mk_group_wo_accessors('warnings', 'DESTROY');
+  ok($warned);
+};
 
-    # restore non-accessorized DESTROY
-    no warnings;
-    *AccessorGroupsWO::DESTROY = sub {};
+my $test_accessors = {
+  singlefield => {
+    is_xs => $use_xs,
+  },
+  multiple1 => {
+  },
+  multiple2 => {
+  },
+  lr1name => {
+    custom_field => 'lr1;field',
+  },
+  lr2name => {
+    custom_field => "lr2'field",
+  },
+  fieldname_torture => {
+    custom_field => join ('', map { chr($_) } (1..255) ), # FIXME after RT#80569 is fixed 0..255 should work
+    is_xs => $use_xs,
+  },
 };
 
-foreach (qw/singlefield multiple1 multiple2/) {
-    my $name = $_;
-    my $alias = "_${name}_accessor";
+for my $name (sort keys %$test_accessors) {
 
-    can_ok($class, $name, $alias);
+  my $alias = "_${name}_accessor";
+  my $field = $test_accessors->{$name}{custom_field} || $name;
 
-    # set via name
-    is($class->$name('a'), 'a');
-    is($class->{$name}, 'a');
+  can_ok($obj, $name, $alias);
 
-    # alias sets same as name
-    is($class->$alias('b'), 'b');
-    is($class->{$name}, 'b');
+  ok(!$obj->can($field))
+    if $field ne $name;
 
-    # die on get via name/alias
-    eval {
-        $class->$name;
-    };
-    ok($@ =~ /cannot access/);
+  # set via name
+  is($obj->$name('a'), 'a');
+  is($obj->{$field}, 'a');
 
-    eval {
-        $class->$alias;
-    };
-    ok($@ =~ /cannot access/);
-};
+  # alias sets same as name
+  is($obj->$alias('b'), 'b');
+  is($obj->{$field}, 'b');
 
-foreach (qw/lr1 lr2/) {
-    my $name = "$_".'name';
-    my $alias = "_${name}_accessor";
+  my $wo_regex = $test_accessors->{$name}{is_xs}
+    ? qr/Usage\:.+$name.*\(self, newvalue\)/
+    : qr/cannot access the value of '\Q$field\E'/
+  ;
 
-    my $field = { lr1 => 'lr1;field', lr2 => q{lr2'field} }->{$_};
+  # die on get via name/alias
+  {
+    local $TODO = "Class::XSAccessor emits broken error messages on 5.10 or -DDEBUGGING 5.8"
+      if (
+        $test_accessors->{$name}{is_xs}
+          and
+        $] < '5.011'
+          and
+        ( $] > '5.009' or $Config{config_args} =~ /DEBUGGING/ )
+      );
 
-    can_ok($class, $name, $alias);
-    ok(!$class->can($field));
+    throws_ok {
+      $obj->$name;
+    } $wo_regex;
 
-    # set via name
-    is($class->$name('c'), 'c');
-    is($class->{$field}, 'c');
-
-    # alias sets same as name
-    is($class->$alias('d'), 'd');
-    is($class->{$field}, 'd');
-
-    # die on get via name/alias
-    eval {
-        $class->$name;
-    };
-    ok($@ =~ /cannot access/);
-
-    eval {
-        $class->$alias;
-    };
-    ok($@ =~ /cannot access/);
+    throws_ok {
+      $obj->$alias;
+    } $wo_regex;
+  }
 };
+
+# important
+1;
\ No newline at end of file