Fix incorrect handling of exotic fieldnames

[p5sagit/Class-Accessor-Grouped.git] / t / accessors_ro.t

diff --git a/t/accessors_ro.t b/t/accessors_ro.t
index 662095d..7b385a2 100644 (file)
--- a/t/accessors_ro.t
+++ b/t/accessors_ro.t
@@ -1,87 +1,112 @@
-use Test::More no_plan;
+use Test::More tests => 58;
+use Test::Exception;
 use strict;
 use warnings;
+use Config;
 use lib 't/lib';
+
+# we test the pure-perl versions only, but allow overrides
+# from the accessor_xs test-umbrella
+# Also make sure a rogue envvar will not interfere with
+# things
+my $use_xs;
+BEGIN {
+  $Class::Accessor::Grouped::USE_XS = 0
+    unless defined $Class::Accessor::Grouped::USE_XS;
+  $ENV{CAG_USE_XS} = 1;
+  $use_xs = $Class::Accessor::Grouped::USE_XS;
+};
+
 use AccessorGroupsRO;
 
-my $class = AccessorGroupsRO->new;
+my $obj = AccessorGroupsRO->new;
 
 {
-    my $warned = 0;
+  my $warned = 0;
 
-    local $SIG{__WARN__} = sub {
-        if  (shift =~ /DESTROY/i) {
-            $warned++;
-        };
+  local $SIG{__WARN__} = sub {
+    if  (shift =~ /DESTROY/i) {
+      $warned++;
     };
+  };
 
-    $class->mk_group_ro_accessors('warnings', 'DESTROY');
+  no warnings qw/once/;
+  local *AccessorGroupsRO::DESTROY = sub {};
 
-    ok($warned);
+  $obj->mk_group_ro_accessors('warnings', 'DESTROY');
+
+  ok($warned);
 };
 
-foreach (qw/singlefield multiple1 multiple2/) {
-    my $name = $_;
-    my $alias = "_${name}_accessor";
+my $test_accessors = {
+  singlefield => {
+    is_xs => $use_xs,
+  },
+  multiple1 => {
+  },
+  multiple2 => {
+  },
+  lr1name => {
+    custom_field => 'lr1;field',
+  },
+  lr2name => {
+    custom_field => "lr2'field",
+  },
+  fieldname_torture => {
+    custom_field => join ('', map { chr($_) } (1..255) ), # FIXME after RT#80569 is fixed 0..255 should work
+    is_xs => $use_xs,
+  },
+};
 
-    can_ok($class, $name, $alias);
+for my $name (sort keys %$test_accessors) {
 
-    is($class->$name, undef);
-    is($class->$alias, undef);
+  my $alias = "_${name}_accessor";
+  my $field = $test_accessors->{$name}{custom_field} || $name;
 
-    # get via name
-    $class->{$name} = 'a';
-    is($class->$name, 'a');
+  can_ok($obj, $name, $alias);
 
-    # alias gets same as name
-    is($class->$alias, 'a');
+  ok(!$obj->can($field))
+    if $field ne $name;
 
-    # die on set via name/alias
-    eval {
-        $class->$name('b');
-    };
-    ok($@ =~ /cannot alter/);
+  is($obj->$name, undef);
+  is($obj->$alias, undef);
 
-    eval {
-        $class->$alias('b');
-    };
-    ok($@ =~ /cannot alter/);
+  # get via name
+  $obj->{$field} = 'a';
+  is($obj->$name, 'a');
 
-    # value should be unchanged
-    is($class->$name, 'a');
-    is($class->$alias, 'a');
-};
+  # alias gets same as name
+  is($obj->$alias, 'a');
 
-foreach (qw/lr1 lr2/) {
-    my $name = "$_".'name';
-    my $alias = "_${name}_accessor";
-    my $field = "$_".'field';
+  my $ro_regex = $test_accessors->{$name}{is_xs}
+    ? qr/Usage\:.+$name.*\(self\)/
+    : qr/cannot alter the value of '\Q$field\E'/
+  ;
 
-    can_ok($class, $name, $alias);
-    ok(!$class->can($field));
-
-    is($class->$name, undef);
-    is($class->$alias, undef);
-
-    # get via name
-    $class->{$field} = 'c';
-    is($class->$name, 'c');
-
-    # alias gets same as name
-    is($class->$alias, 'c');
+  {
+    local $TODO = "Class::XSAccessor emits broken error messages on 5.10 or -DDEBUGGING 5.8"
+      if (
+        $test_accessors->{$name}{is_xs}
+          and
+        $] < '5.011'
+          and
+        ( $] > '5.009' or $Config{config_args} =~ /DEBUGGING/ )
+      );
 
     # die on set via name/alias
-    eval {
-        $class->$name('d');
-    };
-    ok($@ =~ /cannot alter/);
-
-    eval {
-        $class->$alias('d');
-    };
-    ok($@ =~ /cannot alter/);
-
-    # value should be unchanged
-    is($class->$name, 'c');
-    is($class->$alias, 'c');
+    throws_ok {
+      $obj->$name('b');
+    } $ro_regex;
+
+    throws_ok {
+      $obj->$alias('b');
+    } $ro_regex;
+  }
+
+  # value should be unchanged
+  is($obj->$name, 'a');
+  is($obj->$alias, 'a');
 };
+
+#important
+1;