Minor cleanup and Changes

[p5sagit/Class-Accessor-Grouped.git] / t / accessors_ro.t

diff --git a/t/accessors_ro.t b/t/accessors_ro.t
index 662095d..79413ff 100644 (file)
--- a/t/accessors_ro.t
+++ b/t/accessors_ro.t
@@ -1,10 +1,24 @@
-use Test::More no_plan;
+use Test::More tests => 48;
+use Test::Exception;
 use strict;
 use warnings;
 use lib 't/lib';
+
+# we test the pure-perl versions only, but allow overrides
+# from the accessor_xs test-umbrella
+# Also make sure a rogue envvar will not interfere with
+# things
+my $use_xs;
+BEGIN {
+    $Class::Accessor::Grouped::USE_XS = 0
+        unless defined $Class::Accessor::Grouped::USE_XS;
+    $ENV{CAG_USE_XS} = 1;
+    $use_xs = $Class::Accessor::Grouped::USE_XS;
+};
+
 use AccessorGroupsRO;
 
-my $class = AccessorGroupsRO->new;
+my $obj = AccessorGroupsRO->new;
 
 {
     my $warned = 0;
@@ -15,73 +29,68 @@ my $class = AccessorGroupsRO->new;
         };
     };
 
-    $class->mk_group_ro_accessors('warnings', 'DESTROY');
+    no warnings qw/once/;
+    local *AccessorGroupsRO::DESTROY = sub {};
+
+    $obj->mk_group_ro_accessors('warnings', 'DESTROY');
 
     ok($warned);
 };
 
-foreach (qw/singlefield multiple1 multiple2/) {
-    my $name = $_;
-    my $alias = "_${name}_accessor";
-
-    can_ok($class, $name, $alias);
-
-    is($class->$name, undef);
-    is($class->$alias, undef);
-
-    # get via name
-    $class->{$name} = 'a';
-    is($class->$name, 'a');
-
-    # alias gets same as name
-    is($class->$alias, 'a');
-
-    # die on set via name/alias
-    eval {
-        $class->$name('b');
-    };
-    ok($@ =~ /cannot alter/);
-
-    eval {
-        $class->$alias('b');
-    };
-    ok($@ =~ /cannot alter/);
-
-    # value should be unchanged
-    is($class->$name, 'a');
-    is($class->$alias, 'a');
+my $test_accessors = {
+    singlefield => {
+        is_xs => $use_xs,
+    },
+    multiple1 => {
+    },
+    multiple2 => {
+    },
+    lr1name => {
+        custom_field => 'lr1;field',
+    },
+    lr2name => {
+        custom_field => "lr2'field",
+    },
 };
 
-foreach (qw/lr1 lr2/) {
-    my $name = "$_".'name';
+for my $name (sort keys %$test_accessors) {
+
     my $alias = "_${name}_accessor";
-    my $field = "$_".'field';
+    my $field = $test_accessors->{$name}{custom_field} || $name;
+
+    can_ok($obj, $name, $alias);
 
-    can_ok($class, $name, $alias);
-    ok(!$class->can($field));
+    ok(!$obj->can($field))
+      if $field ne $name;
 
-    is($class->$name, undef);
-    is($class->$alias, undef);
+    is($obj->$name, undef);
+    is($obj->$alias, undef);
 
     # get via name
-    $class->{$field} = 'c';
-    is($class->$name, 'c');
+    $obj->{$field} = 'a';
+    is($obj->$name, 'a');
 
     # alias gets same as name
-    is($class->$alias, 'c');
+    is($obj->$alias, 'a');
+
+    my $ro_regex = $test_accessors->{$name}{is_xs}
+        ? qr/Usage\:.+$name.*\(self\)/
+        : qr/cannot alter the value of '\Q$field\E'/
+    ;
 
     # die on set via name/alias
-    eval {
-        $class->$name('d');
-    };
-    ok($@ =~ /cannot alter/);
+    throws_ok {
+        $obj->$name('b');
+    } $ro_regex;
 
-    eval {
-        $class->$alias('d');
-    };
-    ok($@ =~ /cannot alter/);
+    throws_ok {
+        $obj->$alias('b');
+    } $ro_regex;
 
     # value should be unchanged
-    is($class->$name, 'c');
-    is($class->$alias, 'c');
+    is($obj->$name, 'a');
+    is($obj->$alias, 'a');
 };
+
+#important
+1;