my($dir) = @_;
opendir DIR, $dir or die "Trouble opening $dir: $!";
foreach my $f (sort { $a cmp $b } readdir DIR) {
- next if $f eq $curdir or $f eq $updir or
+ next if $f eq $curdir or $f eq $updir or
$f =~ /^(?:CVS|RCS|SCCS|\.svn)$/;
- my $fullpath = File::Spec->catfile($dir, $f);
+ my $fullpath = File::Spec->catfile($dir, $f);
- _find_tests($fullpath) if -d $fullpath;
- $fullpath = VMS::Filespec::unixify($fullpath) if $^O eq 'VMS';
- push @ARGV, $fullpath if $f =~ /\.t$/;
+ _find_tests($fullpath) if -d $fullpath;
+ $fullpath = VMS::Filespec::unixify($fullpath) if $^O eq 'VMS';
+ push @ARGV, $fullpath if $f =~ /\.t$/;
}
}
unless (@ARGV) {
foreach my $dir (qw(base comp cmd run io op uni)) {
- _find_tests($dir);
+ _find_tests($dir);
}
_find_tests("lib") unless $::core;
# Config.pm may be broken for make minitest. And this is only a refinement
}
my $mani = File::Spec->catfile($updir, "MANIFEST");
if (open(MANI, $mani)) {
- while (<MANI>) { # similar code in t/harness
+ while (<MANI>) { # similar code in t/harness
if (m!^(ext/(\S+)/+(?:[^/\s]+\.t|test\.pl)|lib/\S+?(?:\.t|test\.pl))\s!) {
my $t = $1;
my $extension = $2;
}
close MANI;
} else {
- warn "$0: cannot open $mani: $!\n";
+ warn "$0: cannot open $mani: $!\n";
}
unless ($::core) {
_find_tests('pod');
if ($::deparse) {
_testprogs('deparse', '', @ARGV);
}
-elsif( $::compile ) {
+elsif( $::compile ) {
_testprogs('compile', '', @ARGV);
}
elsif( $::bytecompile ) {
EOT
$ENV{PERLCC_TIMEOUT} = 120
- if ($type eq 'compile' && !$ENV{PERLCC_TIMEOUT});
+ if ($type eq 'compile' && !$ENV{PERLCC_TIMEOUT});
$::bad_files = 0;
foreach my $t (@tests) {
unless (exists $::path_to_name{$t}) {
- my $tname = File::Spec->catfile('t',$t);
- $tname = VMS::Filespec::unixify($tname) if $^O eq 'VMS';
- $::path_to_name{$t} = $tname;
+ my $tname = File::Spec->catfile('t',$t);
+ $tname = VMS::Filespec::unixify($tname) if $^O eq 'VMS';
+ $::path_to_name{$t} = $tname;
}
}
my $maxlen = 0;
my $good_files = 0;
my $tested_files = 0;
my $totmax = 0;
- my $ok;
my $test;
while ($test = shift @tests) {
if ( $::infinite{$test} && $type eq 'compile' ) {
print STDERR "$test creates infinite loop! Skipping.\n";
- next;
+ next;
}
if ($test =~ /^$/) {
next;
# XXX DAPM %OVER not defined anywhere
# $test = $OVER{$test} if exists $OVER{$test};
- open(SCRIPT,"<$test") or die "Can't run $test.\n";
- $_ = <SCRIPT>;
- close(SCRIPT) unless ($type eq 'deparse');
+ open(SCRIPT,"<$test") or die "Can't run $test.\n";
+ $_ = <SCRIPT>;
+ close(SCRIPT) unless ($type eq 'deparse');
if ($::with_utf16) {
$_ =~ tr/\0//d;
}
my $switch;
- if (/#!.*\bperl.*\s-\w*([tT])/) {
- $switch = qq{"-$1"};
- }
- else {
+ if (/#!.*\bperl.*\s-\w*([tT])/) {
+ $switch = qq{"-$1"};
+ }
+ else {
if ($::taintwarn) {
# not all tests are expected to pass with this option
$switch = '"-t"';
else {
$switch = '';
}
- }
+ }
- my $test_executable; # for 'compile' tests
+ my $test_executable; # for 'compile' tests
my $file_opts = "";
if ($type eq 'deparse') {
# Look for #line directives which change the filename
}
elsif ($type eq 'bytecompile') {
my ($pwd, $null);
- if( $^O eq 'MSWin32') {
+ if( $^O eq 'MSWin32') {
$pwd = `cd`;
$null = 'nul';
} else {
$bswitch .= "-b,"
if $test =~ m(op/getpid);
my $bytecompile_cmd =
- "$perl $testswitch $switch -I../lib $bswitch".
+ "$perl $testswitch $switch -I../lib $bswitch".
"-o$test.plc $test 2>$null &&".
"$perl $testswitch $switch -I../lib $utf8 $test.plc |";
open(RESULTS,$bytecompile_cmd)
my $redir = $^O eq 'VMS' ? '2>&1' : '';
if ($ENV{PERL_VALGRIND}) {
$perl = "valgrind --suppressions=perl.supp --leak-check=yes "
- . "--leak-resolution=high --show-reachable=yes "
- . "--num-callers=50 --logfile-fd=3 $perl";
+ . "--leak-resolution=high --show-reachable=yes "
+ . "--num-callers=50 --logfile-fd=3 $perl";
$redir = "3>$valgrind_log";
}
my $run = "$perl" . _quote_args("$testswitch $switch $utf8")
}
else {
my $compile_cmd;
- my $pl2c = "$testswitch -I../lib ../utils/perlcc --testsuite " .
- # -O9 for good measure, -fcog is broken ATM
- "$switch -Wb=-O9,-fno-cog -L .. " .
- "-I \".. ../lib/CORE\" $args $utf8 $test -o ";
-
- if( $^O eq 'MSWin32' ) {
- $test_executable = "$test.exe";
- # hopefully unused name...
- open HACK, "> xweghyz.pl";
- print HACK <<EOT;
+ my $pl2c = "$testswitch -I../lib ../utils/perlcc --testsuite " .
+ # -O9 for good measure, -fcog is broken ATM
+ "$switch -Wb=-O9,-fno-cog -L .. " .
+ "-I \".. ../lib/CORE\" $args $utf8 $test -o ";
+
+ if( $^O eq 'MSWin32' ) {
+ $test_executable = "$test.exe";
+ # hopefully unused name...
+ open HACK, "> xweghyz.pl";
+ print HACK <<EOT;
#!./perl
open HACK, '.\\perl $pl2c $test_executable |';
open HACK, '$test_executable |';
while(<HACK>) {print}
EOT
- close HACK;
- $compile_cmd = 'xweghyz.pl |';
- }
- else {
- $test_executable = "$test.plc";
- $compile_cmd
+ close HACK;
+ $compile_cmd = 'xweghyz.pl |';
+ }
+ else {
+ $test_executable = "$test.plc";
+ $compile_cmd
= "./perl $pl2c $test_executable && $test_executable |";
- }
- unlink $test_executable if -f $test_executable;
+ }
+ unlink $test_executable if -f $test_executable;
open(RESULTS, $compile_cmd)
or print "can't compile '$compile_cmd': $!.\n";
}
- $ok = 0;
- my $next = 0;
- my $seen_leader = 0;
- my $seen_ok = 0;
+ my $failure;
+ my $next = 0;
+ my $seen_leader = 0;
+ my $seen_ok = 0;
+ my $trailing_leader = 0;
my $max;
+ my %todo;
while (<RESULTS>) {
next if /^\s*$/; # skip blank lines
if ($::verbose) {
print $_;
}
unless (/^\#/) {
- my %todo;
+ if ($trailing_leader) {
+ # shouldn't be anything following a postfix 1..n
+ $failure = 'FAILED--extra output after trailing 1..n';
+ last;
+ }
if (/^1\.\.([0-9]+)( todo ([\d ]+))?/) {
+ if ($seen_leader) {
+ $failure = 'FAILED--seen duplicate leader';
+ last;
+ }
$max = $1;
- %todo = map { $_ => 1 } split / /, $3 if $3;
+ %todo = map { $_ => 1 } split / /, $3 if $3;
$totmax += $max;
$tested_files++;
- unless ($seen_ok) {
- $next = 1;
- $ok = 1;
- }
- $seen_leader = 1;
+ if ($seen_ok) {
+ # 1..n appears at end of file
+ $trailing_leader = 1;
+ if ($next != $max) {
+ $failure = "FAILED--expected $max tests, saw $next";
+ last;
+ }
+ }
+ else {
+ $next = 0;
+ }
+ $seen_leader = 1;
}
else {
- if (/^(not )?ok (\d+)[^\#]*(\s*\#.*)?/) {
+ if (/^(not )?ok(?: (\d+))?[^\#]*(\s*\#.*)?/) {
unless ($seen_leader) {
unless ($seen_ok) {
- $next = 1;
- $ok = 1;
+ $next = 0;
}
}
$seen_ok = 1;
- if ($2 == $next) {
- my($not, $num, $extra, $istodo) = ($1, $2, $3, 0);
+ $next++;
+ my($not, $num, $extra, $istodo) = ($1, $2, $3, 0);
+ $num = $next unless $num;
+
+ if ($num == $next) {
+
# SKIP is essentially the same as TODO for t/TEST
# this still conforms to TAP:
# http://search.cpan.org/dist/Test-Harness/lib/Test/Harness/TAP.pod
$istodo = 1 if $todo{$num};
if( $not && !$istodo ) {
- $ok = 0;
- $next = $num;
+ $failure = "FAILED at test $num";
last;
}
- else {
- $next = $next + 1;
- }
}
- }
- elsif (/^Bail out!\s*(.*)/i) { # magic words
- die "FAILED--Further testing stopped" . ($1 ? ": $1\n" : ".\n");
+ else {
+ $failure ="FAILED--expected test $next, saw test $num";
+ last;
+ }
+ }
+ elsif (/^Bail out!\s*(.*)/i) { # magic words
+ die "FAILED--Further testing stopped" . ($1 ? ": $1\n" : ".\n");
}
else {
- $ok = 0;
+ $failure = "FAILED--unexpected output at test $next";
+ last;
}
}
}
}
close RESULTS;
+
+ if (not defined $failure) {
+ $failure = 'FAILED--no leader found' unless $seen_leader;
+ }
+
if ($ENV{PERL_VALGRIND}) {
my @valgrind;
if (-e $valgrind_log) {
rename("perl.3log", $tpp) ||
die "rename: perl3.log to $tpp: $!\n";
}
- $next = $next - 1;
- # test if the compiler compiled something
- if( $type eq 'compile' && !-e "$test_executable" ) {
- $ok = 0;
- print "Test did not compile\n";
- }
- if ($ok && $next == $max ) {
+ # test if the compiler compiled something
+ if( $type eq 'compile' && !-e "$test_executable" ) {
+ $failure = "Test did not compile";
+ }
+ if (not defined $failure and $next != $max) {
+ $failure="FAILED--expected $max tests, saw $next";
+ }
+
+ if (defined $failure) {
+ print "${te}$failure\n";
+ $::bad_files++;
+ $_ = $test;
+ if (/^base/) {
+ die "Failed a basic test--cannot continue.\n";
+ }
+ }
+ else {
if ($max) {
print "${te}ok\n";
$good_files++;
$tested_files -= 1;
}
}
- else {
- $next += 1;
- if ($next > $max) {
- print "${te}FAILED at test $next\tpossibly due to extra output\n";
- }
- else {
- print "${te}FAILED at test $next\n";
- }
- $::bad_files++;
- $_ = $test;
- if (/^base/) {
- die "Failed a basic test--cannot continue.\n";
- }
- }
}
if ($::bad_files == 0) {
- if ($ok) {
+ if ($good_files) {
print "All tests successful.\n";
# XXX add mention of 'perlbug -ok' ?
}
### ./perl harness
### in the 't' directory since most (>=80%) of the tests succeeded.
SHRDLU_2
- if (eval {require Config; import Config; 1}) {
+ if (eval {require Config; import Config; 1}) {
if ($::Config{usedl} && (my $p = $::Config{ldlibpthname})) {
warn <<SHRDLU_3;
### You may have to set your dynamic library search path,
### $p, to point to the build directory:
SHRDLU_3
- if (exists $ENV{$p} && $ENV{$p} ne '') {
+ if (exists $ENV{$p} && $ENV{$p} ne '') {
warn <<SHRDLU_4a;
### setenv $p `pwd`:\$$p; cd t; ./perl harness
### $p=`pwd`:\$$p; export $p; cd t; ./perl harness
### export $p=`pwd`:\$$p; cd t; ./perl harness
SHRDLU_4a
- } else {
+ } else {
warn <<SHRDLU_4b;
### setenv $p `pwd`; cd t; ./perl harness
### $p=`pwd`; export $p; cd t; ./perl harness
### export $p=`pwd`; cd t; ./perl harness
SHRDLU_4b
- }
+ }
warn <<SHRDLU_5;
### for csh-style shells, like tcsh; or for traditional/modern
### Bourne-style shells, like bash, ksh, and zsh, respectively.
SHRDLU_5
- }
+ }
}
}
my ($user,$sys,$cuser,$csys) = times;
- print sprintf("u=%g s=%g cu=%g cs=%g scripts=%d tests=%d\n",
+ print sprintf("u=%.2f s=%.2f cu=%.2f cs=%.2f scripts=%d tests=%d\n",
$user,$sys,$cuser,$csys,$tested_files,$totmax);
if ($ENV{PERL_VALGRIND}) {
my $s = $valgrind == 1 ? '' : 's';