Cleanup warnings in t/55namespaces_cleaned, sophisticate require overload

[dbsrgits/DBIx-Class-Historic.git] / t / 55namespaces_cleaned.t

diff --git a/t/55namespaces_cleaned.t b/t/55namespaces_cleaned.t
index 85c288b..8a9e337 100644 (file)
--- a/t/55namespaces_cleaned.t
+++ b/t/55namespaces_cleaned.t
@@ -1,3 +1,60 @@
+# Pre-5.10 perls pollute %INC on unsuccesfull module
+# require, making it appear as if the module is already
+# loaded on subsequent require()s
+# Can't seem to find the exact RT/perldelta entry
+#
+# we want to do this here, in the very beginning, before even
+# warnings/strict are loaded
+BEGIN {
+  if ($] < 5.010) {
+
+    # All of this almost verbatim copied from Lexical::SealRequireHints
+    # Zefram++
+
+    # a potential caller() in $next_require must see the correct
+    # immediate frame caller
+    my $caller = caller(0);
+
+    our $next_require = defined(&CORE::GLOBAL::require)
+      ? \&CORE::GLOBAL::require
+      : sub {
+        my ($arg) = @_;
+
+        # The shenanigans with $CORE::GLOBAL::{require}
+        # are required because if there's a
+        # &CORE::GLOBAL::require when the eval is
+        # executed then the CORE::require in there is
+        # interpreted as plain require on some Perl
+        # versions, leading to recursion.
+        my $grequire = delete $CORE::GLOBAL::{require};
+
+        my $result = eval sprintf '
+          local $SIG{__DIE__};
+          $CORE::GLOBAL::{require} = $grequire;
+          package %s;
+          CORE::require($arg);
+        ', $caller;
+
+        die $@ if $@ ne '';
+        return $result;
+      }
+    ;
+
+    *CORE::GLOBAL::require = sub {
+      die "wrong number of arguments to require\n"
+        unless @_ == 1;
+
+      my $res = eval "package $caller; \$next_require->(\@_)";
+      if ($@ ne '') {
+        delete $INC{$_[0]};
+        die $@;
+      }
+
+      $res;
+    };
+  }
+}
+
 use strict;
 use warnings;
 
@@ -6,23 +63,25 @@ use Test::More;
 use File::Find;
 use File::Spec;
 use B qw/svref_2object/;
+use Package::Stash;
 
 # makes sure we can load at least something
 use DBIx::Class;
+use DBIx::Class::Carp;
 
 my @modules = grep {
   my $mod = $_;
 
-  # trap deprecation warnings and whatnot
-  local $SIG{__WARN__} = sub {};
-
   # not all modules are loadable at all times
-  eval "require $mod" ? $mod : do {
-    SKIP: { skip "Failed require of $mod: $@", 1 };
-    ();
+  do {
+    # trap deprecation warnings and whatnot
+    local $SIG{__WARN__} = sub {};
+    eval "require $mod";
+  } ? $mod : do {
+    SKIP: { skip "Failed require of $mod: " . ($@ =~ /^(.+?)$/m)[0], 1 };
+    (); # empty RV for @modules
   };
 
-
 } find_modules();
 
 # have an exception table for old and/or weird code we are not sure
@@ -38,6 +97,10 @@ my $skip_idx = { map { $_ => 1 } (
   # G::L::D is unclean, but we never inherit from it
   'DBIx::Class::Admin::Descriptive',
   'DBIx::Class::Admin::Usage',
+
+  # this subclass is expected to inherit whatever crap comes
+  # from the parent
+  'DBIx::Class::ResultSet::Pager',
 ) };
 
 my $has_cmop = eval { require Class::MOP };
@@ -52,15 +115,10 @@ for my $mod (@modules) {
   SKIP: {
     skip "$mod exempt from namespace checks",1 if $skip_idx->{$mod};
 
-    my %all_method_like = do {
-      no strict 'refs';
-      map {
-        my $m = $_;
-        map
-          { *{"${m}::$_"}{CODE} ? ( $_ => *{"${m}::$_"}{CODE} ) : () }
-          keys %{"${m}::"}
-      } (reverse @{mro::get_linear_isa($mod)});
-    };
+    my %all_method_like = (map
+      { %{Package::Stash->new($_)->get_all_symbols('CODE')} }
+      (reverse @{mro::get_linear_isa($mod)})
+    );
 
     my %parents = map { $_ => 1 } @{mro::get_linear_isa($mod)};
 
@@ -73,19 +131,24 @@ for my $mod (@modules) {
 
     for my $name (keys %all_method_like) {
 
-      # overload is a funky thing - it is neither cleaned, and its imports are named funny
+      next if ( DBIx::Class::_ENV_::BROKEN_NAMESPACE_CLEAN() and $name =~ /^carp(?:_unique|_once)?$/ );
+
+      # overload is a funky thing - it is not cleaned, and its imports are named funny
       next if $name =~ /^\(/;
 
       my $gv = svref_2object($all_method_like{$name})->GV;
       my $origin = $gv->STASH->NAME;
 
-      next if $seen->{"${origin}:${name}"}++;
-
       TODO: {
         local $TODO = 'CAG does not clean its BEGIN constants' if $name =~ /^__CAG_/;
-        is ($gv->NAME, $name, "Properly named $name method at $origin");
+        is ($gv->NAME, $name, "Properly named $name method at $origin" . ($origin eq $mod
+          ? ''
+          : " (inherited by $mod)"
+        ));
       }
 
+      next if $seen->{"${origin}:${name}"}++;
+
       if ($origin eq $mod) {
         pass ("$name is a native $mod method");
       }
@@ -108,6 +171,27 @@ for my $mod (@modules) {
         );
       }
     }
+
+    next if DBIx::Class::_ENV_::BROKEN_NAMESPACE_CLEAN();
+
+    # some common import names (these should never ever be methods)
+    for my $f (qw/carp carp_once carp_unique croak confess cluck try catch finally/) {
+      if ($mod->can($f)) {
+        my $via;
+        for (reverse @{mro::get_linear_isa($mod)} ) {
+          if ( ($_->can($f)||'') eq $all_method_like{$f} ) {
+            $via = $_;
+            last;
+          }
+        }
+        fail ("Import $f leaked into method list of ${mod}, appears to have entered inheritance chain at "
+            . ($via || 'UNKNOWN')
+        );
+      }
+      else {
+        pass ("Import $f not leaked into method list of $mod");
+      }
+    }
   }
 }