use File::Find;
use File::Spec;
use B qw/svref_2object/;
+use Package::Stash;
# makes sure we can load at least something
use DBIx::Class;
+use DBIx::Class::Carp;
my @modules = grep {
my $mod = $_;
SKIP: {
skip "$mod exempt from namespace checks",1 if $skip_idx->{$mod};
- my %all_method_like = do {
- no strict 'refs';
- map {
- my $m = $_;
- map
- { *{"${m}::$_"}{CODE} ? ( $_ => *{"${m}::$_"}{CODE} ) : () }
- keys %{"${m}::"}
- } (reverse @{mro::get_linear_isa($mod)});
- };
+ my %all_method_like = (map
+ { %{Package::Stash->new($_)->get_all_symbols('CODE')} }
+ (reverse @{mro::get_linear_isa($mod)})
+ );
my %parents = map { $_ => 1 } @{mro::get_linear_isa($mod)};
for my $name (keys %all_method_like) {
+ next if ( DBIx::Class::_ENV_::BROKEN_NAMESPACE_CLEAN() and $name =~ /^carp(?:_unique|_once)?$/ );
+
# overload is a funky thing - it is neither cleaned, and its imports are named funny
next if $name =~ /^\(/;
my $gv = svref_2object($all_method_like{$name})->GV;
my $origin = $gv->STASH->NAME;
- next if $seen->{"${origin}:${name}"}++;
-
TODO: {
local $TODO = 'CAG does not clean its BEGIN constants' if $name =~ /^__CAG_/;
- is ($gv->NAME, $name, "Properly named $name method at $origin");
+ is ($gv->NAME, $name, "Properly named $name method at $origin" . ($origin eq $mod
+ ? ''
+ : " (inherited by $mod)"
+ ));
}
+ next if $seen->{"${origin}:${name}"}++;
+
if ($origin eq $mod) {
pass ("$name is a native $mod method");
}
);
}
}
+
+ next if DBIx::Class::_ENV_::BROKEN_NAMESPACE_CLEAN();
+
+ # some common import names (these should never ever be methods)
+ for my $f (qw/carp carp_once carp_unique croak confess cluck try catch finally/) {
+ if ($mod->can($f)) {
+ my $via;
+ for (reverse @{mro::get_linear_isa($mod)} ) {
+ if ( ($_->can($f)||'') eq $all_method_like{$f} ) {
+ $via = $_;
+ last;
+ }
+ }
+ fail ("Import $f leaked into method list of ${mod}, appears to have entered inheritance chain at "
+ . ($via || 'UNKNOWN')
+ );
+ }
+ else {
+ pass ("Import $f not leaked into method list of $mod");
+ }
+ }
}
}