+BEGIN {
+ if ($] < 5.010) {
+
+ # Pre-5.10 perls pollute %INC on unsuccesfull module
+ # require, making it appear as if the module is already
+ # loaded on subsequent require()s
+ # Can't seem to find the exact RT/perldelta entry
+ #
+ # The reason we can't just use a sane, clean loader, is because
+ # if a Module require()s another module the %INC will still
+ # get filled with crap and we are back to square one. A global
+ # fix is really the only way for this test, as we try to load
+ # each available module separately, and have no control (nor
+ # knowledge) over their common dependencies.
+ #
+ # we want to do this here, in the very beginning, before even
+ # warnings/strict are loaded
+
+ unshift @INC, 't/lib';
+ require DBICTest::Util::OverrideRequire;
+
+ DBICTest::Util::OverrideRequire::override_global_require( sub {
+ my $res = eval { $_[0]->() };
+ if ($@ ne '') {
+ delete $INC{$_[1]};
+ die $@;
+ }
+ return $res;
+ } );
+ }
+}
+
use strict;
use warnings;
use Test::More;
+use lib 't/lib';
+use DBICTest;
+
use File::Find;
use File::Spec;
use B qw/svref_2object/;
+use Package::Stash;
# makes sure we can load at least something
use DBIx::Class;
+use DBIx::Class::Carp;
my @modules = grep {
- my $mod = $_;
-
- # trap deprecation warnings and whatnot
- local $SIG{__WARN__} = sub {};
+ my ($mod) = $_ =~ /(.+)/;
# not all modules are loadable at all times
- eval "require $mod" ? $mod : do {
- SKIP: { skip "Failed require of $mod: $@", 1 };
- ();
+ do {
+ # trap deprecation warnings and whatnot
+ local $SIG{__WARN__} = sub {};
+ eval "require $mod";
+ } ? $mod : do {
+ SKIP: { skip "Failed require of $mod: " . ($@ =~ /^(.+?)$/m)[0], 1 };
+ (); # empty RV for @modules
};
-
} find_modules();
# have an exception table for old and/or weird code we are not sure
# G::L::D is unclean, but we never inherit from it
'DBIx::Class::Admin::Descriptive',
'DBIx::Class::Admin::Usage',
+
+ # this subclass is expected to inherit whatever crap comes
+ # from the parent
+ 'DBIx::Class::ResultSet::Pager',
) };
my $has_cmop = eval { require Class::MOP };
SKIP: {
skip "$mod exempt from namespace checks",1 if $skip_idx->{$mod};
- my %all_method_like = do {
- no strict 'refs';
- map {
- my $m = $_;
- map
- { *{"${m}::$_"}{CODE} ? ( $_ => *{"${m}::$_"}{CODE} ) : () }
- keys %{"${m}::"}
- } (reverse @{mro::get_linear_isa($mod)});
- };
+ my %all_method_like = (map
+ { %{Package::Stash->new($_)->get_all_symbols('CODE')} }
+ (reverse @{mro::get_linear_isa($mod)})
+ );
my %parents = map { $_ => 1 } @{mro::get_linear_isa($mod)};
for my $name (keys %all_method_like) {
- # overload is a funky thing - it is neither cleaned, and its imports are named funny
+ next if ( DBIx::Class::_ENV_::BROKEN_NAMESPACE_CLEAN() and $name =~ /^carp(?:_unique|_once)?$/ );
+
+ # overload is a funky thing - it is not cleaned, and its imports are named funny
next if $name =~ /^\(/;
my $gv = svref_2object($all_method_like{$name})->GV;
my $origin = $gv->STASH->NAME;
TODO: {
- local $TODO = 'CAG does not clean its BEGIN constants' if $name =~ /^__CAG_/;
+ local $TODO;
+ if ($name =~ /^__CAG_/) {
+ $TODO = 'CAG does not clean its BEGIN constants';
+ }
+
is ($gv->NAME, $name, "Properly named $name method at $origin" . ($origin eq $mod
? ''
: " (inherited by $mod)"
}
}
+ next if DBIx::Class::_ENV_::BROKEN_NAMESPACE_CLEAN();
+
# some common import names (these should never ever be methods)
for my $f (qw/carp carp_once carp_unique croak confess cluck try catch finally/) {
if ($mod->can($f)) {
return sort @modules;
}
-
done_testing;