Awesome non-quoted numeric default patch by Stephen Clouse

[dbsrgits/SQL-Translator.git] / t / 30sqlt-new-diff-sqlite.t

diff --git a/t/30sqlt-new-diff-sqlite.t b/t/30sqlt-new-diff-sqlite.t
index 7f5ebb5..5d6ad92 100644 (file)
--- a/t/30sqlt-new-diff-sqlite.t
+++ b/t/30sqlt-new-diff-sqlite.t
@@ -60,17 +60,17 @@ DROP INDEX u_name;
 
 ALTER TABLE new_name ADD COLUMN new_field int;
 
-ALTER TABLE person ADD COLUMN is_rock_star tinyint(4) DEFAULT '1';
+ALTER TABLE person ADD COLUMN is_rock_star tinyint(4) DEFAULT 1;
 
 -- SQL::Translator::Producer::SQLite cant alter_field;
 
 -- SQL::Translator::Producer::SQLite cant rename_field;
 
-CREATE UNIQUE INDEX unique_name_person ON person (name);
+CREATE UNIQUE INDEX unique_name ON person (name);
 
-CREATE UNIQUE INDEX UC_person_id_person ON person (person_id);
+CREATE UNIQUE INDEX UC_person_id ON person (person_id);
 
-CREATE UNIQUE INDEX UC_age_name_person ON person (age, name);
+CREATE UNIQUE INDEX UC_age_name ON person (age, name);
 
 DROP TABLE deleted;
 
@@ -122,10 +122,10 @@ ALTER TABLE new_name ADD COLUMN new_field int;
 CREATE TEMPORARY TABLE person_temp_alter (
   person_id INTEGER PRIMARY KEY NOT NULL,
   name varchar(20) NOT NULL,
-  age int(11) DEFAULT '18',
+  age int(11) DEFAULT 18,
   weight double(11,2),
-  iq int(11) DEFAULT '0',
-  is_rock_star tinyint(4) DEFAULT '1',
+  iq int(11) DEFAULT 0,
+  is_rock_star tinyint(4) DEFAULT 1,
   physical_description text
 );
 
@@ -136,18 +136,18 @@ DROP TABLE person;
 CREATE TABLE person (
   person_id INTEGER PRIMARY KEY NOT NULL,
   name varchar(20) NOT NULL,
-  age int(11) DEFAULT '18',
+  age int(11) DEFAULT 18,
   weight double(11,2),
-  iq int(11) DEFAULT '0',
-  is_rock_star tinyint(4) DEFAULT '1',
+  iq int(11) DEFAULT 0,
+  is_rock_star tinyint(4) DEFAULT 1,
   physical_description text
 );
 
-CREATE UNIQUE INDEX unique_name_person02 ON person (name);
+CREATE UNIQUE INDEX unique_name02 ON person (name);
 
-CREATE UNIQUE INDEX UC_person_id_person02 ON person (person_id);
+CREATE UNIQUE INDEX UC_person_id02 ON person (person_id);
 
-CREATE UNIQUE INDEX UC_age_name_person02 ON person (age, name);
+CREATE UNIQUE INDEX UC_age_name02 ON person (age, name);
 
 INSERT INTO person SELECT person_id, name, age, weight, iq, is_rock_star, physical_description FROM person_temp_alter;
 
@@ -160,6 +160,10 @@ COMMIT;
 
 ## END OF DIFF
 
+# Note the 02 in the 3 names above (end of diff) are an implementation
+# quirk - there is nothing to reset the global seen-names register
+# The rewrite should abolish this altogether, and carry the register in
+# the main schema object
 
 # Test for sameness
 $out = SQL::Translator::Diff::schema_diff($source_schema, 'MySQL', $source_schema, 'MySQL' );