Migrate -ident and -value from dbic, reorganize docs

[dbsrgits/SQL-Abstract.git] / t / 10test.t

diff --git a/t/10test.t b/t/10test.t
index aa140d4..9c69343 100644 (file)
--- a/t/10test.t
+++ b/t/10test.t
@@ -615,6 +615,20 @@ my @sql_tests = (
           'SELECT * FROM foo WHERE a IN (3,2,1)',
         ]
       },
+
+      # list consistency
+      {
+        equal => 0,
+        statements => [
+          'SELECT a,b FROM foo',
+          'SELECT a,,b FROM foo',
+          'SELECT a,b, FROM foo',
+          'SELECT ,a,b, FROM foo',
+          'SELECT ,a,,b, FROM foo',
+        ],
+      },
+
+      # misc func
       {
         equal => 0,
         statements => [
@@ -625,7 +639,6 @@ my @sql_tests = (
           'SELECT count(1) FROM foo',
         ]
       },
-      # misc func
       {
         equal => 1,
         statements => [
@@ -643,33 +656,31 @@ my @sql_tests = (
           'SELECT foo FROM bar ()',
         ]
       },
-      # single ? of unknown funcs can unroll
-      # (think ...LIKE ?...)
       {
-        equal => 1,
+        equal => 0,
         statements => [
-          'SELECT foo FROM bar WHERE bar > foo ?',
-          'SELECT foo FROM bar WHERE bar > foo (?)',
-          'SELECT foo FROM bar WHERE bar > foo( ? )',
+          'SELECT COUNT * FROM foo',
+          'SELECT COUNT( * ) FROM foo',
         ]
       },
+      # single ? of unknown funcs do not unroll unless
+      # explicitly allowed (e.g. Like)
       {
-        equal => 1,
+        equal => 0,
         statements => [
-          'SELECT foo FROM bar WHERE bar > (foo ?)',
-          'SELECT foo FROM bar WHERE bar > (foo( ? ))',
-          'SELECT foo FROM bar WHERE bar > (( foo (?) ))',
+          'SELECT foo FROM bar WHERE bar > foo ?',
+          'SELECT foo FROM bar WHERE bar > foo( ? )',
         ]
       },
       {
         equal => 1,
         statements => [
-          'SELECT foo FROM bar WHERE bar foo ?',
-          'SELECT foo FROM bar WHERE bar foo (?)',
-          'SELECT foo FROM bar WHERE bar foo( (?))',
+          'SELECT foo FROM bar WHERE bar LIKE ?',
+          'SELECT foo FROM bar WHERE bar LiKe (?)',
+          'SELECT foo FROM bar WHERE bar lIkE( (?))',
         ]
       },
-      # not so about multival
+      # test multival
       {
         equal => 0,
         statements => [
@@ -693,6 +704,14 @@ my @sql_tests = (
           'SELECT * FROM foo WHERE bar = (baz( buzz ))',
         ]
       },
+      # oddballs
+      {
+        equal => 1,
+        statements => [
+          'WHERE ( foo GLOB ? )',
+          'WHERE foo GLOB ?',
+        ],
+      }
 );
 
 my @bind_tests = (
@@ -898,7 +917,7 @@ plan tests => 1 +
       map { scalar @{$_->{bindvals}} }
         @bind_tests
   ) +
-  3;
+  9;
 
 use_ok('SQL::Abstract::Test', import => [qw(
   eq_sql_bind eq_sql eq_bind is_same_sql_bind
@@ -980,3 +999,36 @@ ok(!eq_sql_bind(
   ),
   "eq_sql_bind considers different SQL expressions and equal bind values different"
 );
+
+# test diag string
+ok (! eq_sql (
+  'SELECT owner_name FROM books me WHERE ( source = ? )',
+  'SELECT owner_name FROM books me WHERE ( sUOrce = ? )',
+));
+like(
+  $SQL::Abstract::Test::sql_differ,
+  qr/\Q[ source ] != [ sUOrce ]/,
+  'expected debug of literal diff',
+);
+
+ok (! eq_sql (
+  'SELECT owner_name FROM books me ORDER BY owner_name',
+  'SELECT owner_name FROM books me GROUP BY owner_name',
+));
+like(
+  $SQL::Abstract::Test::sql_differ,
+  qr/\QOP [ORDER BY] != [GROUP BY]/,
+  'expected debug of op diff',
+);
+
+ok (! eq_sql (
+  'SELECT owner_name FROM books WHERE ( source = ? )',
+  'SELECT owner_name FROM books'
+));
+
+like(
+  $SQL::Abstract::Test::sql_differ,
+  qr|\Q[WHERE source = ?] != [N/A]|,
+  'expected debug of missing branch',
+);
+