convert all uses of Test::Exception to Test::Fatal.

[gitmo/Class-MOP.git] / t / 021_attribute_errors_and_edge_cases.t

diff --git a/t/021_attribute_errors_and_edge_cases.t b/t/021_attribute_errors_and_edge_cases.t
index 4de3ff0..5958752 100644 (file)
--- a/t/021_attribute_errors_and_edge_cases.t
+++ b/t/021_attribute_errors_and_edge_cases.t
@@ -1,116 +1,145 @@
 use strict;
 use warnings;
 
-use Test::More tests => 27;
-use Test::Exception;
+use Test::More;
+use Test::Fatal;
 
-BEGIN {use Class::MOP;use Class::MOP::Attribute;
-}
+use Class::MOP;
+use Class::MOP::Attribute;
 
 # most values are static
 
 {
-    dies_ok {
+    ok exception {
         Class::MOP::Attribute->new('$test' => (
             default => qr/hello (.*)/
         ));
-    } '... no refs for defaults';
+    }, '... no refs for defaults';
 
-    dies_ok {
+    ok exception {
         Class::MOP::Attribute->new('$test' => (
             default => []
         ));
-    } '... no refs for defaults';
+    }, '... no refs for defaults';
 
-    dies_ok {
+    ok exception {
         Class::MOP::Attribute->new('$test' => (
             default => {}
         ));
-    } '... no refs for defaults';
+    }, '... no refs for defaults';
 
 
-    dies_ok {
+    ok exception {
         Class::MOP::Attribute->new('$test' => (
             default => \(my $var)
         ));
-    } '... no refs for defaults';
+    }, '... no refs for defaults';
 
-    dies_ok {
+    ok exception {
         Class::MOP::Attribute->new('$test' => (
             default => bless {} => 'Foo'
         ));
-    } '... no refs for defaults';
+    }, '... no refs for defaults';
 
 }
 
 {
-    dies_ok {
+    ok exception {
         Class::MOP::Attribute->new('$test' => (
             builder => qr/hello (.*)/
         ));
-    } '... no refs for builders';
+    }, '... no refs for builders';
 
-    dies_ok {
+    ok exception {
         Class::MOP::Attribute->new('$test' => (
             builder => []
         ));
-    } '... no refs for builders';
+    }, '... no refs for builders';
 
-    dies_ok {
+    ok exception {
         Class::MOP::Attribute->new('$test' => (
             builder => {}
         ));
-    } '... no refs for builders';
+    }, '... no refs for builders';
 
 
-    dies_ok {
+    ok exception {
         Class::MOP::Attribute->new('$test' => (
             builder => \(my $var)
         ));
-    } '... no refs for builders';
+    }, '... no refs for builders';
 
-    dies_ok {
+    ok exception {
         Class::MOP::Attribute->new('$test' => (
             builder => bless {} => 'Foo'
         ));
-    } '... no refs for builders';
+    }, '... no refs for builders';
 
-    dies_ok {
+    ok exception {
         Class::MOP::Attribute->new('$test' => (
             builder => 'Foo', default => 'Foo'
         ));
-    } '... no default AND builder';
+    }, '... no default AND builder';
+
+    my $undef_attr;
+    ok ! exception {
+        $undef_attr = Class::MOP::Attribute->new('$test' => (
+            default   => undef,
+            predicate => 'has_test',
+        ));
+    }, '... undef as a default is okay';
+    ok($undef_attr->has_default, '... and it counts as an actual default');
+    ok(!Class::MOP::Attribute->new('$test')->has_default,
+       '... but attributes with no default have no default');
+
+    Class::MOP::Class->create(
+        'Foo',
+        attributes => [$undef_attr],
+    );
+    {
+        my $obj = Foo->meta->new_object;
+        ok($obj->has_test, '... and the default is populated');
+        is($obj->meta->get_attribute('$test')->get_value($obj), undef, '... with the right value');
+    }
+    ok ! exception { Foo->meta->make_immutable },
+             '... and it can be inlined';
+    {
+        my $obj = Foo->new;
+        ok($obj->has_test, '... and the default is populated');
+        is($obj->meta->get_attribute('$test')->get_value($obj), undef, '... with the right value');
+    }
 
 }
 
 
 { # bad construtor args
-    dies_ok {
+    ok exception {
         Class::MOP::Attribute->new();
-    } '... no name argument';
+    }, '... no name argument';
 
-    dies_ok {
+    # These are no longer errors
+    ok ! exception {
         Class::MOP::Attribute->new('');
-    } '... bad name argument';
+    }, '... bad name argument';
 
-    dies_ok {
+    ok ! exception {
         Class::MOP::Attribute->new(0);
-    } '... bad name argument';
+    }, '... bad name argument';
 }
 
 {
     my $attr = Class::MOP::Attribute->new('$test');
-    dies_ok {
+    ok exception {
         $attr->attach_to_class();
-    } '... attach_to_class died as expected';
+    }, '... attach_to_class died as expected';
 
-    dies_ok {
+    ok exception {
         $attr->attach_to_class('Fail');
-    } '... attach_to_class died as expected';
+    }, '... attach_to_class died as expected';
 
-    dies_ok {
+    ok exception {
         $attr->attach_to_class(bless {} => 'Fail');
-    } '... attach_to_class died as expected';
+    }, '... attach_to_class died as expected';
 }
 
 {
@@ -120,17 +149,17 @@ BEGIN {use Class::MOP;use Class::MOP::Attribute;
 
     $attr->attach_to_class(Class::MOP::Class->initialize('Foo'));
 
-    dies_ok {
+    ok exception {
         $attr->install_accessors;
-    } '... bad reader format';
+    }, '... bad reader format';
 }
 
 {
     my $attr = Class::MOP::Attribute->new('$test');
 
-    dies_ok {
+    ok exception {
         $attr->_process_accessors('fail', 'my_failing_sub');
-    } '... cannot find "fail" type generator';
+    }, '... cannot find "fail" type generator';
 }
 
 
@@ -145,9 +174,9 @@ BEGIN {use Class::MOP;use Class::MOP::Attribute;
         reader => 'test'
     ));
 
-    dies_ok {
+    ok exception {
         $attr->install_accessors;
-    } '... failed to generate accessors correctly';
+    }, '... failed to generate accessors correctly';
 }
 
 {
@@ -178,25 +207,27 @@ BEGIN {use Class::MOP;use Class::MOP::Attribute;
     # it works, which is kinda silly, but it
     # tests the API change, so I keep it.
 
-    lives_ok {
+    ok ! exception {
         Class::MOP::Attribute->new('$foo', (
             accessor => 'foo',
             reader   => 'get_foo',
         ));
-    } '... can create accessors with reader/writers';
+    }, '... can create accessors with reader/writers';
 
-    lives_ok {
+    ok ! exception {
         Class::MOP::Attribute->new('$foo', (
             accessor => 'foo',
             writer   => 'set_foo',
         ));
-    } '... can create accessors with reader/writers';
+    }, '... can create accessors with reader/writers';
 
-    lives_ok {
+    ok ! exception {
         Class::MOP::Attribute->new('$foo', (
             accessor => 'foo',
             reader   => 'get_foo',
             writer   => 'set_foo',
         ));
-    } '... can create accessors with reader/writers';
+    }, '... can create accessors with reader/writers';
 }
+
+done_testing;