use Test::Warn;
use Test::Exception;
-use SQL::Abstract::Test import => [qw( is_same_sql_bind diag_where dumper )];
+use SQL::Abstract::Test import => [qw(is_same_sql_bind diag_where dumper)];
use SQL::Abstract;
#
#################
-
my @tests = (
{
func => 'select',
bind => ['boom']
},
{
+ # this is maybe wrong but a single arg doesn't get quoted
+ func => 'select',
+ args => ['test', 'id', { a => { '!=', 'boom' } }],
+ stmt => 'SELECT id FROM test WHERE ( a != ? )',
+ stmt_q => 'SELECT id FROM `test` WHERE ( `a` != ? )',
+ bind => ['boom']
+ },
+ {
func => 'update',
args => ['test', {a => 'boom'}, {a => undef}],
stmt => 'UPDATE test SET a = ? WHERE ( a IS NULL )',
},
{
func => 'update',
+ args => ['test', {a => undef }, {a => 'boom'}],
+ stmt => 'UPDATE test SET a = ? WHERE ( a = ? )',
+ stmt_q => 'UPDATE `test` SET `a` = ? WHERE ( `a` = ? )',
+ bind => [undef,'boom']
+ },
+ {
+ func => 'update',
args => ['test', {a => 'boom'}, { a => {'!=', "bang" }} ],
stmt => 'UPDATE test SET a = ? WHERE ( a != ? )',
stmt_q => 'UPDATE `test` SET `a` = ? WHERE ( `a` != ? )',
stmt_q => 'UPDATE `mytable` SET `foo` = ? WHERE `baz` = ? RETURNING `id`, `created_at`',
bind => [42, 32],
},
+ {
+ func => 'delete',
+ args => ['test', {requestor => undef}, {returning => 'id'}],
+ stmt => 'DELETE FROM test WHERE ( requestor IS NULL ) RETURNING id',
+ stmt_q => 'DELETE FROM `test` WHERE ( `requestor` IS NULL ) RETURNING `id`',
+ bind => []
+ },
+ {
+ func => 'delete',
+ args => ['test', {requestor => undef}, {returning => \'*'}],
+ stmt => 'DELETE FROM test WHERE ( requestor IS NULL ) RETURNING *',
+ stmt_q => 'DELETE FROM `test` WHERE ( `requestor` IS NULL ) RETURNING *',
+ bind => []
+ },
+ {
+ func => 'delete',
+ args => ['test', {requestor => undef}, {returning => ['id', 'created_at']}],
+ stmt => 'DELETE FROM test WHERE ( requestor IS NULL ) RETURNING id, created_at',
+ stmt_q => 'DELETE FROM `test` WHERE ( `requestor` IS NULL ) RETURNING `id`, `created_at`',
+ bind => []
+ },
+ {
+ func => 'delete',
+ args => ['test', \[ undef ] ],
+ stmt => 'DELETE FROM test',
+ stmt_q => 'DELETE FROM `test`',
+ bind => []
+ },
);
# check is( not) => undef
-for my $op ( qw(not is is_not), 'is not' ) {
+for my $op (qw(not is is_not), 'is not') {
(my $sop = uc $op) =~ s/_/ /gi;
$sop = 'IS NOT' if $sop eq 'NOT';
}
# check single-element inequality ops for no warnings
-for my $op ( qw(!= <>) ) {
+for my $op (qw(!= <>)) {
for my $val (undef, 42) {
push @tests, {
func => 'where',
}
# check all multi-element inequality/not-like ops for warnings
-for my $op ( qw(!= <> not_like not_rlike), 'not like', 'not rlike', 'is not like','is not rlike') {
+for my $op (qw(!= <> not_like not_rlike), 'not like', 'not rlike', 'is not like','is not rlike') {
(my $sop = uc $op) =~ s/_/ /gi;
push @tests, {
}
# check all like/not-like ops for empty-arrayref warnings
-for my $op ( qw(like rlike not_like not_rlike), 'not like', 'not rlike', 'is like', 'is not like', 'is rlike', 'is not rlike') {
+for my $op (qw(like rlike not_like not_rlike), 'not like', 'not rlike', 'is like', 'is not like', 'is rlike', 'is not rlike') {
(my $sop = uc $op) =~ s/_/ /gi;
push @tests, {
[ foo => "bar", $lhs => \["baz"], bizz => "buzz" ],
[ $lhs => \"baz" ],
[ $lhs => \["baz"] ],
-
- # except for this one, that is automagically arrayified
- { foo => "bar", -or => { $lhs => \"baz" }, bizz => "buzz" },
) {
push @tests, {
func => 'where',
## deprecations - sorta worked, likely abused by folks
for my $where_arg (
# the arrayref forms of this never worked and throw above
+ { foo => "bar", -or => { $lhs => \"baz" }, bizz => "buzz" },
{ foo => "bar", -and => { $lhs => \"baz" }, bizz => "buzz" },
{ foo => "bar", $lhs => \"baz", bizz => "buzz" },
{ foo => "bar", $lhs => \["baz"], bizz => "buzz" },
my $cref = sub {
my $op = $t->{func};
- ($stmt, @bind) = $maker->$op (@ { $t->{args} } );
+ ($stmt, @bind) = $maker->$op(@{ $t->{args} });
};
if (my $e = $t->{throws}) {
throws_ok(
sub { $cref->() },
$e,
- ) || diag dumper ({ args => $t->{args}, result => $stmt });
+ ) || diag dumper({ args => $t->{args}, result => $stmt });
}
else {
- warnings_like(
- sub { $cref->() },
- $t->{warns} || [],
- ) || diag dumper ({ args => $t->{args}, result => $stmt });
+ lives_ok(sub {
+ alarm(1); local $SIG{ALRM} = sub {
+ no warnings 'redefine';
+ my $orig = Carp->can('caller_info');
+ local *Carp::caller_info = sub { return if $_[0] > 20; &$orig };
+ print STDERR "ARGH ($SQL::Abstract::Default_Scalar_To): ".Carp::longmess();
+ die "timed out";
+ };
+ warnings_like(
+ sub { $cref->() },
+ $t->{warns} || [],
+ ) || diag dumper({ args => $t->{args}, result => $stmt });
+ }) || diag dumper({ args => $t->{args}, result => $stmt, threw => $@ });
is_same_sql_bind(
$stmt,
\@bind,
$quoted ? $t->{stmt_q}: $t->{stmt},
$t->{bind}
- );
+ ) || diag dumper({ args => $t->{args}, result => $stmt });;
}
}
}