Got the basic requirement in place!

[gitmo/MooseX-Dependent.git] / t / 01-basic.t

diff --git a/t/01-basic.t b/t/01-basic.t
index 136928b..611cb06 100644 (file)
--- a/t/01-basic.t
+++ b/t/01-basic.t
@@ -1,5 +1,5 @@
 
-use Test::More tests=>8; {
+use Test::More tests=>9; {
        
        use strict;
        use warnings;
@@ -7,32 +7,33 @@ use Test::More tests=>8; {
        use_ok 'MooseX::Meta::TypeConstraint::Dependent';
        use_ok 'Moose::Util::TypeConstraints';
 
-       ## A sample dependent type constraint the requires two ints and see which
-       ## is the greater.
+       ## A sample dependent type constraint the requires two ints and sees if
+       ## the dependent value (the first) is greater than the constraining value
+       ## (the second).
        
        ok my $int = find_type_constraint('Int') => 'Got Int';
        
        my $dep_tc = MooseX::Meta::TypeConstraint::Dependent->new(
                name => "MooseX::Types::Dependent::Depending" ,
-               parent => find_type_constraint('ArrayRef'),
+               parent => find_type_constraint('Int'),
                dependent_type_constraint=>$int,
-               comparision_callback=>sub {
+               comparison_callback=>sub {
                        my ($constraining_value, $check_value) = @_;
-                       return $constraining_value > $check_value ? 0:1;
+                       return $check_value > $constraining_value ? 0:1;
                },
-               constraint_generator =>$int,
-               constraint_generator=> sub { 
+               constraining_type_constraint =>$int,
+               constraint_generator=> sub {
+                       ## Because "shift->(shift,shift)" is not very clear, is it :)
                        my ($callback, $constraining_value, $check_value) = @_;
-                       return $callback->($constraining_value, $check_value) ? 1:0;
+                       return $callback->($constraining_value, $check_value);
                },
        );
-       
-       ## Does this work at all?
 
        isa_ok $dep_tc, 'MooseX::Meta::TypeConstraint::Dependent';
-
-       ok !$dep_tc->check([5,10]), "Fails, 5 is less than 10";
-       ok !$dep_tc->check(['a',10]), "Fails, 'a' is not an Int.";
-       ok !$dep_tc->check([5,'b']), "Fails, 'b' is not an Int either.";
-       ok $dep_tc->check([10,5]), "Success, 10 is greater than 5.";
+       
+       ok !$dep_tc->check('a',10), "Fails, 'a' is not an Int.";
+       ok !$dep_tc->check(5,'b'), "Fails, 'b' is not an Int either.";
+       ok !$dep_tc->check([4,1]), "Fails, since this isn't an arrayref";
+       ok !$dep_tc->check(5,10), "Fails, 5 is less than 10";
+       ok $dep_tc->check(11,6), "Success, 11 is greater than 6.";
 }