Default to allocating the correct size for the array in the HV.

[p5sagit/p5-mst-13.2.git] / lib / open.t

diff --git a/lib/open.t b/lib/open.t
index 7e09d8d..554798b 100644 (file)
--- a/lib/open.t
+++ b/lib/open.t
@@ -19,7 +19,7 @@ ok( require 'open.pm', 'requiring open' );
 
 # this should fail
 eval { import() };
-like( $@, qr/needs explicit list of disciplines/,
+like( $@, qr/needs explicit list of PerlIO layers/,
        'import should fail without args' );
 
 # the hint bits shouldn't be set yet
@@ -32,27 +32,21 @@ local $SIG{__WARN__} = sub {
        $warn .= shift;
 };
 
-# and it shouldn't be able to find this discipline
+# and it shouldn't be able to find this layer
 $warn = '';
 eval q{ no warnings 'layer'; use open IN => ':macguffin' ; };
 is( $warn, '',
-       'should not warn about unknown discipline with bad discipline provided' );
+       'should not warn about unknown layer with bad layer provided' );
 
 $warn = '';
 eval q{ use warnings 'layer'; use open IN => ':macguffin' ; };
-like( $warn, qr/Unknown discipline layer/,
-       'should warn about unknown discipline with bad discipline provided' );
+like( $warn, qr/Unknown PerlIO layer/,
+       'should warn about unknown layer with bad layer provided' );
 
-SKIP: {
-    skip("no perlio, no :utf8", 1) unless (find PerlIO::Layer 'perlio');
-    # now load a real-looking locale
-    $ENV{LC_ALL} = ' .utf8';
-    import( 'IN', 'locale' );
-    like( ${^OPEN}, qr/^(:utf8)?:utf8\0/,
-        'should set a valid locale layer' );
-}
+# open :locale logic changed since open 1.04, new logic
+# difficult to test portably.
 
-# and see if it sets the magic variables appropriately
+# see if it sets the magic variables appropriately
 import( 'IN', ':crlf' );
 ok( $^H & $open::hint_bits,
        'hint bits should be set in $^H after open import' );
@@ -64,12 +58,12 @@ is( $^H{'open_IN'}, 'raw', 'should have reset to raw layer' );
 
 # it dies if you don't set IN, OUT, or IO
 eval { import( 'sideways', ':raw' ) };
-like( $@, qr/Unknown discipline class/, 'should croak with unknown class' );
+like( $@, qr/Unknown PerlIO layer class/, 'should croak with unknown class' );
 
 # but it handles them all so well together
 import( 'IO', ':raw :crlf' );
 is( ${^OPEN}, ":raw :crlf\0:raw :crlf",
-       'should set multi types, multi disciplines' );
+       'should set multi types, multi layer' );
 is( $^H{'open_IO'}, 'crlf', 'should record last layer set in %^H' );
 
 SKIP: {
@@ -171,6 +165,16 @@ EOE
        "checking syswrite() output on :utf8 streams by reading it back in");
 }
 
+SKIP: {
+    skip("no perlio", 1) unless (find PerlIO::Layer 'perlio');
+    use open IN => ':non-existent';
+    eval {
+       require Symbol; # Anything that exists but we havn't loaded
+    };
+    like($@, qr/Can't locate Symbol|Recursive call/i,
+        "test for an endless loop in PerlIO_find_layer");
+}
+
 END {
     1 while unlink "utf8";
     1 while unlink "a";