Fix tests

[catagits/Test-NoTabs.git] / lib / Test / NoTabs.pm

diff --git a/lib/Test/NoTabs.pm b/lib/Test/NoTabs.pm
index 83fd59a..4324127 100644 (file)
--- a/lib/Test/NoTabs.pm
+++ b/lib/Test/NoTabs.pm
@@ -10,7 +10,7 @@ use File::Find;
 
 use vars qw( $VERSION $PERL $UNTAINT_PATTERN $PERL_PATTERN);
 
-$VERSION = '0.7';
+$VERSION = '1.0';
 
 $PERL    = $^X || 'perl';
 $UNTAINT_PATTERN  = qr|^([-+@\w./:\\]+)$|;
@@ -64,14 +64,14 @@ sub _all_files {
 
 sub notabs_ok {
     my $file = shift;
-    my $test_txt = shift || "Found tabs in '$file'";
+    my $test_txt = shift || "No tabs in '$file'";
     $file = _module_to_path($file);
     open my $fh, $file or do { $Test->ok(0, $test_txt); $Test->diag("Could not open $file: $!"); return; };
     my $line = 0;
     while (<$fh>) {
         $line++;
         next if (/^\s*#/);
-        next if (/^\s*=.+/ .. /^\s*=(cut|back|end)/);
+        next if (/^\s*=.+/ .. (/^\s*=(cut|back|end)/ || eof($fh)));
         last if (/^\s*(__END__|__DATA__)/);
         if ( /\t/ ) {
           $Test->ok(0, $test_txt . " on line $line");
@@ -85,8 +85,8 @@ sub notabs_ok {
 sub all_perl_files_ok {
     my @files = _all_perl_files( @_ );
     _make_plan();
-    foreach my $file ( @files ) {
-      notabs_ok($file);
+    foreach my $file ( sort @files ) {
+      notabs_ok($file, "No tabs in '$file'");
     }
 }
 
@@ -98,7 +98,7 @@ sub _is_perl_script {
     my $file = shift;
     return 1 if $file =~ /\.pl$/i;
     return 1 if $file =~ /\.t$/;
-    open my $fh, $file or return;
+    open (my $fh, $file) or return;
     my $first = <$fh>;
     return 1 if defined $first && ($first =~ $PERL_PATTERN);
     return;
@@ -236,9 +236,9 @@ distribution.
 
 Rick Myers and Emanuele Zeppieri also provided valuable feedback.
 
-Patch to fix warnings provided by Florian Ragwitz
+Patch to fix warnings provided by Florian Ragwitz (rafl)
 
-Currently maintained by Tomas Doran C<bobtfish@bobtfish.net>
+Currently maintained by Tomas Doran (t0m) C<bobtfish@bobtfish.net>
 
 =head1 SEE ALSO