use SQL::Translator::Schema::Table;
my $table = SQL::Translator::Schema::Table->new( name => 'foo' );
-=head1 DESCSIPTION
+=head1 DESCRIPTION
C<SQL::Translator::Schema::Table> is the table object.
=cut
use strict;
+use warnings;
use SQL::Translator::Utils 'parse_list_arg';
use SQL::Translator::Schema::Constants;
use SQL::Translator::Schema::Constraint;
use SQL::Translator::Schema::Field;
use SQL::Translator::Schema::Index;
-use Data::Dumper;
-use base 'SQL::Translator::Schema::Object';
+use Carp::Clan '^SQL::Translator';
+use List::Util 'max';
-use vars qw( $VERSION );
+use base 'SQL::Translator::Schema::Object';
-$VERSION = '1.59';
+our $VERSION = '1.59';
# Stringify to our name, being careful not to pass any args through so we don't
# accidentally set it to undef. We also have to tweak bool so the object is
=cut
-sub new {
- my $class = shift;
- my $self = $class->SUPER::new (@_)
- or return;
-
- $self->{_order} = { map { $_ => 0 } qw/
- field
- /};
-
- return $self;
-}
-
sub add_constraint {
=pod
$self->error( $field_class->error );
}
- $field->order( ++$self->{_order}{field} );
+ my $existing_order = { map { $_->order => $_->name } $self->get_fields };
+
+ # supplied order, possible unordered assembly
+ if ( $field->order ) {
+ if($existing_order->{$field->order}) {
+ croak sprintf
+ "Requested order '%d' for column '%s' conflicts with already existing column '%s'",
+ $field->order,
+ $field->name,
+ $existing_order->{$field->order},
+ ;
+ }
+ }
+ else {
+ my $last_field_no = max(keys %$existing_order) || 0;
+ if ( $last_field_no != scalar keys %$existing_order ) {
+ croak sprintf
+ "Table '%s' field order incomplete - unable to auto-determine order for newly added field",
+ $self->name,
+ ;
+ }
+
+ $field->order( $last_field_no + 1 );
+ }
+
# We know we have a name as the Field->new above errors if none given.
my $field_name = $field->name;
- if ( exists $self->{'fields'}{ $field_name } ) {
+ if ( $self->get_field($field_name) ) {
return $self->error(qq[Can't create field: "$field_name" exists]);
}
else {