use base qw(SQL::Translator::Producer);
use SQL::Translator::Schema::Constants;
-use SQL::Translator::Utils qw(debug header_comment parse_dbms_version);
+use SQL::Translator::Utils qw(debug header_comment parse_dbms_version batch_alter_table_statements normalize_quote_options);
+use SQL::Translator::Generator::DDL::PostgreSQL;
use Data::Dumper;
+{
+ my ($quoting_generator, $nonquoting_generator);
+ sub _generator {
+ my $options = shift;
+ return $options->{generator} if exists $options->{generator};
+
+ return normalize_quote_options($options)
+ ? $quoting_generator ||= SQL::Translator::Generator::DDL::PostgreSQL->new
+ : $nonquoting_generator ||= SQL::Translator::Generator::DDL::PostgreSQL->new(
+ quote_chars => [],
+ );
+ }
+}
+
my ( %translate, %index_name );
my $max_id_length;
$pargs->{postgres_version}, 'perl'
);
- my $qt = $translator->quote_table_names ? q{"} : q{};
- my $qf = $translator->quote_field_names ? q{"} : q{};
+ my $generator = _generator({ quote_identifiers => $translator->quote_identifiers });
my @output;
push @output, header_comment unless ($no_comments);
for my $table ( $schema->get_tables ) {
my ($table_def, $fks) = create_table($table, {
- quote_table_names => $qt,
- quote_field_names => $qf,
+ generator => $generator,
no_comments => $no_comments,
postgres_version => $postgres_version,
add_drop_table => $add_drop_table,
}
for my $view ( $schema->get_views ) {
- push @table_defs, create_view($view, {
- postgres_version => $postgres_version,
- add_drop_view => $add_drop_table,
- quote_table_names => $qt,
- quote_field_names => $qf,
- no_comments => $no_comments,
- });
+ push @table_defs, create_view($view, {
+ postgres_version => $postgres_version,
+ add_drop_view => $add_drop_table,
+ generator => $generator,
+ no_comments => $no_comments,
+ });
+ }
+
+ for my $trigger ( $schema->get_triggers ) {
+ push @table_defs, create_trigger( $trigger, {
+ add_drop_trigger => $add_drop_table,
+ no_comments => $no_comments,
+ });
}
push @output, map { "$_;\n\n" } values %type_defs;
{
my ($table, $options) = @_;
- my $qt = $options->{quote_table_names} || '';
- my $qf = $options->{quote_field_names} || '';
+ my $generator = _generator($options);
my $no_comments = $options->{no_comments} || 0;
my $add_drop_table = $options->{add_drop_table} || 0;
my $postgres_version = $options->{postgres_version} || 0;
my $type_defs = $options->{type_defs} || {};
my $table_name = $table->name or next;
- my ( $fql_tbl_name ) = ( $table_name =~ s/\W(.*)$// ) ? $1 : q{};
- my $table_name_ur = $qt ? $table_name
- : $fql_tbl_name ? join('.', $table_name, $fql_tbl_name)
- : $table_name;
- $table->name($table_name_ur);
+ my $table_name_qt = $generator->quote($table_name);
# print STDERR "$table_name table_name\n";
my ( @comments, @field_defs, @sequence_defs, @constraint_defs, @fks );
- push @comments, "--\n-- Table: $table_name_ur\n--\n" unless $no_comments;
+ push @comments, "--\n-- Table: $table_name\n--\n" unless $no_comments;
if ( $table->comments and !$no_comments ){
my $c = "-- Comments: \n-- ";
#
my %field_name_scope;
for my $field ( $table->get_fields ) {
- push @field_defs, create_field($field, { quote_table_names => $qt,
- quote_field_names => $qf,
- table_name => $table_name_ur,
- postgres_version => $postgres_version,
- type_defs => $type_defs,
- constraint_defs => \@constraint_defs,});
+ push @field_defs, create_field($field, {
+ generator => $generator,
+ postgres_version => $postgres_version,
+ type_defs => $type_defs,
+ constraint_defs => \@constraint_defs,
+ });
}
#
my @index_defs = ();
# my $idx_name_default;
for my $index ( $table->get_indices ) {
- my ($idef, $constraints) = create_index($index,
- {
- quote_field_names => $qf,
- quote_table_names => $qt,
- table_name => $table_name,
- });
+ my ($idef, $constraints) = create_index($index, {
+ generator => $generator,
+ });
$idef and push @index_defs, $idef;
push @constraint_defs, @$constraints;
}
#
my $c_name_default;
for my $c ( $table->get_constraints ) {
- my ($cdefs, $fks) = create_constraint($c,
- {
- quote_field_names => $qf,
- quote_table_names => $qt,
- table_name => $table_name,
- });
+ my ($cdefs, $fks) = create_constraint($c, {
+ generator => $generator,
+ });
push @constraint_defs, @$cdefs;
push @fks, @$fks;
}
my $temporary = "";
- if(exists $table->{extra}{temporary}) {
- $temporary = $table->{extra}{temporary} ? "TEMPORARY " : "";
+ if(exists $table->extra->{temporary}) {
+ $temporary = $table->extra->{temporary} ? "TEMPORARY " : "";
}
my $create_statement;
$create_statement = join("\n", @comments);
if ($add_drop_table) {
if ($postgres_version >= 8.002) {
- $create_statement .= qq[DROP TABLE IF EXISTS $qt$table_name_ur$qt CASCADE;\n];
+ $create_statement .= "DROP TABLE IF EXISTS $table_name_qt CASCADE;\n";
} else {
- $create_statement .= qq[DROP TABLE $qt$table_name_ur$qt CASCADE;\n];
+ $create_statement .= "DROP TABLE $table_name_qt CASCADE;\n";
}
}
- $create_statement .= qq[CREATE ${temporary}TABLE $qt$table_name_ur$qt (\n].
+ $create_statement .= "CREATE ${temporary}TABLE $table_name_qt (\n" .
join( ",\n", map { " $_" } @field_defs, @constraint_defs ).
"\n)"
;
sub create_view {
my ($view, $options) = @_;
- my $qt = $options->{quote_table_names} || '';
- my $qf = $options->{quote_field_names} || '';
+ my $generator = _generator($options);
my $postgres_version = $options->{postgres_version} || 0;
my $add_drop_view = $options->{add_drop_view};
debug("PKG: Looking at view '${view_name}'\n");
my $create = '';
- $create .= "--\n-- View: ${qt}${view_name}${qt}\n--\n"
+ $create .= "--\n-- View: " . $generator->quote($view_name) . "\n--\n"
unless $options->{no_comments};
if ($add_drop_view) {
if ($postgres_version >= 8.002) {
- $create .= "DROP VIEW IF EXISTS ${qt}${view_name}${qt};\n";
+ $create .= "DROP VIEW IF EXISTS " . $generator->quote($view_name) . ";\n";
} else {
- $create .= "DROP VIEW ${qt}${view_name}${qt};\n";
+ $create .= "DROP VIEW " . $generator->quote($view_name) . ";\n";
}
}
$create .= 'CREATE';
my $extra = $view->extra;
$create .= " TEMPORARY" if exists($extra->{temporary}) && $extra->{temporary};
- $create .= " VIEW ${qt}${view_name}${qt}";
+ $create .= " VIEW " . $generator->quote($view_name);
if ( my @fields = $view->fields ) {
- my $field_list = join ', ', map { "${qf}${_}${qf}" } @fields;
+ my $field_list = join ', ', map { $generator->quote($_) } @fields;
$create .= " ( ${field_list} )";
}
{
my ($field, $options) = @_;
- my $qt = $options->{quote_table_names} || '';
- my $qf = $options->{quote_field_names} || '';
+ my $generator = _generator($options);
my $table_name = $field->table->name;
my $constraint_defs = $options->{constraint_defs} || [];
my $postgres_version = $options->{postgres_version} || 0;
? "-- " . $field->comments . "\n "
: '';
- my $field_def = $field_comments.qq[$qf$field_name$qf];
+ my $field_def = $field_comments . $generator->quote($field_name);
#
# Datatype
my $data_type = lc $field->data_type;
my %extra = $field->extra;
my $list = $extra{'list'} || [];
- # todo deal with embedded quotes
- my $commalist = join( ', ', map { qq['$_'] } @$list );
+ my $commalist = join( ', ', map { __PACKAGE__->_quote_string($_) } @$list );
if ($postgres_version >= 8.003 && $field->data_type eq 'enum') {
my $type_name = $extra{'custom_type_name'} || $field->table->name . '_' . $field->name . '_type';
#
# Default value
#
- SQL::Translator::Producer->_apply_default_value(
+ __PACKAGE__->_apply_default_value(
$field,
\$field_def,
[
#
if(is_geometry($field)){
foreach ( create_geometry_constraints($field) ) {
- my ($cdefs, $fks) = create_constraint($_,
- {
- quote_field_names => $qf,
- quote_table_names => $qt,
- table_name => $table_name,
- });
+ my ($cdefs, $fks) = create_constraint($_, {
+ generator => $generator,
+ });
push @$constraint_defs, @$cdefs;
push @$fks, @$fks;
}
my @constraints;
push @constraints, SQL::Translator::Schema::Constraint->new(
name => "enforce_dims_".$field->name,
- expression => "(ST_NDims($field) = ".$field->{extra}{dimensions}.")",
+ expression => "(ST_NDims($field) = ".$field->extra->{dimensions}.")",
table => $field->table,
type => CHECK_C,
);
push @constraints, SQL::Translator::Schema::Constraint->new(
name => "enforce_srid_".$field->name,
- expression => "(ST_SRID($field) = ".$field->{extra}{srid}.")",
+ expression => "(ST_SRID($field) = ".$field->extra->{srid}.")",
table => $field->table,
type => CHECK_C,
);
push @constraints, SQL::Translator::Schema::Constraint->new(
name => "enforce_geotype_".$field->name,
- expression => "(GeometryType($field) = '".$field->{extra}{geometry_type}."'::text OR $field IS NULL)",
+ expression => "(GeometryType($field) = '".$field->extra->{geometry_type}."'::text OR $field IS NULL)",
table => $field->table,
type => CHECK_C,
);
{
my ($index, $options) = @_;
- my $qt = $options->{quote_table_names} ||'';
- my $qf = $options->{quote_field_names} ||'';
+ my $generator = _generator($options);
my $table_name = $index->table->name;
my ($index_def, @constraint_defs);
my @fields = $index->fields;
return unless @fields;
- my $def_start = qq[CONSTRAINT ${qf}$name${qf} ];
- my $field_names = '(' . join(", ", (map { $_ =~ /\(.*\)/ ? $_ : ($qf . $_ . $qf ) } @fields)) . ')';
+ my $def_start = 'CONSTRAINT ' . $generator->quote($name) . ' ';
+ my $field_names = '(' . join(", ", (map { $_ =~ /\(.*\)/ ? $_ : ( $generator->quote($_) ) } @fields)) . ')';
if ( $type eq PRIMARY_KEY ) {
push @constraint_defs, "${def_start}PRIMARY KEY ".$field_names;
}
}
elsif ( $type eq NORMAL ) {
$index_def =
- "CREATE INDEX ${qf}${name}${qf} on ${qt}${table_name}${qt} ".$field_names
+ 'CREATE INDEX ' . $generator->quote($name) . ' on ' . $generator->quote($table_name) . ' ' . $field_names
;
}
else {
{
my ($c, $options) = @_;
- my $qf = $options->{quote_field_names} ||'';
- my $qt = $options->{quote_table_names} ||'';
+ my $generator = _generator($options);
my $table_name = $c->table->name;
my (@constraint_defs, @fks);
my @rfields = grep { defined } $c->reference_fields;
next if !@fields && $c->type ne CHECK_C;
- my $def_start = $name ? qq[CONSTRAINT ${qf}$name${qf} ] : '';
- my $field_names = '(' . join(", ", (map { $_ =~ /\(.*\)/ ? $_ : ($qf . $_ . $qf ) } @fields)) . ')';
+ my $def_start = $name ? 'CONSTRAINT ' . $generator->quote($name) . ' ' : '';
+ my $field_names = '(' . join(", ", (map { $_ =~ /\(.*\)/ ? $_ : ( $generator->quote($_) ) } @fields)) . ')';
if ( $c->type eq PRIMARY_KEY ) {
push @constraint_defs, "${def_start}PRIMARY KEY ".$field_names;
}
push @constraint_defs, "${def_start}CHECK ($expression)";
}
elsif ( $c->type eq FOREIGN_KEY ) {
- my $def .= "ALTER TABLE $qt$table_name$qt ADD ${def_start}FOREIGN KEY $field_names"
- . "\n REFERENCES " . $qt . $c->reference_table . $qt;
+ my $def .= "ALTER TABLE " . $generator->quote($table_name) . " ADD ${def_start}FOREIGN KEY $field_names"
+ . "\n REFERENCES " . $generator->quote($c->reference_table);
if ( @rfields ) {
- $def .= ' ('.$qf . join( $qf.', '.$qf, @rfields ) . $qf.')';
+ $def .= ' (' . join( ', ', map { $generator->quote($_) } @rfields ) . ')';
}
if ( $c->match_type ) {
return \@constraint_defs, \@fks;
}
+sub create_trigger {
+ my ($trigger,$options) = @_;
+
+ my @statements;
+
+ push @statements, sprintf( 'DROP TRIGGER IF EXISTS %s', $trigger->name )
+ if $options->{add_drop_trigger};
+
+ my $scope = $trigger->scope || '';
+ $scope = " FOR EACH $scope" if $scope;
+
+ push @statements, sprintf(
+ 'CREATE TRIGGER %s %s %s ON %s%s %s',
+ $trigger->name,
+ $trigger->perform_action_when,
+ join( ' OR ', @{ $trigger->database_events } ),
+ $trigger->on_table,
+ $scope,
+ $trigger->action,
+ );
+
+ return @statements;
+}
+
sub convert_datatype
{
my ($field) = @_;
# $len = ($len < length($_)) ? length($_) : $len for (@$list);
# my $chk_name = mk_name( $table_name.'_'.$field_name, 'chk' );
# push @$constraint_defs,
-# qq[CONSTRAINT "$chk_name" CHECK ($qf$field_name$qf ].
+# 'CONSTRAINT "$chk_name" CHECK (' . $generator->quote(field_name) .
# qq[IN ($commalist))];
$data_type = 'character varying';
}
# Geography
#
if($data_type eq 'geography'){
- $data_type .= '('.$field->{extra}{geography_type}.','. $field->{extra}{srid} .')'
+ $data_type .= '('.$field->extra->{geography_type}.','. $field->extra->{srid} .')'
}
return $data_type;
if(ref $default_value eq "SCALAR" ) {
$default_value = $$default_value;
} elsif( defined $default_value && $to_dt =~ /^(character|text)/xsmi ) {
- $default_value =~ s/'/''/xsmg;
- $default_value = q(') . $default_value . q(');
+ $default_value = __PACKAGE__->_quote_string($default_value);
}
push @out, sprintf('ALTER TABLE %s ALTER COLUMN %s SET DEFAULT %s',
$to_field->name)
if ( !defined $new_default && defined $old_default );
- # add geometry column and contraints
+ # add geometry column and constraints
push @out, add_geometry_column($to_field) if is_geometry($to_field);
push @out, add_geometry_constraints($to_field) if is_geometry($to_field);
{
my ($old_field, $options) = @_;
- my $qt = $options->{quote_table_names} ||'';
- my $qf = $options->{quote_field_names} ||'';
+ my $generator = _generator($options);
my $out = sprintf('ALTER TABLE %s DROP COLUMN %s',
- $qt . $old_field->table->name . $qt,
- $qf . $old_field->name . $qf);
+ $generator->quote($old_field->table->name),
+ $generator->quote($old_field->name));
$out .= "\n".drop_geometry_column($old_field) if is_geometry($old_field);
return $out;
}
$field->table->schema->name,
$options->{table} ? $options->{table} : $field->table->name,
$field->name,
- $field->{extra}{dimensions},
- $field->{extra}{srid},
- $field->{extra}{geometry_type});
+ $field->extra->{dimensions},
+ $field->extra->{srid},
+ $field->extra->{geometry_type});
return $out;
}
sub alter_table {
my ($to_table, $options) = @_;
- my $qt = $options->{quote_table_names} || '';
+ my $generator = _generator($options);
my $out = sprintf('ALTER TABLE %s %s',
- $qt . $to_table->name . $qt,
+ $generator->quote($to_table->name),
$options->{alter_table_action});
$out .= "\n".$options->{geometry_changes} if $options->{geometry_changes};
return $out;
sub rename_table {
my ($old_table, $new_table, $options) = @_;
- my $qt = $options->{quote_table_names} || '';
- $options->{alter_table_action} = "RENAME TO $qt$new_table$qt";
+ my $generator = _generator($options);
+ $options->{alter_table_action} = "RENAME TO " . $generator->quote($new_table);
my @geometry_changes;
push @geometry_changes, map { drop_geometry_column($_); } grep { is_geometry($_) } $old_table->get_fields;
sub alter_create_index {
my ($index, $options) = @_;
- my $qt = $options->{quote_table_names} || '';
- my $qf = $options->{quote_field_names} || '';
+ my $generator = _generator($options);
my ($idef, $constraints) = create_index($index, {
- quote_field_names => $qf,
- quote_table_names => $qt,
- table_name => $index->table->name,
+ generator => $generator,
});
return $index->type eq NORMAL ? $idef
: sprintf('ALTER TABLE %s ADD %s',
- $qt . $index->table->name . $qt,
+ $generator->quote($index->table->name),
join(q{}, @$constraints)
);
}
sub alter_drop_constraint {
my ($c, $options) = @_;
- my $qt = $options->{quote_table_names} || '';
- my $qc = $options->{quote_field_names} || '';
+ my $generator = _generator($options);
+
+ # attention: Postgres has a very special naming structure for naming
+ # foreign keys and primary keys. It names them using the name of the
+ # table as prefix and fkey or pkey as suffix, concatenated by an underscore
+ my $c_name;
+ if( $c->name ) {
+ # Already has a name, just quote it
+ $c_name = $generator->quote($c->name);
+ } elsif ( $c->type eq FOREIGN_KEY ) {
+ # Doesn't have a name, and is foreign key, append '_fkey'
+ $c_name = $generator->quote($c->table->name . '_' .
+ ($c->fields)[0] . '_fkey');
+ } elsif ( $c->type eq PRIMARY_KEY ) {
+ # Doesn't have a name, and is primary key, append '_pkey'
+ $c_name = $generator->quote($c->table->name . '_pkey');
+ }
return sprintf(
'ALTER TABLE %s DROP CONSTRAINT %s',
- $qt . $c->table->name . $qt,
- # attention: Postgres has a very special naming structure
- # for naming foreign keys, it names them uses the name of
- # the table as prefix and fkey as suffix, concatenated by a underscore
- $c->type eq FOREIGN_KEY
- ? $c->name
- ? $qc . $c->name . $qc
- : $qc . $c->table->name . '_' . ($c->fields)[0] . '_fkey' . $qc
- : $qc . $c->name . $qc
+ $generator->quote($c->table->name), $c_name
);
}
sub alter_create_constraint {
my ($index, $options) = @_;
- my $qt = $options->{quote_table_names} || '';
+ my $generator = _generator($options);
my ($defs, $fks) = create_constraint(@_);
# return if there are no constraint definitions so we don't run
return unless(@{$defs} || @{$fks});
return $index->type eq FOREIGN_KEY ? join(q{}, @{$fks})
- : join( ' ', 'ALTER TABLE', $qt.$index->table->name.$qt,
+ : join( ' ', 'ALTER TABLE', $generator->quote($index->table->name),
'ADD', join(q{}, @{$defs}, @{$fks})
);
}
sub drop_table {
my ($table, $options) = @_;
- my $qt = $options->{quote_table_names} || '';
- my $out = "DROP TABLE $qt$table$qt CASCADE";
+ my $generator = _generator($options);
+ my $out = "DROP TABLE " . $generator->quote($table) . " CASCADE";
my @geometry_drops = map { drop_geometry_column($_); } grep { is_geometry($_) } $table->get_fields;
return $out;
}
+sub batch_alter_table {
+ my ( $table, $diff_hash, $options ) = @_;
+
+ # as long as we're not renaming the table we don't need to be here
+ if ( @{$diff_hash->{rename_table}} == 0 ) {
+ return batch_alter_table_statements($diff_hash, $options);
+ }
+
+ # first we need to perform drops which are on old table
+ my @sql = batch_alter_table_statements($diff_hash, $options, qw(
+ alter_drop_constraint
+ alter_drop_index
+ drop_field
+ ));
+
+ # next comes the rename_table
+ my $old_table = $diff_hash->{rename_table}[0][0];
+ push @sql, rename_table( $old_table, $table, $options );
+
+ # for alter_field (and so also rename_field) we need to make sure old
+ # field has table name set to new table otherwise calling alter_field dies
+ $diff_hash->{alter_field} =
+ [map { $_->[0]->table($table) && $_ } @{$diff_hash->{alter_field}}];
+ $diff_hash->{rename_field} =
+ [map { $_->[0]->table($table) && $_ } @{$diff_hash->{rename_field}}];
+
+ # now add everything else
+ push @sql, batch_alter_table_statements($diff_hash, $options, qw(
+ add_field
+ alter_field
+ rename_field
+ alter_create_index
+ alter_create_constraint
+ alter_table
+ ));
+
+ return @sql;
+}
+
1;
# -------------------------------------------------------------------