simple mutable fields now use value_string (ChooseMany unconverted)

[catagits/Reaction.git] / lib / Reaction / UI / ViewPort / Field / Role / Mutable.pm

diff --git a/lib/Reaction/UI/ViewPort/Field/Role/Mutable.pm b/lib/Reaction/UI/ViewPort/Field/Role/Mutable.pm
index 8a90ff8..42899c0 100644 (file)
--- a/lib/Reaction/UI/ViewPort/Field/Role/Mutable.pm
+++ b/lib/Reaction/UI/ViewPort/Field/Role/Mutable.pm
@@ -9,9 +9,16 @@ role Mutable, which {
   has model     => (is => 'ro', isa => Action, required => 1);
   has attribute => (is => 'ro', isa => ParameterAttribute, required => 1);
 
-  has value      => (is => 'rw', lazy_build => 1, trigger_adopt('value'));
+  has value      => (
+    is => 'rw', lazy_build => 1, trigger_adopt('value'),
+    clearer => 'clear_value',
+  );
   has needs_sync => (is => 'rw', isa => 'Int', default => 0);
-  has message    => (is => 'rw', isa => 'Str');
+  has message => (is => 'rw', isa => 'Str');
+
+  after clear_value => sub {
+    shift->needs_sync(1);
+  };
 
   implements adopt_value => as {
     my ($self) = @_;
@@ -20,21 +27,33 @@ role Mutable, which {
 
   implements sync_to_action => as {
     my ($self) = @_;
-    return unless $self->needs_sync && $self->has_value;
+    return unless $self->needs_sync;
     my $attr = $self->attribute;
-    if (my $tc = $attr->type_constraint) {
+
+    if ($self->has_value) {
       my $value = $self->value;
-      $value = $tc->coercion->coerce($value) if ($tc->has_coercion);
-      my $error = $tc->validate($self->value); # should we be checking against $value?
-      if (defined $error) {
-        $self->message($error);
-        return;
+      if (my $tc = $attr->type_constraint) {
+        $value = $tc->coercion->coerce($value) if ($tc->has_coercion);
+        #my $error = $tc->validate($self->value); # should we be checking against $value?
+        my $error = $tc->validate($value);
+        if (defined $error) {
+          $self->message($error);
+          return;
+        }
+      }
+      my $writer = $attr->get_write_method;
+      confess "No writer for attribute" unless defined($writer);
+      $self->model->$writer($value);
+    } else {
+      my $predicate = $attr->predicate;
+      confess "No predicate for attribute" unless defined($predicate);
+      if ($self->model->$predicate) {
+        my $clearer = $attr->clearer;
+        confess "${predicate} returned true but no clearer for attribute"
+          unless defined($clearer);
+        $self->model->$clearer;
       }
     }
-    my $writer = $attr->get_write_method;
-    confess "No writer for attribute" unless defined($writer);
-    my $value = $self->value;
-    $self->model->$writer($self->value); #should we be passing $value ?
     $self->needs_sync(0);
   };
 
@@ -49,3 +68,43 @@ role Mutable, which {
 };
 
 1;
+
+=head1 NAME
+
+Reaction::UI::ViewPort::Role::Actions
+
+=head1 DESCRIPTION
+
+A role to ease attaching actions to L<Reaction::InterfaceModel::Object>s
+
+=head1 ATTRIBUTES
+
+=head2 needs_sync
+
+=head2 message
+
+=head2 model
+
+=head2 attribute
+
+=head2 value
+
+=head1 METHODS
+
+=head2 accept_events
+
+=head2 sync_from_action
+
+=head2 sync_to_action
+
+=head2 adopt_value
+
+=head1 AUTHORS
+
+See L<Reaction::Class> for authors.
+
+=head1 LICENSE
+
+See L<Reaction::Class> for the license.
+
+=cut