memory leaks on CRUD fixed

[catagits/Reaction.git] / lib / Reaction / UI / ViewPort / Field / DateTime.pm

diff --git a/lib/Reaction/UI/ViewPort/Field/DateTime.pm b/lib/Reaction/UI/ViewPort/Field/DateTime.pm
index 51232cf..46fbb60 100644 (file)
--- a/lib/Reaction/UI/ViewPort/Field/DateTime.pm
+++ b/lib/Reaction/UI/ViewPort/Field/DateTime.pm
@@ -2,31 +2,27 @@ package Reaction::UI::ViewPort::Field::DateTime;
 
 use Scalar::Util 'blessed';
 use Reaction::Class;
-use Reaction::Types::DateTime;
+use Reaction::Types::DateTime ();
 use aliased 'Reaction::UI::ViewPort::Field';
 
-class DateTime is Field, which {
-  has '+value' => (isa => 'DateTime');
+use namespace::clean -except => [ qw(meta) ];
+extends Field;
 
-  has value_string_default_format => (
-    isa => 'Str', is => 'rw', required => 1, default => sub { "%F %H:%M:%S" }
-  );
 
-  implements _build_value_string => as {
-    my $self = shift;
-    # XXX
-    #<mst> aha, I know why the fucker's lazy
-    #<mst> it's because if value's calculated
-    #<mst> it needs to be possible to clear it
-    #<mst> eval { $self->value } ... is probably the best solution atm
-    my $value = $self->value;
-    return '' unless blessed $value;
-    my $format = $self->value_string_default_format;
-    return $value->strftime($format);
-  };
+has '+value' => (isa => Reaction::Types::DateTime::DateTime());
 
-  implements _empty_value => as { undef };
+has value_string_default_format => (
+  isa => 'Str', is => 'rw', required => 1, default => sub { "%F %H:%M:%S" }
+);
 
+around _value_string_from_value => sub {
+  my $orig = shift;
+  my $self = shift;
+  my $format = $self->value_string_default_format;
+  return $self->$orig(@_)->strftime($format);
 };
 
+__PACKAGE__->meta->make_immutable;
+
+
 1;