on second thought, make all empty specs return a lexical sort

[catagits/Reaction.git] / lib / Reaction / UI / ViewPort / Collection.pm

diff --git a/lib/Reaction/UI/ViewPort/Collection.pm b/lib/Reaction/UI/ViewPort/Collection.pm
index 26b75d4..d9692ef 100644 (file)
--- a/lib/Reaction/UI/ViewPort/Collection.pm
+++ b/lib/Reaction/UI/ViewPort/Collection.pm
@@ -5,67 +5,66 @@ use Scalar::Util qw/blessed/;
 use aliased 'Reaction::InterfaceModel::Collection' => 'IM_Collection';
 use aliased 'Reaction::UI::ViewPort::Object';
 
-class Collection is 'Reaction::UI::ViewPort', which {
-
-  has members => (is => 'rw', isa => 'ArrayRef', lazy_build => 1);
-
-  has collection         => (is => 'ro', isa => IM_Collection, required   => 1);
-  has current_collection => (is => 'rw', isa => IM_Collection, lazy_build => 1);
-
-  has member_args  => ( is => 'rw', isa => 'HashRef', lazy_build => 1);
-  has member_class => ( is => 'ro', isa => 'Str',     lazy_build => 1);
-
-  implements BUILD => as {
-    my ($self, $args) = @_;
-    if( my $member_args = delete $args->{Member} ){
-      $self->member_args( $member_args );
-    }
-  };
-
-  implements _build_member_args => as{ {} };
-
-  implements _build_member_class => as{ Object };
-
-  after clear_current_collection => sub{
-    shift->clear_members; #clear the members the current collection changes, duh
-  };
-
-  implements _build_current_collection => as {
-    return $_[0]->collection;
-  };
-
-  #I'm not really sure why this is here all of a sudden.
-  implements model => as { shift->current_collection };
-
-  implements _build_members => as {
-    my ($self) = @_;
-    my (@members, $i);
-    my $args = $self->member_args;
-    my $builders = {};
-    my $ctx = $self->ctx;
-    my $loc = join('-', $self->location, 'member');
-    my $class = $self->member_class;
-
-    #replace $i with a real unique identifier so that we don't run a risk of
-    # events being passed down to the wrong viewport. for now i disabled event
-    # passing until i fix this (groditi)
-    for my $obj ( $self->current_collection->members ) {
-      my $type = blessed $obj;
-      my $builder_cache = $builders->{$type} ||= {};
-      my $member = $class->new(
-                            ctx           => $ctx,
-                            model         => $obj,
-                            location      => join('-', $loc, $i++),
-                            builder_cache => $builder_cache,
-                            %$args
-                           );
-      push(@members, $member);
-    }
-    return \@members;
-  };
+use namespace::clean -except => [ qw(meta) ];
+extends 'Reaction::UI::ViewPort';
 
+
+
+has members => (is => 'rw', isa => 'ArrayRef', lazy_build => 1);
+
+has collection         => (is => 'ro', isa => IM_Collection, required   => 1);
+has current_collection => (is => 'rw', isa => IM_Collection, lazy_build => 1);
+
+has member_args  => ( is => 'rw', isa => 'HashRef', lazy_build => 1);
+has member_class => ( is => 'ro', isa => 'Str',     lazy_build => 1);
+sub BUILD {
+  my ($self, $args) = @_;
+  if( my $member_args = delete $args->{Member} ){
+    $self->member_args( $member_args );
+  }
+};
+sub _build_member_args { {} };
+sub _build_member_class { Object };
+
+after clear_current_collection => sub{
+  shift->clear_members; #clear the members the current collection changes, duh
+};
+sub _build_current_collection {
+  return $_[0]->collection;
+};
+
+#I'm not really sure why this is here all of a sudden.
+sub model { shift->current_collection };
+sub _build_members {
+  my ($self) = @_;
+  my (@members, $i);
+  my $args = $self->member_args;
+  my $builders = {};
+  my $ctx = $self->ctx;
+  my $loc = join('-', $self->location, 'member');
+  my $class = $self->member_class;
+
+  #replace $i with a real unique identifier so that we don't run a risk of
+  # events being passed down to the wrong viewport. for now i disabled event
+  # passing until i fix this (groditi)
+  for my $obj ( $self->current_collection->members ) {
+    my $type = blessed $obj;
+    my $builder_cache = $builders->{$type} ||= {};
+    my $member = $class->new(
+                          ctx           => $ctx,
+                          model         => $obj,
+                          location      => join('-', $loc, $i++),
+                          builder_cache => $builder_cache,
+                          %$args
+                         );
+    push(@members, $member);
+  }
+  return \@members;
 };
 
+__PACKAGE__->meta->make_immutable;
+
+
 1;
 
 __END__;
@@ -89,8 +88,6 @@ member of the collection.
 
 =head2 member_class
 
-=head1
-
 =head1 INTERNAL METHODS
 
 These methods, although stable, are subject to change without notice. These are meant