use warnings;
# ABSTRACT: pure perl implementation of the Package::Stash API
+use B;
use Carp qw(confess);
use Scalar::Util qw(blessed reftype weaken);
use Symbol;
# before 5.10, stashes don't ever seem to drop to a refcount of zero, so
# weakening them isn't helpful
use constant BROKEN_WEAK_STASH => ($] < 5.010);
+# before 5.10, the scalar slot was always treated as existing if the
+# glob existed
+use constant BROKEN_SCALAR_INITIALIZATION => ($] < 5.010);
=head1 SYNOPSIS
sub new {
my $class = shift;
my ($package) = @_;
- my $namespace;
+
+ if (!defined($package) || (ref($package) && ref($package) ne 'HASH')) {
+ confess "Package::Stash->new must be passed the name of the "
+ . "package to access";
+ }
+ elsif (ref($package) eq 'HASH') {
+ confess "The pure perl implementation of Package::Stash doesn't "
+ . "currently support anonymous stashes. You should install "
+ . "Package::Stash::XS";
+ }
+ elsif ($package !~ /[0-9A-Z_a-z]+(?:::[0-9A-Z_a-z]+)*/) {
+ confess "$package is not a module name";
+ }
+
return bless {
'package' => $package,
}, $class;
}
else {
my $ref = reftype($value);
- return !defined($ref) || $ref eq 'SCALAR' || $ref eq 'REF' || $ref eq 'LVALUE';
+ return !defined($ref) || $ref eq 'SCALAR' || $ref eq 'REF' || $ref eq 'LVALUE' || $ref eq 'REGEXP' || $ref eq 'VSTRING';
}
}
sub remove_glob {
my ($self, $name) = @_;
- no strict 'refs';
- delete ${$self->name . '::'}{$name};
+ delete $self->namespace->{$name};
}
sub has_symbol {
my $entry_ref = \$namespace->{$name};
if (reftype($entry_ref) eq 'GLOB') {
- # XXX: assigning to any typeglob slot also initializes the SCALAR slot,
- # and saying that an undef scalar variable doesn't exist is probably
- # vaguely less surprising than a scalar variable popping into existence
- # without anyone defining it
if ($type eq 'SCALAR') {
- return defined ${ *{$entry_ref}{$type} };
+ if (BROKEN_SCALAR_INITIALIZATION) {
+ return defined ${ *{$entry_ref}{$type} };
+ }
+ else {
+ return B::svref_2object($entry_ref)->SV->isa('B::SV');
+ }
}
else {
return defined *{$entry_ref}{$type};
$io = $self->get_symbol($io_desc) if $self->has_symbol($io_desc);
}
elsif ($type eq 'ARRAY') {
- $scalar = $self->get_symbol($scalar_desc);
+ $scalar = $self->get_symbol($scalar_desc) if $self->has_symbol($scalar_desc) || BROKEN_SCALAR_INITIALIZATION;
$hash = $self->get_symbol($hash_desc) if $self->has_symbol($hash_desc);
$code = $self->get_symbol($code_desc) if $self->has_symbol($code_desc);
$io = $self->get_symbol($io_desc) if $self->has_symbol($io_desc);
}
elsif ($type eq 'HASH') {
- $scalar = $self->get_symbol($scalar_desc);
+ $scalar = $self->get_symbol($scalar_desc) if $self->has_symbol($scalar_desc) || BROKEN_SCALAR_INITIALIZATION;
$array = $self->get_symbol($array_desc) if $self->has_symbol($array_desc);
$code = $self->get_symbol($code_desc) if $self->has_symbol($code_desc);
$io = $self->get_symbol($io_desc) if $self->has_symbol($io_desc);
}
elsif ($type eq 'CODE') {
- $scalar = $self->get_symbol($scalar_desc);
+ $scalar = $self->get_symbol($scalar_desc) if $self->has_symbol($scalar_desc) || BROKEN_SCALAR_INITIALIZATION;
$array = $self->get_symbol($array_desc) if $self->has_symbol($array_desc);
$hash = $self->get_symbol($hash_desc) if $self->has_symbol($hash_desc);
$io = $self->get_symbol($io_desc) if $self->has_symbol($io_desc);
}
elsif ($type eq 'IO') {
- $scalar = $self->get_symbol($scalar_desc);
+ $scalar = $self->get_symbol($scalar_desc) if $self->has_symbol($scalar_desc) || BROKEN_SCALAR_INITIALIZATION;
$array = $self->get_symbol($array_desc) if $self->has_symbol($array_desc);
$hash = $self->get_symbol($hash_desc) if $self->has_symbol($hash_desc);
$code = $self->get_symbol($code_desc) if $self->has_symbol($code_desc);
$self->remove_glob($name);
- $self->add_symbol($scalar_desc => $scalar);
+ $self->add_symbol($scalar_desc => $scalar) if defined $scalar;
$self->add_symbol($array_desc => $array) if defined $array;
$self->add_symbol($hash_desc => $hash) if defined $hash;
$self->add_symbol($code_desc => $code) if defined $code;
}
elsif ($type_filter eq 'SCALAR') {
return grep {
- ref(\$namespace->{$_}) eq 'GLOB'
- && defined(${*{$namespace->{$_}}{'SCALAR'}})
+ BROKEN_SCALAR_INITIALIZATION
+ ? (ref(\$namespace->{$_}) eq 'GLOB'
+ && defined(${*{$namespace->{$_}}{'SCALAR'}}))
+ : (do {
+ my $entry = \$namespace->{$_};
+ ref($entry) eq 'GLOB'
+ && B::svref_2object($entry)->SV->isa('B::SV')
+ })
} keys %{$namespace};
}
else {
=over 4
-=item * Scalar slots are only considered to exist if they are defined
-
-This is due to a shortcoming within perl itself. See
-L<perlref/Making References> point 7 for more information.
-
=item * remove_symbol also replaces the associated typeglob
This can cause unexpected behavior when doing manipulation at compile time -