performance tuning

[gitmo/Mouse.git] / lib / Mouse / Meta / Method / Constructor.pm

diff --git a/lib/Mouse/Meta/Method/Constructor.pm b/lib/Mouse/Meta/Method/Constructor.pm
index 84d36ee..2de3802 100644 (file)
--- a/lib/Mouse/Meta/Method/Constructor.pm
+++ b/lib/Mouse/Meta/Method/Constructor.pm
@@ -3,41 +3,37 @@ use strict;
 use warnings;
 
 sub generate_constructor_method_inline {
-    my ($class, $meta) = @_; 
-    my $code = $class->_generate_constructor_method_inline($meta);
-    warn $code if $ENV{DEBUG};
-
-    local $@;
-    my $res = eval $code;
-    die $@ if $@;
-    $res;
-}
-
-sub _generate_constructor_method_inline {
     my ($class, $meta) = @_;
+
+    my @attrs = $meta->compute_all_applicable_attributes; # this one is using by evaled code
     my $buildall = $class->_generate_BUILDALL($meta);
     my $buildargs = $class->_generate_BUILDARGS();
-    my $classname = $meta->name;
-    my $processattrs = $class->_generate_processattrs($meta);
+    my $processattrs = $class->_generate_processattrs($meta, \@attrs);
 
-    return <<"...";
+    my $code = <<"...";
     sub {
         my \$class = shift;
         my \$args = $buildargs;
-        my \$instance = bless {}, '$classname';
-        my \$meta = \$instance->meta;
+        my \$instance = bless {}, \$class;
         $processattrs;
         $buildall;
         return \$instance;
     }
 ...
+
+    warn $code if $ENV{DEBUG};
+
+    local $@;
+    my $res = eval $code;
+    die $@ if $@;
+    $res;
 }
 
 sub _generate_processattrs {
-    my ($class, $meta, ) = @_;
-    my @attrs = $meta->compute_all_applicable_attributes;
+    my ($class, $meta, $attrs) = @_;
     my @res;
-    for my $attr (@attrs) {
+    for my $index (0..scalar(@$attrs)-1) {
+        my $attr = $attrs->[$index];
         my $from = $attr->init_arg;
         my $key  = $attr->name;
         my $part1 = do {
@@ -93,7 +89,7 @@ sub _generate_processattrs {
         };
         my $code = <<"...";
             {
-                my \$attr = \$meta->get_attribute('$key');
+                my \$attr = \$attrs[$index];
                 my \$from = '$from';
                 my \$key  = '$key';
                 if (defined(\$from) && exists(\$args->{\$from})) {