recursion test

[gitmo/MooseX-Types.git] / lib / MooseX / Types / TypeDecorator.pm

diff --git a/lib/MooseX/Types/TypeDecorator.pm b/lib/MooseX/Types/TypeDecorator.pm
index f39bd55..519cad7 100644 (file)
--- a/lib/MooseX/Types/TypeDecorator.pm
+++ b/lib/MooseX/Types/TypeDecorator.pm
@@ -4,20 +4,29 @@ use strict;
 use warnings;
 
 use Carp::Clan qw( ^MooseX::Types );
-use Moose::Util::TypeConstraints;
+use Moose::Util::TypeConstraints ();
 use Moose::Meta::TypeConstraint::Union;
+use Scalar::Util qw(blessed);
 
 use overload(
     '""' => sub {
-        shift->type_constraint->name;  
+        return shift->__type_constraint->name; 
     },
     '|' => sub {
-        my @tc = grep {ref $_} @_;
+        
+        ## It's kind of ugly that we need to know about Union Types, but this
+        ## is needed for syntax compatibility.  Maybe someday we'll all just do
+        ## Or[Str,Str,Int]
+        
+        my @tc = grep {blessed $_} @_;
         my $union = Moose::Meta::TypeConstraint::Union->new(type_constraints=>\@tc);
         return Moose::Util::TypeConstraints::register_type_constraint($union);
     },
+    fallback => 1,
+    
 );
 
+
 =head1 NAME
 
 MooseX::Types::TypeDecorator - More flexible access to a Type Constraint
@@ -38,31 +47,43 @@ Old school instantiation
 =cut
 
 sub new {
-    my ($class, %args) = @_;
-    if(
-        $args{type_constraint} && ref($args{type_constraint}) &&
-        ($args{type_constraint}->isa('Moose::Meta::TypeConstraint') ||
-        $args{type_constraint}->isa('MooseX::Types::UndefinedType'))
-    ) {
-        return bless \%args, $class;        
+    my $class = shift @_;
+    if(my $arg = shift @_) {
+        if(blessed $arg && $arg->isa('Moose::Meta::TypeConstraint')) {
+            return bless {'__type_constraint'=>$arg}, $class;
+        } elsif(
+            blessed $arg &&
+            $arg->isa('MooseX::Types::UndefinedType') 
+          ) {
+            ## stub in case we'll need to handle these types differently
+            return bless {'__type_constraint'=>$arg}, $class;
+        } elsif(blessed $arg) {
+            croak "Argument must be ->isa('Moose::Meta::TypeConstraint') or ->isa('MooseX::Types::UndefinedType'), not ". blessed $arg;
+        } else {
+            croak "Argument cannot be '$arg'";
+        }
     } else {
-        croak "The argument 'type_constraint' is not valid.";
+        croak "This method [new] requires a single argument.";        
     }
-
 }
 
-=head type_constraint ($type_constraint)
+=head __type_constraint ($type_constraint)
 
 Set/Get the type_constraint.
 
 =cut
 
-sub type_constraint {
+sub __type_constraint {
     my $self = shift @_;
-    if(defined(my $tc = shift @_)) {
-        $self->{type_constraint} = $tc;
+    
+    if(blessed $self) {
+        if(defined(my $tc = shift @_)) {
+            $self->{__type_constraint} = $tc;
+        }
+        return $self->{__type_constraint};        
+    } else {
+        croak 'cannot call __type_constraint as a class method';
     }
-    return $self->{type_constraint};
 }
 
 =head2 isa
@@ -72,10 +93,9 @@ handle $self->isa since AUTOLOAD can't.
 =cut
 
 sub isa {
-    my ($self, $target) = @_;
+    my ($self, $target) = @_;  
     if(defined $target) {
-        my $isa = $self->type_constraint->isa($target);
-        return $isa;
+        return $self->__type_constraint->isa($target);
     } else {
         return;
     }
@@ -90,8 +110,7 @@ handle $self->can since AUTOLOAD can't.
 sub can {
     my ($self, $target) = @_;
     if(defined $target) {
-        my $can = $self->type_constraint->can($target);
-        return $can;
+        return $self->__type_constraint->can($target);
     } else {
         return;
     }
@@ -114,8 +133,13 @@ Delegate to the decorator targe
 =cut
 
 sub AUTOLOAD {
+    my ($self, @args) = @_;
     my ($method) = (our $AUTOLOAD =~ /([^:]+)$/);
-    return shift->type_constraint->$method(@_);
+    if($self->__type_constraint->can($method)) {
+        return $self->__type_constraint->$method(@args);
+    } else {
+        croak "Method '$method' is not supported for ". ref($self->__type_constraint);   
+    }
 }
 
 =head1 AUTHOR AND COPYRIGHT