/;
use mro 'c3';
use Carp::Clan qw/^DBIx::Class/;
-use List::Util ();
-use Sub::Name ();
+use List::Util();
+use Sub::Name();
+use Data::Dumper::Concise();
__PACKAGE__->mk_group_accessors('simple' =>
qw/_identity _blob_log_on_update _writer_storage _is_extra_storage
my ($sql, $bind) = $self->next::method (@_);
- if ($op eq 'insert') {
- my $table = $ident->from;
+ my $table = Scalar::Util::blessed($ident) ? $ident->from : $ident;
- my $bind_info = $self->_resolve_column_info(
- $ident, [map $_->[0], @{$bind}]
+ my $bind_info = $self->_resolve_column_info(
+ $ident, [map $_->[0], @{$bind}]
+ );
+ my $bound_identity_col = List::Util::first
+ { $bind_info->{$_}{is_auto_increment} }
+ (keys %$bind_info)
+ ;
+ my $identity_col = Scalar::Util::blessed($ident) &&
+ List::Util::first
+ { $ident->column_info($_)->{is_auto_increment} }
+ $ident->columns
+ ;
+
+ if (($op eq 'insert' && $bound_identity_col) ||
+ ($op eq 'update' && exists $args->[0]{$identity_col})) {
+ $sql = join ("\n",
+ $self->_set_table_identity_sql($op => $table, 'on'),
+ $sql,
+ $self->_set_table_identity_sql($op => $table, 'off'),
);
- my $identity_col = List::Util::first
- { $bind_info->{$_}{is_auto_increment} }
- (keys %$bind_info)
- ;
-
- if ($identity_col) {
- $sql = join ("\n",
- "SET IDENTITY_INSERT $table ON",
- $sql,
- "SET IDENTITY_INSERT $table OFF",
- );
- }
- else {
- $identity_col = List::Util::first
- { $ident->column_info($_)->{is_auto_increment} }
- $ident->columns
- ;
- }
+ }
- if ($identity_col) {
- $sql =
- "$sql\n" .
- $self->_fetch_identity_sql($ident, $identity_col);
- }
+ if ($op eq 'insert' && (not $bound_identity_col) && $identity_col &&
+ (not $self->{insert_bulk})) {
+ $sql =
+ "$sql\n" .
+ $self->_fetch_identity_sql($ident, $identity_col);
}
return ($sql, $bind);
}
+sub _set_table_identity_sql {
+ my ($self, $op, $table, $on_off) = @_;
+
+ return sprintf 'SET IDENTITY_%s %s %s',
+ uc($op), $self->sql_maker->_quote($table), uc($on_off);
+}
+
# Stolen from SQLT, with some modifications. This is a makeshift
# solution before a sane type-mapping library is available, thus
# the 'our' for easy overrides.
my $self = shift;
my ($source, $to_insert) = @_;
- my $blob_cols = $self->_remove_blob_cols($source, $to_insert);
-
- my $identity_col = List::Util::first
+ my $identity_col = (List::Util::first
{ $source->column_info($_)->{is_auto_increment} }
- $source->columns;
+ $source->columns) || '';
+
+ # check for empty insert
+ # INSERT INTO foo DEFAULT VALUES -- does not work with Sybase
+ # try to insert explicit 'DEFAULT's instead (except for identity)
+ if (not %$to_insert) {
+ for my $col ($source->columns) {
+ next if $col eq $identity_col;
+ $to_insert->{$col} = \'DEFAULT';
+ }
+ }
+
+ my $blob_cols = $self->_remove_blob_cols($source, $to_insert);
# do we need the horrific SELECT MAX(COL) hack?
my $dumb_last_insert_id =
my $updated_cols = $self->$next ($source, $to_insert);
my $final_row = {
- $identity_col => $self->last_insert_id($source, $identity_col),
+ ($identity_col ?
+ ($identity_col => $self->last_insert_id($source, $identity_col)) : ()),
%$to_insert,
%$updated_cols,
};
my $is_identity_update = $identity_col && defined $fields->{$identity_col};
- if (not $blob_cols) {
- $self->_set_session_identity(UPDATE => $table, 'ON')
- if $is_identity_update;
-
- return $self->next::method(@_);
-
- $self->_set_session_identity(UPDATE => $table, 'OFF')
- if $is_identity_update;
- }
+ return $self->next::method(@_) unless $blob_cols;
-# check that we're not updating a blob column that's also in $where
- for my $blob (grep $self->_is_lob_column($source, $_), $source->columns) {
- if (exists $where->{$blob} && exists $fields->{$blob}) {
- croak
-'Update of TEXT/IMAGE column that is also in search condition impossible';
- }
- }
+# If there are any blobs in $where, Sybase will return a descriptive error
+# message.
+# XXX blobs can still be used with a LIKE query, and this should be handled.
# update+blob update(s) done atomically on separate connection
$self = $self->_writer_storage;
# it is originally put by _remove_blob_cols .)
my %blobs_to_empty = map { ($_ => delete $fields->{$_}) } keys %$blob_cols;
+# We can't only update NULL blobs, because blobs cannot be in the WHERE clause.
+
$self->next::method($source, \%blobs_to_empty, $where, @rest);
# Now update the blobs before the other columns in case the update of other
my @res;
if (%$fields) {
- $self->_set_session_identity(UPDATE => $table, 'ON')
- if $is_identity_update;
-
if ($wantarray) {
@res = $self->next::method(@_);
}
else {
$self->next::method(@_);
}
-
- $self->_set_session_identity(UPDATE => $table, 'OFF')
- if $is_identity_update;
}
$guard->commit;
return $wantarray ? @res : $res[0];
}
-sub _set_session_identity {
- my ($self, $op, $table, $off_on) = @_;
-
- my $sql = sprintf (
- 'SET IDENTITY_%s %s %s',
- uc $op,
- $self->sql_maker->_quote($table),
- uc $off_on,
- );
-
- $self->_query_start($sql);
-
- my $dbh = $self->_get_dbh;
- eval {
- local $dbh->{RaiseError} = 1;
- local $dbh->{PrintError} = 0;
- $dbh->do ($sql)
- };
- my $exception = $@;
-
- $self->_query_end($sql);
-
- if ($exception) {
- $self->throw_exception (sprintf "Error executing '%s': %s",
- $sql,
- $exception,
- );
- }
-}
-
-# for tests
-sub _can_insert_bulk { 1 }
-
sub insert_bulk {
my $self = shift;
my ($source, $cols, $data) = @_;
$source->columns;
my $is_identity_insert = (List::Util::first
- { $source->column_info ($_)->{is_auto_increment} }
+ { $_ eq $identity_col }
@{$cols}
) ? 1 : 0;
(not $self->_bulk_disabled_due_to_coderef_connect_info_warned)) {
carp <<'EOF';
Bulk API support disabled due to use of a CODEREF connect_info. Reverting to
-array inserts.
+regular array inserts.
EOF
$self->_bulk_disabled_due_to_coderef_connect_info_warned(1);
}
if (not $use_bulk_api) {
my $blob_cols = $self->_remove_blob_cols_array($source, $cols, $data);
- my $dumb_last_insert_id =
- $identity_col
- && (not $is_identity_insert)
- && ($self->_identity_method||'') ne '@@IDENTITY';
+# _execute_array uses a txn anyway, but it ends too early in case we need to
+# select max(col) to get the identity for inserting blobs.
+ ($self, my $guard) = $self->{transaction_depth} == 0 ?
+ ($self->_writer_storage, $self->_writer_storage->txn_scope_guard)
+ :
+ ($self, undef);
- ($self, my ($guard)) = do {
- if ($self->{transaction_depth} == 0 &&
- ($blob_cols || $dumb_last_insert_id)) {
- ($self->_writer_storage, $self->_writer_storage->txn_scope_guard);
- }
- else {
- ($self, undef);
- }
- };
+ local $self->{insert_bulk} = 1;
$self->next::method(@_);
}
$guard->commit if $guard;
+
return;
}
}
);
- my $bind_attributes = $self->source_bind_attributes($source);
-
- foreach my $slice_idx (0..$#source_columns) {
- my $col = $source_columns[$slice_idx];
-
- my $attributes = $bind_attributes->{$col}
- if $bind_attributes && defined $bind_attributes->{$col};
-
- my @slice = map $_->[$slice_idx], @new_data;
-
- $sth->bind_param_array(($slice_idx + 1), \@slice, $attributes);
- }
-
- $bulk->_query_start($sql);
-
-# this is stolen from DBI::insert_bulk
- my $tuple_status = [];
- my $rv = eval { $sth->execute_array({ArrayTupleStatus => $tuple_status}) };
-
- if (my $err = $@ || $sth->errstr) {
- my $i = 0;
- ++$i while $i <= $#$tuple_status && !ref $tuple_status->[$i];
-
- $self->throw_exception("Unexpected populate error: $err")
- if ($i > $#$tuple_status);
-
- $self->throw_exception(sprintf "%s for populate slice:\n%s",
- ($tuple_status->[$i][1] || $err),
- $self->_pretty_print ({
- map { $source_columns[$_] => $new_data[$i][$_] } (0 .. $#$cols)
- }),
- );
- }
+ my @bind = do {
+ my $idx = 0;
+ map [ $_, $idx++ ], @source_columns;
+ };
- $guard->commit;
- $sth->finish;
+ $self->_execute_array(
+ $source, $sth, \@bind, \@source_columns, \@new_data, sub {
+ $guard->commit
+ }
+ );
$bulk->_query_end($sql);
};
+
my $exception = $@;
+ DBD::Sybase::set_cslib_cb($orig_cslib_cb);
+
if ($exception =~ /-Y option/) {
carp <<"EOF";
*** Try unsetting the LANG environment variable.
-$@
+$exception
EOF
$self->_bulk_storage(undef);
- DBD::Sybase::set_cslib_cb($orig_cslib_cb);
unshift @_, $self;
goto \&insert_bulk;
}
elsif ($exception) {
- DBD::Sybase::set_cslib_cb($orig_cslib_cb);
# rollback makes the bulkLogin connection unusable
$self->_bulk_storage->disconnect;
$self->throw_exception($exception);
}
+}
- DBD::Sybase::set_cslib_cb($orig_cslib_cb);
+sub _dbh_execute_array {
+ my ($self, $sth, $tuple_status, $cb) = @_;
+
+ my $rv = $self->next::method($sth, $tuple_status);
+ $cb->() if $cb;
+
+ return $rv;
}
# Make sure blobs are not bound as placeholders, and return any non-empty ones
my %blob_cols;
for my $col (keys %$fields) {
- if ($self->_is_lob_type($source->column_info($col)->{data_type})) {
+ if ($self->_is_lob_column($source, $col)) {
my $blob_val = delete $fields->{$col};
if (not defined $blob_val) {
$fields->{$col} = \'NULL';
}
}
- return keys %blob_cols ? \%blob_cols : undef;
+ return %blob_cols ? \%blob_cols : undef;
}
# same for insert_bulk
for my $i (0..$#$cols) {
my $col = $cols->[$i];
- if ($self->_is_lob_type($source->column_info($col)->{data_type})) {
+ if ($self->_is_lob_column($source, $col)) {
for my $j (0..$#$data) {
my $blob_val = delete $data->[$j][$i];
if (not defined $blob_val) {
$self->throw_exception(
"Could not find row in table '$table' for blob update:\n"
- . $self->_pretty_print (\%where)
+ . Data::Dumper::Concise::Dumper (\%where)
);
}
sub connect_call_datetime_setup {
my $self = shift;
- my $dbh = $self->_dbh;
+ my $dbh = $self->_get_dbh;
if ($dbh->can('syb_date_fmt')) {
# amazingly, this works with FreeTDS
=head1 TRANSACTIONS
Due to limitations of the TDS protocol, L<DBD::Sybase>, or both; you cannot
-begin a transaction while there are active cursors. An active cursor is, for
-example, a L<ResultSet|DBIx::Class::ResultSet> that has been executed using
-C<next> or C<first> but has not been exhausted or
-L<reset|DBIx::Class::ResultSet/reset>.
+begin a transaction while there are active cursors; nor can you use multiple
+active cursors within a transaction. An active cursor is, for example, a
+L<ResultSet|DBIx::Class::ResultSet> that has been executed using C<next> or
+C<first> but has not been exhausted or L<reset|DBIx::Class::ResultSet/reset>.
For example, this will not work:
}
});
+This won't either:
+
+ my $first_row = $large_rs->first;
+ $schema->txn_do(sub { ... });
+
Transactions done for inserts in C<AutoCommit> mode when placeholders are in use
are not affected, as they are done on an extra database handle.
When inserting IMAGE columns using this method, you'll need to use
L</connect_call_blob_setup> as well.
+=head1 TODO
+
+=over
+
+=item *
+
+Transitions to AutoCommit=0 (starting a transaction) mode by exhausting
+any active cursors, using eager cursors.
+
+=item *
+
+Real limits and limited counts using stored procedures deployed on startup.
+
+=item *
+
+Adaptive Server Anywhere (ASA) support, with possible SQLA::Limit support.
+
+=item *
+
+Blob update with a LIKE query on a blob, without invalidating the WHERE condition.
+
+=item *
+
+bulk_insert using prepare_cached (see comments.)
+
+=back
+
=head1 AUTHOR
See L<DBIx::Class/CONTRIBUTORS>.