use strict;
use warnings;
-use base qw/
- DBIx::Class::Storage::DBI::MultiColumnIn
-/;
-use mro 'c3';
+use base qw/DBIx::Class::Storage::DBI/;
use Scope::Guard ();
use Context::Preserve 'preserve_context';
use DBIx::Class::Carp;
-use Try::Tiny;
+use DBIx::Class::_Util 'modver_gt_or_eq';
use namespace::clean;
__PACKAGE__->sql_limit_dialect ('LimitOffset');
__PACKAGE__->sql_quote_char ('"');
__PACKAGE__->datetime_parser_type ('DateTime::Format::Pg');
+__PACKAGE__->_use_multicolumn_in (1);
sub _determine_supports_insert_returning {
return shift->_server_info->{normalized_dbms_version} >= 8.002
for my $col (@cols) {
my $seq = ( $col_info->{$col}{sequence} ||= $self->dbh_do('_dbh_get_autoinc_seq', $source, $col) )
or $self->throw_exception( sprintf(
- 'could not determine sequence for column %s.%s, please consider adding a schema-qualified sequence to its column info',
+ "Could not determine sequence for column '%s.%s', please consider adding a schema-qualified sequence to its column info",
$source->name,
$col,
));
$seq_expr = '' unless defined $seq_expr;
$schema = "$schema." if defined $schema && length $schema;
$self->throw_exception( sprintf (
- 'no sequence found for %s%s.%s, check the RDBMS table definition or explicitly set the '.
+ "No sequence found for '%s%s.%s', check the RDBMS table definition or explicitly set the ".
"'sequence' for this column in %s",
$schema ? "$schema." : '',
$table,
));
}
- return $1;
+ return $1; # exception thrown unless match is made above
}
# custom method for fetching column default, since column_info has a
if ($self->_is_binary_lob_type($data_type)) {
# this is a hot-ish codepath, use an escape flag to minimize
# amount of function/method calls
- # additionally version.pm is cock, and memleaks on multiple
- # ->VERSION calls
# the flag is stored in the DBD namespace, so that Class::Unload
# will work (unlikely, but still)
- unless ($DBD::Pg::__DBIC_DBD_VERSION_CHECK_DONE__) {
- if ($self->_server_info->{normalized_dbms_version} >= 9.0) {
- try { DBD::Pg->VERSION('2.17.2'); 1 } or carp (
- __PACKAGE__.': BYTEA columns are known to not work on Pg >= 9.0 with DBD::Pg < 2.17.2'
+ unless (
+ modver_gt_or_eq( 'DBD::Pg', '2.17.2' )
+ or
+ $DBD::Pg::__DBIC_DBD_VERSION_CHECK_DONE__
+ ) {
+ if ( $self->_server_info->{normalized_dbms_version} >= 9.0 ) {
+ $self->throw_exception(
+ 'BYTEA columns are known to not work on Pg >= 9.0 with DBD::Pg < 2.17.2'
);
}
- elsif (not try { DBD::Pg->VERSION('2.9.2'); 1 } ) { carp (
- __PACKAGE__.': DBD::Pg 2.9.2 or greater is strongly recommended for BYTEA column support'
- )}
+ elsif (
+ my $missing = DBIx::Class::Optional::Dependencies->req_missing_for([qw( rdbms_pg binary_data )])
+ ) {
+ # FIXME - perhaps this needs to be an exception too...?
+ # too old to test sensibly...
+ carp (
+ __PACKAGE__ . ": BYTEA column support strongly recommends $missing"
+ )
+ }
$DBD::Pg::__DBIC_DBD_VERSION_CHECK_DONE__ = 1;
}
},
);
-=head1 AUTHORS
-
-See L<DBIx::Class/CONTRIBUTORS>
+=head1 FURTHER QUESTIONS?
-=head1 LICENSE
+Check the list of L<additional DBIC resources|DBIx::Class/GETTING HELP/SUPPORT>.
-You may distribute this code under the same terms as Perl itself.
+=head1 COPYRIGHT AND LICENSE
-=cut
+This module is free software L<copyright|DBIx::Class/COPYRIGHT AND LICENSE>
+by the L<DBIx::Class (DBIC) authors|DBIx::Class/AUTHORS>. You can
+redistribute it and/or modify it under the same terms as the
+L<DBIx::Class library|DBIx::Class/COPYRIGHT AND LICENSE>.