use strict;
use warnings;
-use base qw/DBIx::Class::Storage::DBI::MSSQL/;
+use base qw/
+ DBIx::Class::Storage::DBI::ODBC
+ DBIx::Class::Storage::DBI::MSSQL
+/;
use mro 'c3';
use Scalar::Util 'reftype';
use Try::Tiny;
}
if ($dsn !~ /MARS_Connection=/) {
- if ($self->using_freetds) {
- $self->throw_exception('FreeTDS does not support MARS at the time of '
- .'writing.');
+ if ($self->_using_freetds) {
+ my $v = $self->_using_freetds_version;
+ $self->throw_exception("FreeTDS 0.91 or later required for MARS support, you have $v")
+ if $v < 0.91;
}
if (exists $self->_server_info->{normalized_dbms_version} &&
B<WARNING:> on FreeTDS, changes made in one statement (e.g. an insert) may not
be visible from a following statement (e.g. a select.)
+B<WARNING:> FreeTDS versions > 0.82 seem to have completely broken the ODBC
+protocol. DBIC will not allow dynamic cursor support with such versions to
+protect your data. Please hassle the authors of FreeTDS to act on the bugs that
+make their driver not overly usable with DBD::ODBC.
+
=cut
sub connect_call_use_dynamic_cursors {
$self->throw_exception (
'Your drivers do not seem to support dynamic cursors (odbc_cursortype => 2).'
. (
- $self->using_freetds
+ $self->_using_freetds
? ' If you are using FreeTDS, make sure to set tds_version to 8.0 or greater.'
: ''
)
$self->_using_dynamic_cursors(1);
$self->_identity_method('@@identity');
+ $self->_no_scope_identity_query($self->_using_freetds);
}
else {
$self->_using_dynamic_cursors(0);
$self->_identity_method(undef);
+ $self->_no_scope_identity_query(undef);
}
}
$self->next::method (@_);
+
+ # freetds is too damn broken, some fixups
+ if ($self->_using_freetds) {
+
+ # no dynamic cursors starting from 0.83
+ if ($self->_using_dynamic_cursors) {
+ my $fv = $self->_using_freetds_version || 999; # assume large if can't be determined
+ $self->throw_exception(
+ 'Dynamic cursors (odbc_cursortype => 2) are not supported with FreeTDS > 0.82 '
+ . "(you have $fv). Please hassle FreeTDS authors to fix the outstanding bugs in "
+ . 'their driver.'
+ ) if $fv > 0.82
+ }
+
+ # FreeTDS is too broken wrt execute_for_fetch batching
+ # just disable it outright until things quiet down
+ $self->_disable_odbc_array_ops;
+ }
}
=head2 connect_call_use_server_cursors
$self->_get_dbh->{odbc_SQL_ROWSET_SIZE} = $sql_rowset_size;
}
-=head2 using_freetds
-
-Tries to determine, to the best of our ability, whether or not you are using the
-FreeTDS driver with L<DBD::ODBC>.
-
-=cut
-
-sub using_freetds {
- my $self = shift;
-
- my $dsn = $self->_dbi_connect_info->[0];
-
- $dsn = '' if ref $dsn eq 'CODE';
-
- return 1 if $dsn =~ /driver=FreeTDS/i
- || ($self->_dbh_get_info('SQL_DRIVER_NAME')||'') =~ /tdsodbc/i;
-
- return 0;
-}
-
1;
=head1 AUTHOR