sub _prep_for_execute {
my $self = shift;
- my ($op, $extra_bind, $ident, $args) = @_;
-
my ($sql, $bind) = $self->next::method(@_);
- # stringify args, quote via $dbh, and manually insert
+ # stringify bind args, quote via $dbh, and manually insert
+ #my ($op, $extra_bind, $ident, $args) = @_;
+ my $ident = $_[2];
my @sql_part = split /\?/, $sql;
my $new_sql;
- my ($alias2src, $rs_alias) = $self->_resolve_ident_sources($ident);
+ my $col_info = $self->_resolve_column_info($ident, [ map $_->[0], @$bind ]);
foreach my $bound (@$bind) {
my $col = shift @$bound;
- my $name_sep = $self->_sql_maker_opts->{name_sep} || '.';
-
- $col =~ s/^([^\Q${name_sep}\E]*)\Q${name_sep}\E//;
- my $alias = $1 || 'me';
-
- my $rsrc = $alias2src->{$alias};
-
- my $datatype = $rsrc && $rsrc->column_info($col)->{data_type};
+ my $datatype = $col_info->{$col}{data_type};
foreach my $data (@$bound) {
$data = ''.$data if ref $data;
+ $data = $self->_prep_interpolated_value($datatype, $data)
+ if $datatype;
+
$data = $self->_dbh->quote($data)
- if $self->should_quote_value($datatype, $data);
+ unless $self->interpolate_unquoted($datatype, $data);
$new_sql .= shift(@sql_part) . $data;
}
return ($new_sql, []);
}
-=head2 should_quote_value
-
+=head2 interpolate_unquoted
+
This method is called by L</_prep_for_execute> for every column in
order to determine if its value should be quoted or not. The arguments
are the current column data type and the actual bind value. The return
-value is interpreted as: true - do quote, false - do not quote. You should
+value is interpreted as: true - do not quote, false - do quote. You should
override this in you Storage::DBI::<database> subclass, if your RDBMS
does not like quotes around certain datatypes (e.g. Sybase and integer
-columns). The default method always returns true (do quote).
-
- WARNING!!!
-
+columns). The default method always returns false (do quote).
+
+ WARNING!!!
+
Always validate that the bind-value is valid for the current datatype.
Otherwise you may very well open the door to SQL injection attacks.
-
-=cut
-
-sub should_quote_value { 1 }
-=head1 AUTHORS
+=cut
-Brandon Black <blblack@gmail.com>
+sub interpolate_unquoted {
+ #my ($self, $datatype, $value) = @_;
+ return 0;
+}
+
+=head2 _prep_interpolated_value
+
+Given a datatype and the value to be inserted directly into a SQL query, returns
+the necessary string to represent that value (by e.g. adding a '$' sign)
+
+=cut
+
+sub _prep_interpolated_value {
+ #my ($self, $datatype, $value) = @_;
+ return $_[2];
+}
+
+=head1 AUTHORS
-Trym Skaar <trym@tryms.no>
+See L<DBIx::Class/CONTRIBUTORS>
=head1 LICENSE