handle duplicate relationship names (RT#64041)

[dbsrgits/DBIx-Class-Schema-Loader.git] / lib / DBIx / Class / Schema / Loader / DBI / Sybase.pm

diff --git a/lib/DBIx/Class/Schema/Loader/DBI/Sybase.pm b/lib/DBIx/Class/Schema/Loader/DBI/Sybase.pm
index 1a479d8..3d48a83 100644 (file)
--- a/lib/DBIx/Class/Schema/Loader/DBI/Sybase.pm
+++ b/lib/DBIx/Class/Schema/Loader/DBI/Sybase.pm
@@ -4,9 +4,9 @@ use strict;
 use warnings;
 use base 'DBIx::Class::Schema::Loader::DBI::Sybase::Common';
 use Carp::Clan qw/^DBIx::Class/;
-use Class::C3;
+use mro 'c3';
 
-our $VERSION = '0.07000';
+our $VERSION = '0.07010';
 
 =head1 NAME
 
@@ -19,7 +19,15 @@ See L<DBIx::Class::Schema::Loader> and L<DBIx::Class::Schema::Loader::Base>.
 
 =cut
 
-sub _is_case_sensitive { 1 }
+sub _setup {
+    my $self = shift;
+
+    $self->next::method(@_);
+
+    if (not defined $self->preserve_case) {
+        $self->preserve_case(1);
+    }
+}
 
 sub _rebless {
     my $self = shift;
@@ -36,6 +44,19 @@ sub _rebless {
     }
 }
 
+sub _tables_list {
+    my ($self, $opts) = @_;
+
+    my $dbh = $self->schema->storage->dbh;
+
+    my $sth = $dbh->table_info(undef, $self->db_schema, undef, "'TABLE','VIEW'");
+
+    my @tables = grep $_ ne 'sysquerymetrics',
+              map $_->{table_name}, @{ $sth->fetchall_arrayref({ table_name => 1 }) };
+
+    return $self->_filter_tables(\@tables, $opts);
+}
+
 sub _table_columns {
     my ($self, $table) = @_;
 
@@ -87,7 +108,7 @@ sub _table_fk_info {
     }
 
     $sth->finish;
-    return $self->_table_fk_info_builder($table);
+    return $self->_table_fk_info_by_sp_helpconstraint($table);
 }
 
 sub _table_fk_info_by_name {
@@ -121,67 +142,51 @@ sub _table_fk_info_by_name {
     return \@rels;
 }
 
-sub _table_fk_info_builder {
+sub _table_fk_info_by_sp_helpconstraint {
     my ($self, $table) = @_;
 
+    my $warn_handler = $SIG{__WARN__} || sub { warn @_ };
+    local $SIG{__WARN__} = sub {
+        $warn_handler->(@_) unless $_[0] =~
+            /^\s*$|^Total Number of|^Details|^(?:--?|=|\+) Number|^Formula for/;
+    };
+
     my $dbh = $self->schema->storage->dbh;
+
     local $dbh->{FetchHashKeyName} = 'NAME_lc';
-    # hide "Object does not exist in this database." when trying to fetch fkeys
-    local $dbh->{syb_err_handler} = sub { return 0 if $_[0] == 17461; }; 
-    my $sth = $dbh->prepare(qq{sp_fkeys \@fktable_name = @{[ $dbh->quote($table) ]}});
-    $sth->execute;
 
-    my @fk_info;
-    while (my $row = $sth->fetchrow_hashref) {
-        (my $ksq = $row->{key_seq}) =~ s/\s+//g;
+    my $sth = $dbh->prepare("sp_helpconstraint $table");
+    $sth->execute;
 
-        my @keys = qw/pktable_name pkcolumn_name fktable_name fkcolumn_name/;
-        my %ds;
-        @ds{@keys}   = @{$row}{@keys};
-        $ds{key_seq} = $ksq;
+    my $constraints = $sth->fetchall_arrayref({});
 
-        push @{ $fk_info[$ksq] }, \%ds;
-    }
-
-    my $max_keys = $#fk_info;
     my @rels;
-    for my $level (reverse 1 .. $max_keys) {
-        my @level_rels;
-        $level_rels[$level] = splice @fk_info, $level, 1;
-        my $count = @{ $level_rels[$level] };
-
-        for my $sub_level (reverse 1 .. $level-1) {
-            my $total = @{ $fk_info[$sub_level] };
-
-            $level_rels[$sub_level] = [
-                splice @{ $fk_info[$sub_level] }, $total-$count, $count
-            ];
-        }
 
-        while (1) {
-            my @rel = map shift @$_, @level_rels[1..$level];
+    foreach my $constraint (map $_->{definition}, @$constraints) {
+        my ($local_cols, $remote_table, $remote_cols) = $constraint =~
+/^$table FOREIGN KEY \(([^)]+)\) REFERENCES ([^(]+)\(([^)]+)\)/;
 
-            last unless defined $rel[0];
+        next unless $local_cols;
 
-            my @local_columns  = map $_->{fkcolumn_name}, @rel;
-            my @remote_columns = map $_->{pkcolumn_name}, @rel;
-            my $remote_table   = $rel[0]->{pktable_name};
+        my @local_cols  = split /,\s*/, $local_cols;
+        my @remote_cols = split /,\s*/, $remote_cols;
 
-            push @rels, {
-                local_columns => \@local_columns,
-                remote_columns => \@remote_columns,
-                remote_table => $remote_table
-            };
-        }
+        push @rels, {
+            local_columns  => \@local_cols,
+            remote_columns => \@remote_cols,
+            remote_table   => $remote_table,
+        };
     }
 
     return \@rels;
 }
 
 sub _table_uniq_info {
+    no warnings 'uninitialized'; # for presumably XS weirdness with null operations
     my ($self, $table) = @_;
 
-    local $SIG{__WARN__} = sub {};
+    local $SIG{__WARN__} = sub { warn @_
+        unless $_[0] =~ /^Formula for Calculation:|^(?:--?|\+|=) Number of (?:self )?references|^Total Number of Referential Constraints|^Details:|^\s*$/ };
 
     my $dbh = $self->schema->storage->dbh;
     local $dbh->{FetchHashKeyName} = 'NAME_lc';
@@ -326,3 +331,4 @@ the same terms as Perl itself.
 =cut
 
 1;
+# vim:et sts=4 sw=4 tw=0: