fix MSSQL collation detection on freetds tds version 8.0

[dbsrgits/DBIx-Class-Schema-Loader.git] / lib / DBIx / Class / Schema / Loader / DBI / MSSQL.pm

diff --git a/lib/DBIx/Class/Schema/Loader/DBI/MSSQL.pm b/lib/DBIx/Class/Schema/Loader/DBI/MSSQL.pm
index debfbde..7a019d9 100644 (file)
--- a/lib/DBIx/Class/Schema/Loader/DBI/MSSQL.pm
+++ b/lib/DBIx/Class/Schema/Loader/DBI/MSSQL.pm
@@ -27,6 +27,22 @@ L<DBD::ODBC>.
 See L<DBIx::Class::Schema::Loader> and L<DBIx::Class::Schema::Loader::Base> for
 usage information.
 
+=head1 CASE SENSITIVITY
+
+Most MSSQL databases use C<CI> (case-insensitive) collation, for this reason
+generated column names are lower-cased as this makes them easier to work with
+in L<DBIx::Class>.
+
+We attempt to detect the database collation at startup, and set the column
+lowercasing behavior accordingly, as lower-cased column names do not work on
+case-sensitive databases.
+
+To manually set or unset case-sensitive mode, put:
+
+    case_sensitive_collation => 1
+
+in your Loader options.
+
 =cut
 
 sub _is_case_sensitive {
@@ -40,6 +56,8 @@ sub _setup {
 
     $self->next::method;
 
+    return if defined $self->case_sensitive_collation;
+
     my $dbh = $self->schema->storage->dbh;
 
     # We use the sys.databases query for the general case, and fallback to
@@ -47,18 +65,26 @@ sub _setup {
     # which does not work over DBD::ODBC with unixODBC+FreeTDS.
     #
     # XXX why does databasepropertyex() not work over DBD::ODBC ?
+    #
+    # more on collations here: http://msdn.microsoft.com/en-us/library/ms143515.aspx
     my ($collation_name) =
            eval { $dbh->selectrow_array('SELECT collation_name FROM sys.databases WHERE name = DB_NAME()') }
-        || eval { $dbh->selectrow_array("SELECT databasepropertyex(DB_NAME(), 'Collation')") };
+        || eval { $dbh->selectrow_array("SELECT CAST(databasepropertyex(DB_NAME(), 'Collation') AS VARCHAR)") };
 
     if (not $collation_name) {
-        $self->case_sensitive_collation(0); # most likely not
+        warn <<'EOF';
+
+WARNING: MSSQL Collation detection failed. Defaulting to case-insensitive mode.
+Override the 'case_sensitive_collation' attribute in your Loader options if
+needed.
+EOF
+        $self->case_sensitive_collation(0);
         return;
     }
 
-    my ($sensitivity) = $collation_name =~ /(C\w)_[A-z]+\z/;
+    my $case_sensitive = $collation_name =~ /_(?:CS|BIN2?)(?:_|\z)/;
 
-    $self->case_sensitive_collation($sensitivity eq 'CS' ? 1 : 0);
+    $self->case_sensitive_collation($case_sensitive ? 1 : 0);
 }
 
 sub _lc {