use strict;
use warnings;
+use warnings::register;
+use Sub::Name ();
sub many_to_many {
my ($class, $meth, $rel, $f_rel, $rel_attrs) = @_;
my $set_meth = "set_${meth}";
my $rs_meth = "${meth}_rs";
+ for ($add_meth, $remove_meth, $set_meth, $rs_meth) {
+ if ( $class->can ($_) ) {
+ warnings::warnif(<<"EOW")
+***************************************************************************
+The many-to-many relationship $meth is trying to create a utility method called
+$_. This will overwrite the existing method on $class. You almost certainly
+want to rename your method or the many-to-many relationship, as your method
+will not be callable (it will use the one from the relationship instead.)
+
+To disable this warning add the following to $class
+
+ no warnings 'DBIx::Class::Relationship::ManyToMany';
+
+***************************************************************************
+EOW
+ }
+ }
+
$rel_attrs->{alias} ||= $f_rel;
- *{"${class}::${meth}_rs"} = sub {
+ my $rs_meth_name = join '::', $class, $rs_meth;
+ *$rs_meth_name = Sub::Name::subname $rs_meth_name, sub {
my $self = shift;
my $attrs = @_ > 1 && ref $_[$#_] eq 'HASH' ? pop(@_) : {};
my @args = ($f_rel, @_ > 0 ? @_ : undef, { %{$rel_attrs||{}}, %$attrs });
return $rs;
};
- *{"${class}::${meth}"} = sub {
+ my $meth_name = join '::', $class, $meth;
+ *$meth_name = Sub::Name::subname $meth_name, sub {
my $self = shift;
my $rs = $self->$rs_meth( @_ );
return (wantarray ? $rs->all : $rs);
};
- *{"${class}::${add_meth}"} = sub {
+ my $add_meth_name = join '::', $class, $add_meth;
+ *$add_meth_name = Sub::Name::subname $add_meth_name, sub {
my $self = shift;
@_ > 0 or $self->throw_exception(
"${add_meth} needs an object or hashref"
}
my $link_vals = @_ > 1 && ref $_[$#_] eq 'HASH' ? pop(@_) : {};
- my $link = $self->search_related($rel)->new_result({});
+ my $link = $self->search_related($rel)->new_result($link_vals);
$link->set_from_related($f_rel, $obj);
- $link->set_columns($link_vals);
$link->insert();
return $obj;
};
- *{"${class}::${set_meth}"} = sub {
+ my $set_meth_name = join '::', $class, $set_meth;
+ *$set_meth_name = Sub::Name::subname $set_meth_name, sub {
my $self = shift;
@_ > 0 or $self->throw_exception(
"{$set_meth} needs a list of objects or hashrefs"
$self->$add_meth($_) for (@to_set);
};
- *{"${class}::${remove_meth}"} = sub {
+ my $remove_meth_name = join '::', $class, $remove_meth;
+ *$remove_meth_name = Sub::Name::subname $remove_meth_name, sub {
my $self = shift;
@_ > 0 && ref $_[0] ne 'HASH'
or $self->throw_exception("${remove_meth} needs an object");