# no join condition or just a column name
if (!ref $cond) {
- $class->ensure_class_loaded($f_class);
- my %f_primaries = map { $_ => 1 } try { $f_class->_pri_cols }
- catch {
- $class->throw_exception( "Can't infer join condition for '$rel' on ${class}: $_");
- };
- my ($pri, $too_many) = keys %f_primaries;
- $class->throw_exception(
- "Can't infer join condition for '$rel' on ${class}: "
- . "${f_class} has multiple primary keys"
- ) if $too_many;
+ my ($f_key, $guess);
+ if (defined $cond and length $cond) {
+ $f_key = $cond;
+ $guess = "caller specified foreign key '$f_key'";
+ }
+ else {
+ $f_key = $rel;
+ $guess = "using given relationship name '$rel' as foreign key column name";
+ }
- my $fk = defined $cond ? $cond : $rel;
$class->throw_exception(
- "Can't infer join condition for '$rel' on ${class}: "
- . "'$fk' is not a column of $class"
- ) unless $class->has_column($fk);
+ "No such column '$f_key' declared yet on ${class} ($guess)"
+ ) unless $class->has_column($f_key);
+
+ $class->ensure_class_loaded($f_class);
+ my $f_rsrc = try {
+ $f_class->result_source_instance;
+ }
+ catch {
+ $class->throw_exception(
+ "Foreign class '$f_class' does not seem to be a Result class "
+ . "(or it simply did not load entirely due to a circular relation chain)"
+ );
+ };
- $cond = { "foreign.${pri}" => "self.${fk}" };
+ my $pri = $f_rsrc->_single_pri_col_or_die;
+
+ $cond = { "foreign.${pri}" => "self.${f_key}" };
}
# explicit join condition
- elsif (ref $cond) {
+ else {
if (ref $cond eq 'HASH') { # ARRAY is also valid
my $cond_rel;
+ # FIXME This loop is ridiculously incomplete and dangerous
+ # staving off changes until implmentation of the swindon consensus
for (keys %$cond) {
if (m/\./) { # Explicit join condition
$cond_rel = $cond;
$cond = $cond_rel;
}
}
- # dunno
- else {
- $class->throw_exception(
- 'third argument for belongs_to must be undef, a column name, '.
- 'or a join condition'
- );
- }
my $acc_type = (
ref $cond eq 'HASH'
$class->add_relationship($rel, $f_class,
$cond,
{
+ is_depends_on => 1,
accessor => $acc_type,
$fk_columns ? ( fk_columns => $fk_columns ) : (),
%{$attrs || {}}
return 1;
}
-# Attempt to remove the POD so it (maybe) falls off the indexer
-
-#=head1 AUTHORS
-#
-#Alexander Hartmaier <Alexander.Hartmaier@t-systems.at>
-#
-#Matt S. Trout <mst@shadowcatsystems.co.uk>
-#
-#=cut
-
1;