use strict;
use warnings;
use base qw/DBIx::Class/;
-use Carp::Clan qw/^DBIx::Class/;
+use DBIx::Class::Carp;
+use DBIx::Class::_Util 'dbic_internal_try';
use Try::Tiny;
use namespace::clean;
a C<datetime> field the methods C<parse_datetime> and C<format_datetime>
would be called on deflation/inflation. If the storage class does not
provide a specialized inflator/deflator, C<[parse|format]_datetime> will
-be used as a fallback. See L<DateTime::Format> for more information on
-date formatting.
+be used as a fallback. See L<DateTime/Formatters And Stringification>
+for more information on date formatting.
For more help with using components, see L<DBIx::Class::Manual::Component/USING>.
sub register_column {
my ($self, $column, $info, @rest) = @_;
- $self->next::method($column, $info, @rest);
- return unless defined($info->{data_type});
- my $type;
+ $self->next::method($column, $info, @rest);
- for (qw/date datetime timestamp/) {
+ my $requested_type;
+ for (qw/datetime timestamp date/) {
my $key = "inflate_${_}";
+ if (exists $info->{$key}) {
- next unless exists $info->{$key};
- return unless $info->{$key};
+ # this bailout is intentional
+ return unless $info->{$key};
- $type = $_;
- last;
+ $requested_type = $_;
+ last;
+ }
}
- unless ($type) {
- $type = lc($info->{data_type});
- if ($type eq "timestamp with time zone" || $type eq "timestamptz") {
- $type = "timestamp";
- $info->{_ic_dt_method} ||= "timestamp_with_timezone";
- } elsif ($type eq "timestamp without time zone") {
- $type = "timestamp";
- $info->{_ic_dt_method} ||= "timestamp_without_timezone";
- } elsif ($type eq "smalldatetime") {
- $type = "datetime";
- $info->{_ic_dt_method} ||= "smalldatetime";
- }
+ return if (!$requested_type and !$info->{data_type});
+
+ my $data_type = lc( $info->{data_type} || '' );
+
+ # _ic_dt_method will follow whatever the registration requests
+ # thus = instead of ||=
+ if ($data_type eq 'timestamp with time zone' || $data_type eq 'timestamptz') {
+ $info->{_ic_dt_method} = 'timestamp_with_timezone';
+ }
+ elsif ($data_type eq 'timestamp without time zone') {
+ $info->{_ic_dt_method} = 'timestamp_without_timezone';
+ }
+ elsif ($data_type eq 'smalldatetime') {
+ $info->{_ic_dt_method} = 'smalldatetime';
+ }
+ elsif ($data_type =~ /^ (?: date | datetime | timestamp ) $/x) {
+ $info->{_ic_dt_method} = $data_type;
+ }
+ elsif ($requested_type) {
+ $info->{_ic_dt_method} = $requested_type;
+ }
+ else {
+ return;
}
if ($info->{extra}) {
- if ( defined $info->{extra}{timezone} ) {
- carp "Putting timezone into extra => { timezone => '...' } has been deprecated, ".
- "please put it directly into the '$column' column definition.";
- $info->{timezone} = $info->{extra}{timezone} unless defined $info->{timezone};
- }
-
- if ( defined $info->{extra}{locale} ) {
- carp "Putting locale into extra => { locale => '...' } has been deprecated, ".
- "please put it directly into the '$column' column definition.";
- $info->{locale} = $info->{extra}{locale} unless defined $info->{locale};
+ for my $slot (qw/timezone locale floating_tz_ok/) {
+ if ( defined $info->{extra}{$slot} ) {
+ carp "Putting $slot into extra => { $slot => '...' } has been deprecated, ".
+ "please put it directly into the '$column' column definition.";
+ $info->{$slot} = $info->{extra}{$slot} unless defined $info->{$slot};
+ }
}
}
- my $undef_if_invalid = $info->{datetime_undef_if_invalid};
+ # shallow copy to avoid unfounded(?) Devel::Cycle complaints
+ my $infcopy = {%$info};
- if ($type eq 'datetime' || $type eq 'date' || $type eq 'timestamp') {
- # This shallow copy of %info avoids t/52_cycle.t treating
- # the resulting deflator as a circular reference.
- my %info = ( '_ic_dt_method' => $type , %{ $info } );
+ $self->inflate_column(
+ $column =>
+ {
+ inflate => sub {
+ my ($value, $obj) = @_;
- if (defined $info->{extra}{floating_tz_ok}) {
- carp "Putting floating_tz_ok into extra => { floating_tz_ok => 1 } has been deprecated, ".
- "please put it directly into the '$column' column definition.";
- $info{floating_tz_ok} = $info->{extra}{floating_tz_ok};
- }
+ # propagate for error reporting
+ $infcopy->{__dbic_colname} = $column;
- $self->inflate_column(
- $column =>
- {
- inflate => sub {
- my ($value, $obj) = @_;
-
- my $dt = try
- { $obj->_inflate_to_datetime( $value, \%info ) }
- catch {
- $self->throw_exception ("Error while inflating ${value} for ${column} on ${self}: $_")
- unless $undef_if_invalid;
- undef; # rv
- };
-
- return (defined $dt)
- ? $obj->_post_inflate_datetime( $dt, \%info )
- : undef
- ;
- },
- deflate => sub {
- my ($value, $obj) = @_;
-
- $value = $obj->_pre_deflate_datetime( $value, \%info );
- $obj->_deflate_from_datetime( $value, \%info );
- },
- }
- );
- }
+ my $dt = $obj->_inflate_to_datetime( $value, $infcopy );
+
+ return (defined $dt)
+ ? $obj->_post_inflate_datetime( $dt, $infcopy )
+ : undef
+ ;
+ },
+ deflate => sub {
+ my ($value, $obj) = @_;
+
+ $value = $obj->_pre_deflate_datetime( $value, $infcopy );
+ $obj->_deflate_from_datetime( $value, $infcopy );
+ },
+ }
+ );
}
sub _flate_or_fallback
my $parser = $self->_datetime_parser;
my $preferred_method = sprintf($method_fmt, $info->{ _ic_dt_method });
- my $method = $parser->can($preferred_method) ? $preferred_method : sprintf($method_fmt, 'datetime');
- return $parser->$method($value);
+ my $method = $parser->can($preferred_method) || sprintf($method_fmt, 'datetime');
+
+ return dbic_internal_try {
+ $parser->$method($value);
+ }
+ catch {
+ $self->throw_exception ("Error while inflating '$value' for $info->{__dbic_colname} on ${self}: $_")
+ unless $info->{datetime_undef_if_invalid};
+ undef; # rv
+ };
}
sub _inflate_to_datetime {
can be found in the documentation for L<DBIx::Class::ResultSource>.
=item Further discussion of problems inherent to the Floating timezone:
- L<Floating DateTimes|DateTime/Floating_DateTimes>
+ L<Floating DateTimes|DateTime/Floating DateTimes>
and L<< $dt->set_time_zone|DateTime/"Set" Methods >>
=back
-=head1 AUTHOR
-
-Matt S. Trout <mst@shadowcatsystems.co.uk>
-
-=head1 CONTRIBUTORS
-
-Aran Deltac <bluefeet@cpan.org>
+=head1 FURTHER QUESTIONS?
-=head1 LICENSE
+Check the list of L<additional DBIC resources|DBIx::Class/GETTING HELP/SUPPORT>.
-You may distribute this code under the same terms as Perl itself.
+=head1 COPYRIGHT AND LICENSE
+This module is free software L<copyright|DBIx::Class/COPYRIGHT AND LICENSE>
+by the L<DBIx::Class (DBIC) authors|DBIx::Class/AUTHORS>. You can
+redistribute it and/or modify it under the same terms as the
+L<DBIx::Class library|DBIx::Class/COPYRIGHT AND LICENSE>.