Cleanup dependencies / Admin inheritance

[dbsrgits/DBIx-Class-Historic.git] / lib / DBIx / Class / Admin.pm

diff --git a/lib/DBIx/Class/Admin.pm b/lib/DBIx/Class/Admin.pm
index 8814bf7..b8343f1 100644 (file)
--- a/lib/DBIx/Class/Admin.pm
+++ b/lib/DBIx/Class/Admin.pm
@@ -2,29 +2,13 @@ package DBIx::Class::Admin;
 
 # check deps
 BEGIN {
-    my @_deps = qw(
-        Moose MooseX::Types MooseX::Types::JSON MooseX::Types::Path::Class
-        Try::Tiny parent JSON::Any Class::C3::Componentised
-        namespace::autoclean
-    );
-
-    my @_missing_deps;
-    foreach my $dep (@_deps) {
-      eval "require $dep";
-      if ($@) {
-        push @_missing_deps, $dep;
-      }
-    }
-
-    if (@_missing_deps > 0) {
-      die "The following dependecies are missing " . join ",", @_missing_deps;
-    }
+  use Carp::Clan qw/^DBIx::Class/;
+  use DBIx::Class;
+  croak('The following modules are required for DBIx::Class::Admin ' . DBIx::Class::Optional::Dependencies->req_missing_for ('admin') )
+    unless DBIx::Class::Optional::Dependencies->req_ok_for ('admin');
 }
 
 use Moose;
-use parent 'DBIx::Class::Schema';
-use Carp::Clan qw/^DBIx::Class/;
-
 use MooseX::Types::Moose qw/Int Str Any Bool/;
 use DBIx::Class::Admin::Types qw/DBICConnectInfo DBICHashRef/;
 use MooseX::Types::JSON qw(JSON);
@@ -72,31 +56,10 @@ DBIx::Class::Admin - Administration object for schemas
 
 =head1 REQUIREMENTS
 
-The following CPAN modules are required to use C<dbicadmin> and this module:
-
-L<Moose>
-
-L<MooseX::Types>
-
-L<MooseX::Types::JSON>
-
-L<MooseX::Types::Path::Class>
-
-L<Try::Tiny>
-
-L<parent>
-
-L<JSON::Any>
-
-(L<JSON::DWIW> preferred for barekey support)
-
-L<namespace::autoclean>
-
-L<Getopt::Long::Descriptive>
-
-L<Text::CSV>
+The Admin interface has additional requirements not currently part of
+L<DBIx::Class>. See L<DBIx::Class::Optional::Dependencies> for more details.
 
-=head1 Attributes
+=head1 ATTRIBUTES
 
 =head2 schema_class
 
@@ -124,7 +87,8 @@ has 'schema' => (
 
 sub _build_schema {
   my ($self)  = @_;
-  $self->ensure_class_loaded($self->schema_class);
+  require Class::C3::Componentised;
+  Class::C3::Componentised->ensure_class_loaded($self->schema_class);
 
   $self->connect_info->[3]->{ignore_version} =1;
   return $self->schema_class->connect(@{$self->connect_info()} ); # ,  $self->connect_info->[3], { ignore_version => 1} );
@@ -246,7 +210,7 @@ sub _build_config {
   my ($self) = @_;
 
   eval { require Config::Any }
-    or $self->throw_exception( "Config::Any is required to parse the config file");
+    or die ("Config::Any is required to parse the config file.\n");
 
   my $cfg = Config::Any->load_files ( {files => [$self->config_file], use_ext =>1, flatten_to_hash=>1});
 
@@ -372,7 +336,7 @@ sub upgrade {
   my $schema = $self->schema();
   if (!$schema->get_db_version()) {
     # schema is unversioned
-    $self->throw_exception ("could not determin current schema version, please either install or deploy");
+    $schema->throw_exception ("Could not determin current schema version, please either install() or deploy().\n");
   } else {
     my $ret = $schema->upgrade();
     return $ret;
@@ -413,7 +377,7 @@ sub install {
     }
   }
   else {
-    $self->throw_exception ("schema already has a version not installing, try upgrade instead");
+    $schema->throw_exception ("Schema already has a version. Try upgrade instead.\n");
   }
 
 }
@@ -438,9 +402,9 @@ sub deploy {
   if (!$schema->get_db_version() ) {
     # schema is unversioned
     $schema->deploy( $args, $self->sql_dir)
-      or $self->throw_exception ("could not deploy schema");
+      or $schema->throw_exception ("Could not deploy schema.\n"); # FIXME deploy() does not return 1/0 on success/fail
   } else {
-    $self->throw_exception("there already is a database with a version here, try upgrade instead");
+    $schema->throw_exception("A versioned schema has already been deployed, try upgrade instead.\n");
   }
 }
 
@@ -585,7 +549,7 @@ sub _find_stanza {
       $cfg = $cfg->{$path};
     }
     else {
-      $self->throw_exception("could not find $stanza in config, $path did not seem to exist");
+      die ("Could not find $stanza in config, $path does not seem to exist.\n");
     }
   }
   return $cfg;