use Carp 'confess';
use Sub::Name 'subname';
-our $VERSION = '0.92_01';
+our $VERSION = '0.96';
$VERSION = eval $VERSION;
our $AUTHORITY = 'cpan:STEVAN';
'package' => $package_name,
%options,
});
-
Class::MOP::store_metaclass_by_name($package_name, $meta);
return $meta;
sub method_metaclass { $_[0]->{'method_metaclass'} }
sub wrapped_method_metaclass { $_[0]->{'wrapped_method_metaclass'} }
-sub _method_map { $_[0]->{'methods'} }
+# This doesn't always get initialized in a constructor because there is a
+# weird object construction path for subclasses of Class::MOP::Class. At one
+# point, this always got initialized by calling into the XS code first, but
+# that is no longer guaranteed to happen.
+sub _method_map { $_[0]->{'methods'} ||= {} }
# utility methods
sub add_method {
my ($self, $method_name, $method) = @_;
- (defined $method_name && $method_name)
+ (defined $method_name && length $method_name)
|| confess "You must define a method name";
my $body;
if ($method->package_name ne $self->name) {
$method = $method->clone(
package_name => $self->name,
- name => $method_name
+ name => $method_name,
) if $method->can('clone');
}
my ( $current_package, $current_name ) = Class::MOP::get_code_info($body);
- if ( !defined $current_name || $current_name eq '__ANON__' ) {
+ if ( !defined $current_name || $current_name =~ /^__ANON__/ ) {
my $full_method_name = ($self->name . '::' . $method_name);
subname($full_method_name => $body);
}
sub has_method {
my ($self, $method_name) = @_;
- (defined $method_name && $method_name)
+
+ (defined $method_name && length $method_name)
|| confess "You must define a method name";
return defined($self->get_method($method_name));
sub get_method {
my ( $self, $method_name ) = @_;
- ( defined $method_name && $method_name )
+
+ (defined $method_name && length $method_name)
|| confess "You must define a method name";
my $method_map = $self->_method_map;
}
);
- return $map_entry if blessed $map_entry && $map_entry->body == $code;
+ # This seems to happen in some weird cases where methods modifiers are
+ # added via roles or some other such bizareness. Honestly, I don't totally
+ # understand this, but returning the entry works, and keeps various MX
+ # modules from blowing up. - DR
+ return $map_entry if blessed $map_entry && !$code;
- # we should never have a blessed map entry but no $code in the package
- die 'WTF' if blessed $map_entry && ! $code;
+ return $map_entry if blessed $map_entry && $map_entry->body == $code;
unless ($map_entry) {
return unless $code && $self->_code_is_mine($code);
sub remove_method {
my ($self, $method_name) = @_;
- (defined $method_name && $method_name)
+ (defined $method_name && length $method_name)
|| confess "You must define a method name";
- my $removed_method = delete $self->get_method_map->{$method_name};
+ my $removed_method = delete $self->_full_method_map->{$method_name};
$self->remove_package_symbol(
{ sigil => '&', type => 'CODE', name => $method_name }
named method. It does not include methods inherited from parent
classes.
-=item B<< $metapackage->get_method_map >>
-
-Returns a hash reference representing the methods defined in this
-class. The keys are method names and the values are
-L<Class::MOP::Method> objects.
-
=item B<< $metapackage->get_method_list >>
This will return a list of method I<names> for all methods defined in