Merge branch 'stable'

[gitmo/Class-MOP.git] / lib / Class / MOP / Module.pm

diff --git a/lib/Class/MOP/Module.pm b/lib/Class/MOP/Module.pm
index 33eb10a..f8d22b2 100644 (file)
--- a/lib/Class/MOP/Module.pm
+++ b/lib/Class/MOP/Module.pm
@@ -7,20 +7,38 @@ use warnings;
 use Carp         'confess';
 use Scalar::Util 'blessed';
 
-our $VERSION   = '0.77';
+our $VERSION   = '1.12';
 $VERSION = eval $VERSION;
 our $AUTHORITY = 'cpan:STEVAN';
 
 use base 'Class::MOP::Package';
 
+sub _new {
+    my $class = shift;
+    return Class::MOP::Class->initialize($class)->new_object(@_)
+        if $class ne __PACKAGE__;
+
+    my $params = @_ == 1 ? $_[0] : {@_};
+    return bless {
+
+        # from Class::MOP::Package
+        package   => $params->{package},
+        namespace => \undef,
+
+        # attributes
+        version   => \undef,
+        authority => \undef
+    } => $class;
+}
+
 sub version {  
     my $self = shift;
-    ${$self->get_package_symbol({ sigil => '$', type => 'SCALAR', name => 'VERSION' })};
+    ${$self->get_or_add_package_symbol('$VERSION')};
 }
 
 sub authority {  
     my $self = shift;
-    ${$self->get_package_symbol({ sigil => '$', type => 'SCALAR', name => 'AUTHORITY' })};
+    ${$self->get_or_add_package_symbol('$AUTHORITY')};
 }
 
 sub identifier {
@@ -33,23 +51,22 @@ sub identifier {
 }
 
 sub create {
-    my ( $class, %options ) = @_;
-
-    my $package_name = $options{package};
+    confess "The Class::MOP::Module->create method has been made a private object method.\n";
+}
 
-    (defined $package_name && $package_name)
-        || confess "You must pass a package name";
+sub _instantiate_module {
+    my($self, $version, $authority) = @_;
+    my $package_name = $self->name;
 
-    my $code = "package $package_name;";
-    $code .= "\$$package_name\:\:VERSION = '" . $options{version} . "';"
-        if exists $options{version};
-    $code .= "\$$package_name\:\:AUTHORITY = '" . $options{authority} . "';"
-        if exists $options{authority};
+    Class::MOP::_is_valid_class_name($package_name)
+        || confess "creation of $package_name failed: invalid package name";
 
-    eval $code;
-    confess "creation of $package_name failed : $@" if $@;
+    no strict 'refs';
+    scalar %{ $package_name . '::' };    # touch the stash
+    ${ $package_name . '::VERSION' }   = $version   if defined $version;
+    ${ $package_name . '::AUTHORITY' } = $authority if defined $authority;
 
-    return; # XXX: should this return some kind of meta object? ~sartak
+    return;
 }
 
 1;
@@ -64,44 +81,35 @@ Class::MOP::Module - Module Meta Object
 
 =head1 DESCRIPTION
 
-This is an abstraction of a Perl 5 module, it is a superclass of
-L<Class::MOP::Class>. A module essentially a package with metadata, 
-in our case the version and authority. 
+A module is essentially a L<Class::MOP::Package> with metadata, in our
+case the version and authority.
 
 =head1 INHERITANCE
 
-B<Class::MOP::Module> is a subclass of L<Class::MOP::Package>
+B<Class::MOP::Module> is a subclass of L<Class::MOP::Package>.
 
 =head1 METHODS
 
 =over 4
 
-=item B<meta>
-
-Returns a metaclass for this package.
-
-=item B<initialize ($package_name)>
-
-This will initialize a Class::MOP::Module instance which represents 
-the module of C<$package_name>.
-
-=item B<version>
+=item B<< $metamodule->version >>
 
-This is a read-only attribute which returns the C<$VERSION> of the 
-package for the given instance.
+This is a read-only attribute which returns the C<$VERSION> of the
+package, if one exists.
 
-=item B<authority>
+=item B<< $metamodule->authority >>
 
-This is a read-only attribute which returns the C<$AUTHORITY> of the 
-package for the given instance.
+This is a read-only attribute which returns the C<$AUTHORITY> of the
+package, if one exists.
 
-=item B<identifier>
+=item B<< $metamodule->identifier >>
 
-This constructs a string of the name, version and authority.
+This constructs a string which combines the name, version and
+authority.
 
-=item B<create>
+=item B<< Class::MOP::Module->meta >>
 
-This creates the module; it does not return a useful result.
+This will return a L<Class::MOP::Class> instance for this class.
 
 =back
 
@@ -111,7 +119,7 @@ Stevan Little E<lt>stevan@iinteractive.comE<gt>
 
 =head1 COPYRIGHT AND LICENSE
 
-Copyright 2006-2008 by Infinity Interactive, Inc.
+Copyright 2006-2010 by Infinity Interactive, Inc.
 
 L<http://www.iinteractive.com>