Constants _should_ be reported as methods.

[gitmo/Class-MOP.git] / lib / Class / MOP / Mixin / HasMethods.pm

diff --git a/lib/Class/MOP/Mixin/HasMethods.pm b/lib/Class/MOP/Mixin/HasMethods.pm
index b8ea9ff..bd61c2b 100644 (file)
--- a/lib/Class/MOP/Mixin/HasMethods.pm
+++ b/lib/Class/MOP/Mixin/HasMethods.pm
@@ -3,7 +3,7 @@ package Class::MOP::Mixin::HasMethods;
 use strict;
 use warnings;
 
-our $VERSION   = '1.04';
+our $VERSION   = '1.05';
 $VERSION = eval $VERSION;
 our $AUTHORITY = 'cpan:STEVAN';
 
@@ -89,7 +89,7 @@ sub has_method {
     ( defined $method_name && length $method_name )
         || confess "You must define a method name";
 
-    return defined( $self->get_method($method_name) );
+    return defined( $self->_get_maybe_raw_method($method_name) );
 }
 
 sub get_method {
@@ -98,6 +98,21 @@ sub get_method {
     ( defined $method_name && length $method_name )
         || confess "You must define a method name";
 
+    my $method = $self->_get_maybe_raw_method($method_name)
+        or return;
+
+    return $method if blessed $method;
+
+    return $self->_method_map->{$method_name} = $self->wrap_method_body(
+        body                 => $method,
+        name                 => $method_name,
+        associated_metaclass => $self,
+    );
+}
+
+sub _get_maybe_raw_method {
+    my ( $self, $method_name ) = @_;
+
     my $method_map = $self->_method_map;
     my $map_entry  = $method_map->{$method_name};
     my $code       = $self->get_package_symbol(
@@ -119,13 +134,7 @@ sub get_method {
         return unless $code && $self->_code_is_mine($code);
     }
 
-    $code ||= $map_entry;
-
-    return $method_map->{$method_name} = $self->wrap_method_body(
-        body                 => $code,
-        name                 => $method_name,
-        associated_metaclass => $self,
-    );
+    return $code;
 }
 
 sub remove_method {
@@ -152,7 +161,12 @@ sub get_method_list {
 
     my $namespace = $self->namespace;
 
-    return grep { *{ $namespace->{$_} }{CODE} && $self->has_method($_) }
+    # Constants will show up as some sort of reference in the namespace hash
+    # ref.
+    return grep {
+        ( ref $namespace->{$_} || *{ $namespace->{$_} }{CODE} )
+            && $self->has_method($_)
+        }
         keys %{$namespace};
 }
 
@@ -164,7 +178,8 @@ sub _get_local_methods {
 
     my $namespace = $self->namespace;
 
-    return map { $self->get_method($_) } grep { *{ $namespace->{$_} }{CODE} }
+    return map { $self->get_method($_) }
+        grep { ref $namespace->{$_} || *{ $namespace->{$_} }{CODE} }
         keys %{$namespace};
 }