cleaning up Changes and docs

[gitmo/Class-MOP.git] / lib / Class / MOP / Method.pm

diff --git a/lib/Class/MOP/Method.pm b/lib/Class/MOP/Method.pm
index 4aefe2d..06123a6 100644 (file)
--- a/lib/Class/MOP/Method.pm
+++ b/lib/Class/MOP/Method.pm
@@ -8,11 +8,15 @@ use Carp         'confess';
 use Scalar::Util 'reftype', 'blessed';
 use B            'svref_2object';
 
-our $VERSION   = '0.03';
+our $VERSION   = '0.04';
 our $AUTHORITY = 'cpan:STEVAN';
 
-use overload '&{}' => sub { $_[0]->{body} },
-             fallback => 1;
+use base 'Class::MOP::Object';
+
+# NOTE:
+# if poked in the right way, 
+# they should act like CODE refs.
+use overload '&{}' => sub { $_[0]->{body} }, fallback => 1;
 
 # introspection
 
@@ -33,28 +37,36 @@ sub wrap {
     } => blessed($class) || $class;
 }
 
+## accessors
+
 sub body { (shift)->{body} }
 
+# TODO - add associated_class
+
 # informational
 
+# NOTE: 
+# this may not be the same name 
+# as the class you got it from
+# This gets the package stash name 
+# associated with the actual CODE-ref
 sub package_name { 
-       my $code = shift->{body};
-#      (blessed($code))
-#              || confess "Can only ask the package name of a blessed CODE";
+       my $code = (shift)->{body};
        svref_2object($code)->GV->STASH->NAME;
 }
 
+# NOTE: 
+# this may not be the same name 
+# as the method name it is stored
+# with. This gets the name associated
+# with the actual CODE-ref
 sub name { 
-       my $code = shift->{body};
-#      (blessed($code))
-#              || confess "Can only ask the package name of a blessed CODE";   
+       my $code = (shift)->{body};
        svref_2object($code)->GV->NAME;
 }
 
 sub fully_qualified_name {
        my $code = shift;
-#      (blessed($code))
-#              || confess "Can only ask the package name of a blessed CODE";
        $code->package_name . '::' . $code->name;               
 }
 
@@ -67,7 +79,8 @@ use Carp         'confess';
 use Scalar::Util 'reftype', 'blessed';
 use Sub::Name    'subname';
 
-our $VERSION = '0.01';
+our $VERSION   = '0.02';
+our $AUTHORITY = 'cpan:STEVAN';
 
 use base 'Class::MOP::Method'; 
 
@@ -155,12 +168,6 @@ sub get_original_method {
 sub add_before_modifier {
        my $code     = shift;
        my $modifier = shift;
-       #(exists $MODIFIERS{$code})
-       #       || confess "You must first wrap your method before adding a modifier";          
-       (blessed($code))
-               || confess "Can only ask the package name of a blessed CODE";
-       #('CODE' eq (reftype($code) || ''))
-    #    || confess "You must supply a CODE reference for a modifier";                 
        unshift @{$code->{modifier_table}->{before}} => $modifier;
        $_build_wrapped_method->($code->{modifier_table});
 }
@@ -168,12 +175,6 @@ sub add_before_modifier {
 sub add_after_modifier {
        my $code     = shift;
        my $modifier = shift;
-       #(exists $MODIFIERS{$code})
-       #       || confess "You must first wrap your method before adding a modifier";          
-       (blessed($code))
-               || confess "Can only ask the package name of a blessed CODE";
-    #('CODE' eq (reftype($code) || ''))
-    #    || confess "You must supply a CODE reference for a modifier";                 
        push @{$code->{modifier_table}->{after}} => $modifier;
        $_build_wrapped_method->($code->{modifier_table});      
 }
@@ -196,12 +197,6 @@ sub add_after_modifier {
        sub add_around_modifier {
                my $code     = shift;
                my $modifier = shift;
-               #(exists $MODIFIERS{$code})
-               #       || confess "You must first wrap your method before adding a modifier";          
-               (blessed($code))
-                       || confess "Can only ask the package name of a blessed CODE";
-           #('CODE' eq (reftype($code) || ''))
-           #    || confess "You must supply a CODE reference for a modifier";                  
                unshift @{$code->{modifier_table}->{around}->{methods}} => $modifier;           
                $code->{modifier_table}->{around}->{cache} = $compile_around_method->(
                        @{$code->{modifier_table}->{around}->{methods}},
@@ -228,12 +223,11 @@ Class::MOP::Method - Method Meta Object
 =head1 DESCRIPTION
 
 The Method Protocol is very small, since methods in Perl 5 are just 
-subroutines within the particular package. Basically all we do is to 
-bless the subroutine. 
+subroutines within the particular package. We provide a very basic 
+introspection interface.
 
-Currently this package is largely unused. Future plans are to provide 
-some very simple introspection methods for the methods themselves. 
-Suggestions for this are welcome. 
+This also contains the Class::MOP::Method::Wrapped subclass, which 
+provides the features for before, after and around method modifiers.
 
 =head1 METHODS
 
@@ -254,8 +248,6 @@ to this class.
 
 =item B<wrap (&code)>
 
-This simply blesses the C<&code> reference passed to it.
-
 =back
 
 =head2 Informational
@@ -280,8 +272,6 @@ This simply blesses the C<&code> reference passed to it.
 
 =item B<wrap (&code)>
 
-This simply blesses the C<&code> reference passed to it.
-
 =item B<get_original_method>
 
 =back