use Scalar::Util 'reftype', 'blessed';
use B 'svref_2object';
-our $VERSION = '0.02';
+our $VERSION = '0.04';
+our $AUTHORITY = 'cpan:STEVAN';
+
+use base 'Class::MOP::Object';
+
+# NOTE:
+# if poked in the right way,
+# they should act like CODE refs.
+use overload '&{}' => sub { $_[0]->{body} }, fallback => 1;
# introspection
my $class = shift;
my $code = shift;
('CODE' eq (reftype($code) || ''))
- || confess "You must supply a CODE reference to bless";
- bless $code => blessed($class) || $class;
+ || confess "You must supply a CODE reference to bless, not (" . ($code || 'undef') . ")";
+ bless {
+ body => $code
+ } => blessed($class) || $class;
}
+## accessors
+
+sub body { (shift)->{body} }
+
+# TODO - add associated_class
+
# informational
+# NOTE:
+# this may not be the same name
+# as the class you got it from
+# This gets the package stash name
+# associated with the actual CODE-ref
sub package_name {
- my $code = shift;
- (blessed($code))
- || confess "Can only ask the package name of a blessed CODE";
+ my $code = (shift)->{body};
svref_2object($code)->GV->STASH->NAME;
}
+# NOTE:
+# this may not be the same name
+# as the method name it is stored
+# with. This gets the name associated
+# with the actual CODE-ref
sub name {
- my $code = shift;
- (blessed($code))
- || confess "Can only ask the package name of a blessed CODE";
+ my $code = (shift)->{body};
svref_2object($code)->GV->NAME;
}
+sub fully_qualified_name {
+ my $code = shift;
+ $code->package_name . '::' . $code->name;
+}
+
package Class::MOP::Method::Wrapped;
use strict;
use Carp 'confess';
use Scalar::Util 'reftype', 'blessed';
-
-our $VERSION = '0.01';
-
-our @ISA = ('Class::MOP::Method');
-
-my %MODIFIERS;
+use Sub::Name 'subname';
+
+our $VERSION = '0.02';
+our $AUTHORITY = 'cpan:STEVAN';
+
+use base 'Class::MOP::Method';
+
+# NOTE:
+# this ugly beast is the result of trying
+# to micro optimize this as much as possible
+# while not completely loosing maintainability.
+# At this point it's "fast enough", after all
+# you can't get something for nothing :)
+my $_build_wrapped_method = sub {
+ my $modifier_table = shift;
+ my ($before, $after, $around) = (
+ $modifier_table->{before},
+ $modifier_table->{after},
+ $modifier_table->{around},
+ );
+ if (@$before && @$after) {
+ $modifier_table->{cache} = sub {
+ $_->(@_) for @{$before};
+ my @rval;
+ ((defined wantarray) ?
+ ((wantarray) ?
+ (@rval = $around->{cache}->(@_))
+ :
+ ($rval[0] = $around->{cache}->(@_)))
+ :
+ $around->{cache}->(@_));
+ $_->(@_) for @{$after};
+ return unless defined wantarray;
+ return wantarray ? @rval : $rval[0];
+ }
+ }
+ elsif (@$before && !@$after) {
+ $modifier_table->{cache} = sub {
+ $_->(@_) for @{$before};
+ return $around->{cache}->(@_);
+ }
+ }
+ elsif (@$after && !@$before) {
+ $modifier_table->{cache} = sub {
+ my @rval;
+ ((defined wantarray) ?
+ ((wantarray) ?
+ (@rval = $around->{cache}->(@_))
+ :
+ ($rval[0] = $around->{cache}->(@_)))
+ :
+ $around->{cache}->(@_));
+ $_->(@_) for @{$after};
+ return unless defined wantarray;
+ return wantarray ? @rval : $rval[0];
+ }
+ }
+ else {
+ $modifier_table->{cache} = $around->{cache};
+ }
+};
sub wrap {
my $class = shift;
my $code = shift;
(blessed($code) && $code->isa('Class::MOP::Method'))
- || confess "Can only wrap blessed CODE";
+ || confess "Can only wrap blessed CODE";
my $modifier_table = {
+ cache => undef,
orig => $code,
before => [],
after => [],
around => {
- cache => $code,
- methods => [],
+ cache => $code->body,
+ methods => [],
},
};
- my $method = $class->SUPER::wrap(sub {
- $_->(@_) for @{$modifier_table->{before}};
- my (@rlist, $rval);
- if (defined wantarray) {
- if (wantarray) {
- @rlist = $modifier_table->{around}->{cache}->(@_);
- }
- else {
- $rval = $modifier_table->{around}->{cache}->(@_);
- }
- }
- else {
- $modifier_table->{around}->{cache}->(@_);
- }
- $_->(@_) for @{$modifier_table->{after}};
- return unless defined wantarray;
- return wantarray ? @rlist : $rval;
- });
- $MODIFIERS{$method} = $modifier_table;
+ $_build_wrapped_method->($modifier_table);
+ my $method = $class->SUPER::wrap(sub { $modifier_table->{cache}->(@_) });
+ $method->{modifier_table} = $modifier_table;
$method;
}
+sub get_original_method {
+ my $code = shift;
+ $code->{modifier_table}->{orig};
+}
+
sub add_before_modifier {
my $code = shift;
my $modifier = shift;
- (exists $MODIFIERS{$code})
- || confess "You must first wrap your method before adding a modifier";
- (blessed($code))
- || confess "Can only ask the package name of a blessed CODE";
- ('CODE' eq (reftype($code) || ''))
- || confess "You must supply a CODE reference for a modifier";
- unshift @{$MODIFIERS{$code}->{before}} => $modifier;
+ unshift @{$code->{modifier_table}->{before}} => $modifier;
+ $_build_wrapped_method->($code->{modifier_table});
}
sub add_after_modifier {
my $code = shift;
my $modifier = shift;
- (exists $MODIFIERS{$code})
- || confess "You must first wrap your method before adding a modifier";
- (blessed($code))
- || confess "Can only ask the package name of a blessed CODE";
- ('CODE' eq (reftype($code) || ''))
- || confess "You must supply a CODE reference for a modifier";
- push @{$MODIFIERS{$code}->{after}} => $modifier;
+ push @{$code->{modifier_table}->{after}} => $modifier;
+ $_build_wrapped_method->($code->{modifier_table});
}
{
+ # NOTE:
+ # this is another possible canidate for
+ # optimization as well. There is an overhead
+ # associated with the currying that, if
+ # eliminated might make around modifiers
+ # more manageable.
my $compile_around_method = sub {{
my $f1 = pop;
return $f1 unless @_;
sub add_around_modifier {
my $code = shift;
my $modifier = shift;
- (exists $MODIFIERS{$code})
- || confess "You must first wrap your method before adding a modifier";
- (blessed($code))
- || confess "Can only ask the package name of a blessed CODE";
- ('CODE' eq (reftype($code) || ''))
- || confess "You must supply a CODE reference for a modifier";
- unshift @{$MODIFIERS{$code}->{around}->{methods}} => $modifier;
- $MODIFIERS{$code}->{around}->{cache} = $compile_around_method->(
- @{$MODIFIERS{$code}->{around}->{methods}},
- $MODIFIERS{$code}->{orig}
+ unshift @{$code->{modifier_table}->{around}->{methods}} => $modifier;
+ $code->{modifier_table}->{around}->{cache} = $compile_around_method->(
+ @{$code->{modifier_table}->{around}->{methods}},
+ $code->{modifier_table}->{orig}->body
);
+ $_build_wrapped_method->($code->{modifier_table});
}
}
This simply blesses the C<&code> reference passed to it.
-=item B<wrap>
-
-This wraps an existing method so that it can handle method modifiers.
-
=back
=head2 Informational
=over 4
+=item B<body>
+
=item B<name>
=item B<package_name>
+=item B<fully_qualified_name>
+
+=back
+
+=head1 Class::MOP::Method::Wrapped METHODS
+
+=head2 Construction
+
+=over 4
+
+=item B<wrap (&code)>
+
+This simply blesses the C<&code> reference passed to it.
+
+=item B<get_original_method>
+
=back
=head2 Modifiers
=back
-=head1 AUTHOR
+=head1 AUTHORS
Stevan Little E<lt>stevan@iinteractive.comE<gt>
+Yuval Kogman E<lt>nothingmuch@woobling.comE<gt>
+
=head1 COPYRIGHT AND LICENSE
Copyright 2006 by Infinity Interactive, Inc.
This library is free software; you can redistribute it and/or modify
it under the same terms as Perl itself.
-=cut
\ No newline at end of file
+=cut
+