use Carp 'confess';
use Scalar::Util 'blessed', 'weaken', 'looks_like_number', 'refaddr';
-our $VERSION = '0.81';
+our $VERSION = '1.11';
$VERSION = eval $VERSION;
our $AUTHORITY = 'cpan:STEVAN';
use base 'Class::MOP::Method::Generated';
-sub _expected_method_class { $_[0]{_expected_method_class} }
-
sub _uninlined_body {
my $self = shift;
- if ( my $super_method = $self->associated_metaclass->find_next_method_by_name( $self->name ) ) {
- if ( $super_method->isa(__PACKAGE__) ) {
- return $super_method->_uninlined_body;
- } else {
- return $super_method->body;
- }
- } else {
- return;
+ my $super_method
+ = $self->associated_metaclass->find_next_method_by_name( $self->name )
+ or return;
+
+ if ( $super_method->isa(__PACKAGE__) ) {
+ return $super_method->_uninlined_body;
+ }
+ else {
+ return $super_method->body;
}
}
sub can_be_inlined {
my $self = shift;
my $metaclass = $self->associated_metaclass;
- my $class = $metaclass->name;
+ my $class = $metaclass->name;
- if ( my $expected_class = $self->_expected_method_class ) {
+ # If we don't find an inherited method, this is a rather weird
+ # case where we have no method in the inheritance chain even
+ # though we're expecting one to be there
+ my $inherited_method
+ = $metaclass->find_next_method_by_name( $self->name );
- # if we are shadowing a method we first verify that it is
- # compatible with the definition we are replacing it with
- my $expected_method = $expected_class->can($self->name);
+ if ( $inherited_method
+ && $inherited_method->isa('Class::MOP::Method::Wrapped') ) {
+ warn "Not inlining '"
+ . $self->name
+ . "' for $class since it "
+ . "has method modifiers which would be lost if it were inlined\n";
- my $warning
- = "Not inlining '" . $self->name . "' for $class since it is not"
- . " inheriting the default ${expected_class}::" . $self->name . "\n"
- . "If you are certain you don't need to inline your";
+ return 0;
+ }
- if ( $self->isa("Class::MOP::Method::Constructor") ) {
- # FIXME kludge, refactor warning generation to a method
- $warning .= " constructor, specify inline_constructor => 0 in your"
- . " call to $class->meta->make_immutable\n";
- }
+ my $expected_class = $self->_expected_method_class
+ or return 1;
- if ( my $actual_method = $class->can($self->name) ) {
- if ( refaddr($expected_method) == refaddr($actual_method) ) {
- # the method is what we wanted (probably Moose::Object::new)
- return 1;
- } elsif ( my $inherited_method = $metaclass->find_next_method_by_name( $self->name ) ) {
- # otherwise we have to check that the actual method is an
- # inlined version of what we're expecting
- if ( $inherited_method->isa(__PACKAGE__) ) {
- if ( refaddr($inherited_method->_uninlined_body) == refaddr($expected_method) ) {
- return 1;
- }
- } elsif ( refaddr($inherited_method->body) == refaddr($expected_method) ) {
- return 1;
- }
-
- # FIXME we can just rewrap them =P
- $warning .= " ('" . $self->name . "' has method modifiers which would be lost if it were inlined)\n"
- if $inherited_method->isa('Class::MOP::Method::Wrapped');
- }
- } else {
- # This would be a rather weird case where we have no method
- # in the inheritance chain even though we're expecting one to be
- # there
-
- # this returns 1 for backwards compatibility for now
- return 1;
- }
+ # if we are shadowing a method we first verify that it is
+ # compatible with the definition we are replacing it with
+ my $expected_method = $expected_class->can( $self->name );
- warn $warning;
+ if ( ! $expected_method ) {
+ warn "Not inlining '"
+ . $self->name
+ . "' for $class since ${expected_class}::"
+ . $self->name
+ . " is not defined\n";
return 0;
- } else {
- # there is no expected class so we just install the constructor as a
- # new method
+ }
+
+ my $actual_method = $class->can( $self->name )
+ or return 1;
+
+ # the method is what we wanted (probably Moose::Object::new)
+ return 1
+ if refaddr($expected_method) == refaddr($actual_method);
+
+ # otherwise we have to check that the actual method is an inlined
+ # version of what we're expecting
+ if ( $inherited_method->isa(__PACKAGE__) ) {
+ if ( $inherited_method->_uninlined_body
+ && refaddr( $inherited_method->_uninlined_body )
+ == refaddr($expected_method) ) {
+ return 1;
+ }
+ }
+ elsif ( refaddr( $inherited_method->body )
+ == refaddr($expected_method) ) {
return 1;
}
+
+ my $warning
+ = "Not inlining '"
+ . $self->name
+ . "' for $class since it is not"
+ . " inheriting the default ${expected_class}::"
+ . $self->name . "\n";
+
+ if ( $self->isa("Class::MOP::Method::Constructor") ) {
+
+ # FIXME kludge, refactor warning generation to a method
+ $warning
+ .= "If you are certain you don't need to inline your"
+ . " constructor, specify inline_constructor => 0 in your"
+ . " call to $class->meta->make_immutable\n";
+ }
+
+ warn $warning;
+
+ return 0;
}
+1;
+
+__END__
+
+=pod
+
+=head1 NAME
+
+Class::MOP::Method::Inlined - Method base class for methods which have been inlined
+
+=head1 DESCRIPTION
+
+This is a L<Class::MOP::Method::Generated> subclass for methods which
+can be inlined.
+
+=head1 METHODS
+
+=over 4
+
+=item B<< $metamethod->can_be_inlined >>
+
+This method returns true if the method in question can be inlined in
+the associated metaclass.
+
+If it cannot be inlined, it spits out a warning and returns false.
+
+=back
+
+=head1 AUTHORS
+
+Stevan Little E<lt>stevan@iinteractive.comE<gt>
+
+=head1 COPYRIGHT AND LICENSE
+
+Copyright 2006-2010 by Infinity Interactive, Inc.
+
+L<http://www.iinteractive.com>
+
+This library is free software; you can redistribute it and/or modify
+it under the same terms as Perl itself.
+
+=cut
+
projects / gitmo/Class-MOP.git / blobdiff