Fix typo, bricas++, add simple test for restarter arguments

[catagits/Catalyst-Runtime.git] / lib / Catalyst / ScriptRole.pm

diff --git a/lib/Catalyst/ScriptRole.pm b/lib/Catalyst/ScriptRole.pm
index 9e67685..1cd745f 100644 (file)
--- a/lib/Catalyst/ScriptRole.pm
+++ b/lib/Catalyst/ScriptRole.pm
@@ -9,6 +9,7 @@ with 'MooseX::Getopt' => {
     excludes => [qw/
         _getopt_spec_warnings
         _getopt_spec_exception
+        _getopt_full_usage
     /],
 };
 
@@ -24,6 +25,7 @@ has help => (
     isa => Bool,
     is => 'ro',
     documentation => q{Display this help and exit},
+    cmd_aliases => ['?', 'h'],
 );
 
 sub _getopt_spec_exception {}
@@ -33,7 +35,7 @@ sub _getopt_spec_warnings {
     warn @_;
 }
 
-sub _exit_with_usage {
+sub _getopt_full_usage {
     my $self = shift;
     pod2usage();
     exit 0;
@@ -41,7 +43,7 @@ sub _exit_with_usage {
 
 before run => sub {
     my $self = shift;
-    $self->_exit_with_usage if $self->help;
+    $self->_getopt_full_usage if $self->help;
 };
 
 sub run {
@@ -60,25 +62,6 @@ sub _run_application {
     $app->run($self->_application_args);
 }
 
-# GROSS HACK, temporary until MX::Getopt gets some proper refactoring and unfucking..
-around '_parse_argv' => sub {
-    my ($orig, $self, @args) = @_;
-    my %data = eval { $self->$orig(@args) };
-    $self->_exit_with_usage($@) if $@;
-    $data{usage} = Catalyst::ScriptRole::Useage->new(code => sub { shift; $self->_exit_with_usage(@_) });
-    return %data;
-};
-
-# This package is going away.
-package # Hide from PAUSE
-    Catalyst::ScriptRole::Useage;
-use Moose;
-use namespace::autoclean;
-
-has code => ( is => 'ro', required => 1 );
-
-sub die { shift->code->(@_) }
-
 1;
 
 =head1 NAME
@@ -91,7 +74,7 @@ Catalyst::ScriptRole - Common functionality for Catalyst scripts.
     use Moose;
     use namespace::autoclean;
 
-    with 'Catalyst::Script::Role';
+    with 'Catalyst::ScriptRole';
 
      sub _application_args { ... }