cleaned up steps to create an app/component

[catagits/Catalyst-Devel.git] / lib / Catalyst / Helper.pm

diff --git a/lib/Catalyst/Helper.pm b/lib/Catalyst/Helper.pm
index 83e7c83..1bb9f97 100644 (file)
--- a/lib/Catalyst/Helper.pm
+++ b/lib/Catalyst/Helper.pm
@@ -94,32 +94,31 @@ sub mk_app {
 
     if ($gen_app) {
     
-        
-        $self->_mk_dirs;
-        $self->_mk_config;
-        $self->_mk_appclass;
-        $self->_mk_rootclass;
-        $self->_mk_readme;
-        $self->_mk_changes;
-        $self->_mk_apptest;
-        $self->_mk_images;
-        $self->_mk_favicon;
+        for ( qw/ _mk_dirs _mk_config _mk_appclass _mk_rootclass _mk_readme
+              _mk_changes _mk_apptest _mk_images _mk_favicon/ ) {
+            
+            $self->$_;
+       
+        }
     }
     if ($gen_makefile) {
         $self->_mk_makefile;
     }
     if ($gen_scripts) {
-        $self->_mk_cgi;
-        $self->_mk_fastcgi;
-        $self->_mk_server;
-        $self->_mk_dbic_deploy;
-        $self->_mk_test;
-        $self->_mk_create;
-        $self->_mk_information;
+        for ( qw/ _mk_cgi _mk_fastcgi _mk_server 
+                  _mk_test _mk_create _mk_information / ) {
+        $self->$_;
+      #  probably want to only do this if a DBIC schema is specified, or move it
+      #  to C::H::Model::DBIC::Schema
+      #  $self->_mk_dbic_deploy; 
+        
     }
     return $self->{dir};
 }
 
+
+## not much of this can really be changed, mk_compclass must be left for 
+## backcompat
 sub mk_component {
     my $self = shift;
     my $app  = shift;
@@ -190,6 +189,7 @@ sub mk_component {
                     message => qq/Couldn't load helper "$class", "$@"/ );
             }
 
+            ## must be left for back compat! ###################################
             if ( $class->can('mk_compclass') ) {
                 return 1 unless $class->mk_compclass( $self, @args );
             }
@@ -199,6 +199,7 @@ sub mk_component {
                 $class->mk_comptest( $self, @args );
             }
             else { $self->_mk_comptest }
+            ####################################################################
         }
 
         # Fallback