package Catalyst::Component;
-use Class::C3;
use Moose;
-use MooseX::Adopt::Class::Accessor::Fast;
+use Class::MOP;
+use Class::MOP::Object;
use Catalyst::Utils;
-
+use Class::C3::Adopt::NEXT;
+use MRO::Compat;
+use mro 'c3';
+use Scalar::Util qw/blessed/;
with 'MooseX::Emulate::Class::Accessor::Fast';
with 'Catalyst::ClassData';
-no Moose;
=head1 NAME
=cut
-__PACKAGE__->mk_classdata($_) for qw/_config _plugins/;
-
-sub new {
- my ( $self, $c ) = @_;
+__PACKAGE__->mk_classdata('_plugins');
+__PACKAGE__->mk_classdata('_config');
+sub BUILDARGS {
+ my ($self) = @_;
+
# Temporary fix, some components does not pass context to constructor
my $arguments = ( ref( $_[-1] ) eq 'HASH' ) ? $_[-1] : {};
my $args = $self->merge_config_hashes( $self->config, $arguments );
- $self->next::method( $args );
+
+ return $args;
}
sub COMPONENT {
# Temporary fix, some components does not pass context to constructor
my $arguments = ( ref( $_[-1] ) eq 'HASH' ) ? $_[-1] : {};
-
-
- #this is not the EXACT logic we had before, since the original tested
- #for a true value before returning meaning that a subsequent COMPONENT
- #call could return undef and that would trigger a try to new, which could
- #again return undef, which would lead to a straight bless of the args and
- #config. I did not mantain that behavior because it did not seemed sane
- # please rip me a new one if you have reason to believe i am being stupid
- # --groditi
- return $self->next::can ?
- $self->next::method($c, $arguments) : $self->new($c, $arguments);
+ if( my $next = $self->next::can ){
+ my $class = blessed $self || $self;
+ my ($next_package) = Class::MOP::get_code_info($next);
+ warn "There is a COMPONENT method resolving after Catalyst::Component in ${next_package}.\n";
+ warn "This behavior can no longer be supported, and so your application is probably broken.\n";
+ warn "Your linearised isa hierarchy is: " . join(', ', mro::get_linear_isa($class)) . "\n";
+ warn "Please see perldoc Catalyst::Upgrading for more information about this issue.\n";
+ }
+ return $self->new($c, $arguments);
}
sub config {
my $self = shift;
- my $config_sub = $self->can('_config');
- my $config = $self->$config_sub() || {};
+ my $config = $self->_config || {};
if (@_) {
my $newconfig = { %{@_ > 1 ? {@_} : $_[0]} };
$self->_config(
} else {
# this is a bit of a kludge, required to make
# __PACKAGE__->config->{foo} = 'bar';
- # work in a subclass. Calling the Class::Data::Inheritable setter
- # will create a new _config method in the current class if it's
- # currently inherited from the superclass. So, the can() call will
- # return a different subref in that case and that means we know to
- # copy and reset the value stored in the class data.
-
- $self->_config( $config );
-
- if ((my $config_sub_now = $self->can('_config')) ne $config_sub) {
+ # work in a subclass.
+ my $class = blessed($self) || $self;
+ my $meta = Class::MOP::get_metaclass_by_name($class);
+ unless ($meta->has_package_symbol('$_config')) {
$config = $self->merge_config_hashes( $config, {} );
- $self->$config_sub_now( $config );
+ $self->_config( $config );
}
}
return $config;
. " did not override Catalyst::Component::process" );
}
+no Moose;
+
+__PACKAGE__->meta->make_immutable;
1;
__END__
=head2 ACCEPT_CONTEXT($c, @args)
-Catalyst components are normally initalized during server startup, either
+Catalyst components are normally initialized during server startup, either
as a Class or a Instance. However, some components require information about
the current request. To do so, they can implement an ACCEPT_CONTEXT method.
L<Catalyst>, L<Catalyst::Model>, L<Catalyst::View>, L<Catalyst::Controller>.
-=head1 AUTHOR
+=head1 AUTHORS
-Sebastian Riedel, C<sri@cpan.org>
-Marcus Ramberg, C<mramberg@cpan.org>
-Matt S Trout, C<mst@shadowcatsystems.co.uk>
+Catalyst Contributors, see Catalyst.pm
=head1 COPYRIGHT