Returning zero from PerlIO_read() is okay;

[p5sagit/p5-mst-13.2.git] / ext / Digest / MD5 / MD5.xs

diff --git a/ext/Digest/MD5/MD5.xs b/ext/Digest/MD5/MD5.xs
index 5c90f22..9b60753 100644 (file)
--- a/ext/Digest/MD5/MD5.xs
+++ b/ext/Digest/MD5/MD5.xs
@@ -633,12 +633,8 @@ addfile(self, fh)
                n = PerlIO_read(fh, buffer, missing);
                if (n >= 0)
                    MD5Update(context, buffer, n);
-               else {
-                   if (PerlIO_error(fh)) {
-                       croak("Reading from filehandle failed");
-                   }
+               else
                    XSRETURN(1);  /* self */
-               }
            }
 
            /* Process blocks until EOF or error */
@@ -646,7 +642,7 @@ addfile(self, fh)
                MD5Update(context, buffer, n);
            }
 
-           if (PerlIO_error(fh)) {
+           if (n < 0 && PerlIO_error(fh)) {
                croak("Reading from filehandle failed");
            }
        }